Review main Merged

91315[TASK] Mark unused labels in locallang_core.xlf

Lina Wolf CR +2 V +2 Hard +173 −101 updated 10/29/25, 10:40

Commit message

This is a first step to consolidate all labels in this file.

Additionally add todo comments that make it easier to divide the work of getting rid of this file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Maike Kiebele +1
  • Verified V +2 Done
    • Benni Mack +2
    • Maike Kiebele +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1319

  1. Lina Wolf uploaded patch set 1 10/28/25, 16:44

  2. core-ci voted on patch set 1 V +1 10/28/25, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87866

  3. Lina Wolf uploaded patch set 2 V +1 10/29/25, 06:47

  4. core-ci voted on patch set 2 V +1 10/29/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87904

  5. Lina Wolf uploaded patch set 3 V +1 10/29/25, 07:44

  6. Lina Wolf uploaded patch set 4 10/29/25, 07:47

  7. core-ci voted on patch set 3 V +1 10/29/25, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87905

  8. core-ci voted on patch set 4 V +1 10/29/25, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87906

  9. Lina Wolf updated the commit message in patch set 5 V +1 10/29/25, 07:56

  10. core-ci voted on patch set 5 V +1 10/29/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87907

  11. Benni Mack voted on patch set 5 CR +1 V +1 10/29/25, 08:37

  12. Maike Kiebele commented on patch set 5 CR -1 10/29/25, 09:26

    Working on it
  13. Maike Kiebele uploaded patch set 6 CR +1 V +1 10/29/25, 09:52

  14. Maike Kiebele commented on patch set 6 CR +1 V +1 10/29/25, 09:55

    I went through all the labels that were set to unused again and adjusted them accordingly.
  15. core-ci voted on patch set 6 V +1 10/29/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87926

  16. Benni Mack voted on patch set 6 CR +2 V +2 10/29/25, 10:02

  17. Benni Mack merged patch set 7 10/29/25, 10:02

  18. Oli Bartsch commented on patch set 7 10/29/25, 10:39

    locallang_core.xlf:130 Unresolved

    This is still used in record list.

    locallang_core.xlf:136 Unresolved

    This is still used in record list.

    locallang_core.xlf:138 Unresolved

    This is still used in record list.

    locallang_core.xlf:142 Unresolved

    This is still used in record list.

    locallang_core.xlf:145 Unresolved

    This is still used in record list.

    locallang_core.xlf:151 Unresolved

    This is still used in record list.

    locallang_core.xlf:163 Unresolved

    This is still used in record list.

    locallang_core.xlf:166 Unresolved

    This is still used in record list.

    locallang_core.xlf:169 Unresolved

    This is still used in record list.
  19. Oli Bartsch wrote 10/29/25, 10:40

    Created a revert of this change as Ib93f0609084247a0a47a90d8b8cc4520e39e1194