91321[BUGFIX] Ensure output compression handler is only initialized once
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
- Markus Klein +1
- Christian Kuhn +1
- Sebastian Iffland +1
- Mathias Brodala +1
-
Verified V +2 Done
- Oliver Hader +2
- Markus Klein +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2124
-
Oliver Hader uploaded patch set 1 10/29/25, 09:08
-
core-ci voted on patch set 1 V +1 10/29/25, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87919
-
Oliver Hader updated the commit message in patch set 2
V +110/29/25, 09:46 -
Oliver Hader commented on patch set 2 10/29/25, 09:46
This change is ready for review. -
Mathias Brodala commented on patch set 2 10/29/25, 09:50
OutputCompression.php:65Do we need this additional flag even though you already do the ob_list_handlers() check above? If you do that check earlier here, you can return early. -
Oliver Hader commented on patch set 2 10/29/25, 09:54
OutputCompression.php:65Reply`ob_gzhandler` might be initialized by some other (custom) middleware. The method also assigns `zlib.output_compression_level` above - that's why I did not move the `ob_gzhandler` check to the other `isInitialized` check at the beginning of this method. -
core-ci voted on patch set 2 V +1 10/29/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87924
-
Sebastian Iffland voted on patch set 2 CR +1 10/29/25, 10:00
-
Mathias Brodala commented on patch set 2 10/29/25, 10:02
OutputCompression.php:65ReplyFeels like things could be streamlined here but I get what you mean. Still feels not completely right to make this middleware stateful. -
Markus Klein commented on patch set 2 CR +1 10/29/25, 10:13
OutputCompression.php:65ReplyIt's not the middleware that's stateful. It's the global state that ob_* handler stuff creates. -
Markus Klein voted on patch set 2 V +1 10/29/25, 10:22
-
Christian Kuhn voted on patch set 2 CR +1 V +1 10/29/25, 11:02
-
Oliver Hader commented on patch set 2 10/29/25, 12:05
OutputCompression.php:65ReplyThat's a valid point, of not making the middleware stateful. Thus, we probably should only focus on the reported PHP warning concerning initializing the `ob_gzhandler` again... -
Oliver Hader uploaded patch set 3
CR +1V +110/29/25, 12:20 -
Oliver Hader commented on patch set 3 10/29/25, 12:20
OutputCompression.php:65ReplyDone -
core-ci voted on patch set 3 V +1 10/29/25, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87959
-
Mathias Brodala voted on patch set 3 CR +1 10/29/25, 12:36
-
Sebastian Iffland voted on patch set 3 CR +1 10/29/25, 12:37
-
Christian Kuhn voted on patch set 3 CR +1 V +1 10/29/25, 12:38
-
Christian Kuhn commented on patch set 3 10/29/25, 12:38
OutputCompression.php:65Replymuch better! -
Markus Klein voted on patch set 3 CR +1 V +1 10/29/25, 14:19
-
Oliver Hader voted on patch set 3 CR +2 V +2 10/29/25, 14:38
-
Oliver Klee voted on patch set 3 CR +1 10/29/25, 14:39
-
Oliver Hader merged patch set 4 10/29/25, 14:39