Review main Merged Breaking

91323[!!!][TASK] Utilize translation domain in all tt_content related showitem strings

Lina Wolf CR +2 V +2 Hard +318 −139 updated 10/29/25, 19:36

Commit message

Due to historical reasons (~8-10 years ago), new labels were
added for default Content Types in v7/v8. At this point,
there was no plan on how to deal with XLF / label files
and how to move / change and deprecate this.

So, in order to avoid breaking changes, new labels
were added and the labels were added to the FormEngine
list, instead of the actual field definition.

Nowadays, this can now be consolidated, and used
a) for all TCA tables - these files are put into core.db.general
b) existing fields in tt_content get new labels in their "label"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Fabien Udriot +1
  • Verified V +2 Done
    • Benni Mack +2
    • Fabien Udriot +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1825

  1. Lina Wolf uploaded patch set 1 10/29/25, 10:24

  2. Lina Wolf marked it work in progress 10/29/25, 10:25

  3. core-ci voted on patch set 1 V +1 10/29/25, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87935

  4. Lina Wolf uploaded patch set 2 V +1 10/29/25, 12:13

  5. core-ci voted on patch set 2 V +1 10/29/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87956

  6. Lina Wolf uploaded patch set 3 V +1 10/29/25, 13:19

  7. Lina Wolf uploaded patch set 4 10/29/25, 13:28

  8. Lina Wolf marked it ready for review 10/29/25, 13:29

  9. core-ci voted on patch set 3 V +1 10/29/25, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87970

  10. core-ci voted on patch set 4 V +1 10/29/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87974

  11. Benni Mack commented on patch set 4 10/29/25, 14:46

    tt_content.xlf:84

    didn't we want to move this to a more general file?
  12. Lina Wolf commented on patch set 4 10/29/25, 14:49

    tt_content.xlf:84 Reply

    Didnt we want to schedule clearing up these duplicate labels to a later change?
  13. Maike Kiebele commented on patch set 4 CR +1 V +1 10/29/25, 14:57

    Looks good
  14. Lina Wolf uploaded patch set 5 CR +1 V +1 10/29/25, 17:06

  15. Lina Wolf commented on patch set 5 10/29/25, 17:07

    tt_content.xlf:84 Reply

    Done
  16. Maike Kiebele voted on patch set 5 CR +1 V +1 10/29/25, 17:17

  17. Benni Mack updated the commit message in patch set 6 CR +1 V +1 10/29/25, 17:23

  18. core-ci voted on patch set 5 V +1 10/29/25, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88013

  19. core-ci voted on patch set 6 V +1 10/29/25, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88015

  20. Benni Mack uploaded patch set 7 V +1 10/29/25, 18:16

  21. Fabien Udriot voted on patch set 6 CR +1 10/29/25, 18:22

  22. Fabien Udriot voted on patch set 7 CR +1 V +1 10/29/25, 18:27

  23. core-ci voted on patch set 7 V +1 10/29/25, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88027

  24. Benni Mack voted on patch set 7 CR +2 V +2 10/29/25, 19:36

  25. Benni Mack merged patch set 8 10/29/25, 19:36