Review main Merged

91326[BUGFIX] Do not delete history in install tool + scheduler

Benni Mack CR +2 V +2 Easy +5 −7 updated 10/30/25, 11:34

Commit message

One of the strenghts of TYPO3 being labeled as
Enterprise CMS, the history and audit trail is
quite powerful.

However, in the past, sys_history and sys_log
was intermingled (for e.g. newly created records etc),
so this was extracted in v9. in v13 we've added
proper workspaces support for sys_history, in v14
scheduler tasks have been tracked.

We should - by any means - discourage all admins
to not "simply" truncate sys_history.

Further solutions can be evaluated on how to thin
out history state, but for now, we discourage
this via UI.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Josef Glatz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2327

Show 2 earlier messages
  1. Benni Mack uploaded patch set 1 10/29/25, 10:55

  2. Christian Kuhn commented on patch set 1 CR -1 10/29/25, 10:59

    ClearTableService.php:99

    wrong name.
  1. Benni Mack commented on patch set 2 CR -1 10/29/25, 11:00

    Published edit on patch set 1.
  2. Benni Mack commented on patch set 2 10/29/25, 11:00

    ClearTableService.php:99 Reply

    Done
  3. core-ci voted on patch set 1 V +1 10/29/25, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87941

  4. core-ci voted on patch set 2 V +1 10/29/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87943

  5. Oli Bartsch commented on patch set 2 10/29/25, 11:25

    ClearTableService.php:97

    `sys_preview` is the name of the db table , right?
  6. Oliver Hader commented on patch set 2 10/29/25, 13:56

    ClearTableService.php:97 Reply

    Yepp, it would extension `workspaces` which holds the `sys_preview` table.
  7. Oliver Hader commented on patch set 3 V +1 10/29/25, 13:56

    Published edit on patch set 2.
  8. Oliver Hader commented on patch set 3 10/29/25, 13:57

    ClearTableService.php:97 Reply

    Done
  9. Oliver Hader voted on patch set 3 CR +1 V +1 10/29/25, 14:02

  10. Benjamin Franzke voted on patch set 3 CR +1 V +1 10/29/25, 14:02

  11. core-ci voted on patch set 3 V +1 10/29/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87979

  12. Oli Bartsch voted on patch set 3 CR +1 V +1 10/29/25, 14:06

  13. Georg Ringer commented on patch set 3 V -1 10/29/25, 14:32

    if we backport that to 13.4 we need a proper important rst as configured scheduler tasks will suddenly fail (or what happens if configuration changed for existing tasks?)
  14. Benni Mack commented on patch set 3 10/29/25, 14:47

    Reply

    I think we skip this part in v13.4 backport.
  15. Stefan Bürk voted on patch set 3 CR +1 V +1 10/29/25, 19:39

  16. Garvin Hicking commented on patch set 3 10/29/25, 20:47

    Reply

    I think georg has a point, what happens with the tasks that have this table configured/set? Will the table still be cleared? Will the task fail? Will the table be silently discarded? What happens for TCA migrations of scheduler tasks that had this set?
  17. Benni Mack commented on patch set 3 V -1 10/30/25, 07:54

    retested this, in v14 this will fail if not registered. I suggest to remove this option from scheduler separately (and only main with maybe a breaking RST)
  18. Benni Mack commented on patch set 4 CR +1 V +1 10/30/25, 07:55

    Published edit on patch set 3.
  19. Benni Mack commented on patch set 4 10/30/25, 07:55

    Reply

    Done
  20. Oli Bartsch voted on patch set 4 CR +1 V +1 10/30/25, 08:01

  21. Benjamin Franzke voted on patch set 4 CR +1 V +1 10/30/25, 08:03

  22. core-ci voted on patch set 4 V +1 10/30/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88085

  23. Josef Glatz voted on patch set 4 CR +1 10/30/25, 08:04

  24. Oli Bartsch voted on patch set 4 CR +2 V +2 10/30/25, 11:34

  25. Oli Bartsch merged patch set 5 10/30/25, 11:34