91326[BUGFIX] Do not delete history in install tool + scheduler
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Josef Glatz +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2327
Show 2 earlier messages
-
Benni Mack commented on patch set 2
CR -110/29/25, 11:00Published edit on patch set 1. -
Benni Mack commented on patch set 2 10/29/25, 11:00
ClearTableService.php:99ReplyDone -
core-ci voted on patch set 1 V +1 10/29/25, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87941
-
core-ci voted on patch set 2 V +1 10/29/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87943
-
Oli Bartsch commented on patch set 2 10/29/25, 11:25
ClearTableService.php:97`sys_preview` is the name of the db table , right? -
Oliver Hader commented on patch set 2 10/29/25, 13:56
ClearTableService.php:97ReplyYepp, it would extension `workspaces` which holds the `sys_preview` table. -
Oliver Hader commented on patch set 3
V +110/29/25, 13:56Published edit on patch set 2. -
Oliver Hader commented on patch set 3 10/29/25, 13:57
ClearTableService.php:97ReplyDone -
Oliver Hader voted on patch set 3 CR +1 V +1 10/29/25, 14:02
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 10/29/25, 14:02
-
core-ci voted on patch set 3 V +1 10/29/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87979
-
Oli Bartsch voted on patch set 3 CR +1 V +1 10/29/25, 14:06
-
Georg Ringer commented on patch set 3 V -1 10/29/25, 14:32
if we backport that to 13.4 we need a proper important rst as configured scheduler tasks will suddenly fail (or what happens if configuration changed for existing tasks?) -
Benni Mack commented on patch set 3 10/29/25, 14:47
Reply
I think we skip this part in v13.4 backport. -
Stefan Bürk voted on patch set 3 CR +1 V +1 10/29/25, 19:39
-
Garvin Hicking commented on patch set 3 10/29/25, 20:47
Reply
I think georg has a point, what happens with the tasks that have this table configured/set? Will the table still be cleared? Will the task fail? Will the table be silently discarded? What happens for TCA migrations of scheduler tasks that had this set? -
Benni Mack commented on patch set 3 V -1 10/30/25, 07:54
retested this, in v14 this will fail if not registered. I suggest to remove this option from scheduler separately (and only main with maybe a breaking RST) -
Benni Mack commented on patch set 4
CR +1V +110/30/25, 07:55Published edit on patch set 3. -
Benni Mack commented on patch set 4 10/30/25, 07:55
Reply
Done -
Oli Bartsch voted on patch set 4 CR +1 V +1 10/30/25, 08:01
-
Benjamin Franzke voted on patch set 4 CR +1 V +1 10/30/25, 08:03
-
core-ci voted on patch set 4 V +1 10/30/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88085
-
Josef Glatz voted on patch set 4 CR +1 10/30/25, 08:04
-
Oli Bartsch voted on patch set 4 CR +2 V +2 10/30/25, 11:34
-
Oli Bartsch merged patch set 5 10/30/25, 11:34
ClearTableService.php:99