Review main Abandoned

91327[FEATURE] Introduce DocHeader Component API for backend module

Oli Bartsch CR 0 V -1 Nightmare +2473 −855 updated 11/09/25, 15:39

Commit message

Introduces a new DocHeader Component API that provides a unified
and consistent approach for handling document header components
in TYPO3 backend modules. This API manages three types of dropdowns:
module actions, view settings, and the language selector.

The API replaces the deprecated makeDocHeaderModuleMenu() method
and the MenuRegistry system, while maintaining backward compatibility
through automatic migration.

The primary use case is submodule navigation via the new
addSubmoduleNavigation() method, which automatically generates
navigation items for all accessible submodules.

Key components:

* DocHeaderComponentBuilder - Builder class with fluent API for
constructing module actions, view settings, and language selector

* DocHeaderComponentItem - Immutable DTO representing items in
dropdown sections

* BeforeDocHeaderComponentsAreBuiltEvent - PSR-14 event providing
access to the builder instance for manipulation by extensions

Three dropdown types:

1. Module Actions (LEFT, group 0) - Submodule navigation or custom
   actions with current item as button label

2. View Settings (RIGHT, priority 0) - View modes, toggles, filters,
   and display options

3. Language Selector (Top right area) - Language selection for
   multilingual content

The deprecated Menu, MenuItem, and MenuRegistry classes continue to
work but are automatically converted to module actions during rendering.
Extension scanner support has been added to detect usage of deprecated
classes.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 50

Show 30 more files

Review log 813

  1. Oli Bartsch uploaded patch set 1 10/29/25, 11:10

  2. core-ci voted on patch set 1 V -1 10/29/25, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87947

  3. Benjamin Kott commented on patch set 1 CR -1 10/29/25, 13:57

    Feels better to have the breadcrumb on the left side. Some issues: - It feels wrong to be placed in the view module as it changes behavior and not a view on the same data, "View" Seems wrong here. I think it should not go into the view dropdown. - Also the placement of the view option now feel wrong as i would expect them somewhere on the right as they are not essential for navigation. - I think we should not mix navigation and view when they are not the same. - Page Module without translatable options shows the the display mode with only 1 item but also does not select the current active mode. - For items with overview pages like info / pagetree overview is the back button now placed after the view settings, this somehow feel wiered as i would expect it atleast in the first position - Filelist, view settings are now also far away from their relatives like sorting - Inconsistend naming for the module menus like, display mode and module actions, its also not clear that we are in a certain state without opening them
  4. Oli Bartsch uploaded patch set 2 CR -1 V -1 10/30/25, 19:31

  5. core-ci voted on patch set 2 V -1 10/30/25, 19:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88183

  6. Oli Bartsch uploaded patch set 3 V -1 10/30/25, 20:00

  7. core-ci voted on patch set 3 V -1 10/30/25, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88187

  8. Oli Bartsch uploaded patch set 4 V -1 10/30/25, 20:15

  9. core-ci voted on patch set 4 V -1 10/30/25, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88190

  10. Garvin Hicking updated the commit message in patch set 5 V -1 10/31/25, 07:15

  11. core-ci voted on patch set 5 V -1 10/31/25, 07:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88229

  12. Chris Müller commented on patch set 5 10/31/25, 07:28

    Deprecation-107824-ButtonBarMakeMethods.rst:123 Unresolved

    ```suggestion -------------------------------------- ```
  13. Oli Bartsch abandoned the change 11/09/25, 15:39

    We found a better alternative.