Review main Merged

91329[BUGFIX] Do not add cache busting to folders

Helmut Hummel CR +2 V +2 Easy +9 −1 updated 10/29/25, 15:45

Commit message

It might be useful to generate URIs for folders,
but them having cache busting applied does not make
sense and is buggy.

Therefore the check for file existence must be changed
from file_exists to is_file, as the latter only returns
true it the referenced path is a file (or a symlink to a file)

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Simon Praetorius +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Simon Praetorius +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Helmut Hummel uploaded patch set 1 10/29/25, 12:09

  2. Oliver Klee voted on patch set 1 CR +1 V +1 10/29/25, 12:15

  3. Helmut Hummel uploaded patch set 2 CR +1 V +1 10/29/25, 12:16

  4. core-ci voted on patch set 1 V +1 10/29/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87954

  5. Simon Praetorius voted on patch set 2 CR +1 V +1 10/29/25, 12:27

  6. core-ci voted on patch set 2 V +1 10/29/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87957

  7. Oliver Klee voted on patch set 2 CR +1 V +1 10/29/25, 12:33

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 10/29/25, 12:44

  9. Helmut Hummel voted on patch set 2 CR +2 V +2 10/29/25, 15:44

  10. Helmut Hummel merged patch set 3 10/29/25, 15:45