Review main Merged

91332[TASK] Inline remaining TSFE methods to RequestHandler

Christian Kuhn CR +2 V +2 Expert +539 −754 updated 11/14/25, 19:05

Commit message

Clean up and merge the remaining service methods of
TypoScriptFrontendController into FE RequestHandler.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2033

Show 48 earlier messages
  1. Christian Kuhn uploaded patch set 1 10/29/25, 12:47

  2. core-ci voted on patch set 1 V +1 10/29/25, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87965

  3. Christian Kuhn uploaded patch set 2 V +1 10/29/25, 13:12

  4. core-ci voted on patch set 2 V +1 10/29/25, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87966

  5. Christian Kuhn uploaded patch set 3 V +1 10/29/25, 14:14

  6. Christian Kuhn uploaded patch set 4 10/29/25, 14:17

  7. core-ci voted on patch set 3 V +1 10/29/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87983

  8. core-ci voted on patch set 4 V +1 10/29/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87984

  1. Christian Kuhn uploaded patch set 5 V +1 11/13/25, 15:52

  2. core-ci voted on patch set 5 V +1 11/13/25, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89546

  3. Christian Kuhn uploaded patch set 6 V +1 11/13/25, 17:01

  4. core-ci voted on patch set 6 V +1 11/13/25, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89553

  5. Benni Mack commented on patch set 6 11/13/25, 21:22

    RequestHandler.php:198

    I think we can remove this now without any further comments tbh
  6. Christian Kuhn commented on patch set 6 11/14/25, 01:23

    RequestHandler.php:198 Reply

    not *that* easy. i think a .rst file is appropriate: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91652
  7. Christian Kuhn uploaded patch set 7 V +1 11/14/25, 11:09

  8. core-ci voted on patch set 7 V +1 11/14/25, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89677

  9. Christian Kuhn uploaded patch set 8 V +1 11/14/25, 15:26

  10. core-ci voted on patch set 8 V +1 11/14/25, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89695

  11. Christian Kuhn uploaded patch set 9 V +1 11/14/25, 18:02

  12. core-ci voted on patch set 9 V +1 11/14/25, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89706

  13. Christian Kuhn uploaded patch set 10 V +1 11/14/25, 18:14

  14. Christian Kuhn uploaded patch set 11 11/14/25, 18:20

  15. core-ci voted on patch set 10 V +1 11/14/25, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89707

  16. Christian Kuhn uploaded patch set 12 11/14/25, 18:24

  17. core-ci voted on patch set 11 V +1 11/14/25, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89708

  18. core-ci voted on patch set 12 V +1 11/14/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89709

  19. Christian Kuhn uploaded patch set 13 V +1 11/14/25, 18:51

  20. Benni Mack voted on patch set 13 CR +1 V +1 11/14/25, 18:54

  21. Anja Leichsenring commented on patch set 13 CR +1 V +1 11/14/25, 18:58

    t3clap and congratualions. An era ends here, bye bye TSFC, you deserve your retirement.
  22. core-ci voted on patch set 13 V +1 11/14/25, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89712

  23. Anja Leichsenring commented on patch set 13 11/14/25, 18:59

    Reply

    yeah, typo of course. Its congratulations.
  24. Christian Kuhn voted on patch set 13 CR +2 V +2 11/14/25, 19:05

  25. Christian Kuhn merged patch set 14 11/14/25, 19:05