Review main Merged

91337[BUGFIX] Properly handle default fallback in f:translate ViewHelper

Lina Wolf CR +2 V +2 Easy +9 −1 updated 10/30/25, 08:50

Commit message

If property "default" is set to a non-empty string the exception
"ViewHelper f:translate in non-extbase context" must never be
thrown.

This enables usage like
`{f:translate(key:item.label,default:item.label)}`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1217

  1. Lina Wolf uploaded patch set 1 10/29/25, 14:57

  2. Lina Wolf updated the commit message in patch set 2 10/29/25, 14:58

  3. Benni Mack commented on patch set 2 10/29/25, 15:51

    TranslateViewHelperTest.php:196

    I suggest to use a different example, where default is different than key, so we know?
  4. Garvin Hicking updated the commit message in patch set 3 10/29/25, 15:53

  5. Garvin Hicking commented on patch set 3 10/29/25, 15:53

    TranslateViewHelperTest.php:196 Reply

    Let's have both?
  6. Lina Wolf uploaded patch set 4 10/29/25, 16:14

  7. Lina Wolf commented on patch set 4 10/29/25, 16:14

    TranslateViewHelperTest.php:196 Reply

    Done
  8. Benni Mack commented on patch set 5 10/29/25, 16:47

    Published edit on patch set 4.
  9. Lina Wolf commented on patch set 5 CR +1 V +1 10/29/25, 16:52

    Looks good, voting vor Benni's changes
  10. core-ci voted on patch set 1 V +1 10/29/25, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87995

  11. core-ci voted on patch set 2 V +1 10/29/25, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87997

  12. Garvin Hicking voted on patch set 5 CR +1 V +1 10/29/25, 17:31

  13. core-ci voted on patch set 3 V +1 10/29/25, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88004

  14. core-ci voted on patch set 4 V +1 10/29/25, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88006

  15. core-ci voted on patch set 5 V +1 10/29/25, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88010

  16. Benni Mack voted on patch set 5 CR +2 V +2 10/30/25, 08:50

  17. Benni Mack merged patch set 6 10/30/25, 08:50