91338[BUGFIX] Allow versioned `PID=0` records with ignoreRootLevelRestriction
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 1
Review log 1823
-
Thorsten Müller uploaded patch set 1 10/29/25, 15:01
-
Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 10/29/25, 15:06
-
Stefan Bürk commented on patch set 1 10/29/25, 15:08
-
Stefan Bürk voted on patch set 1 CR -1 10/29/25, 15:10
-
Thorsten Müller uploaded patch set 2
CR +1V +110/29/25, 16:02 -
core-ci voted on patch set 1 V -1 10/29/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87998
-
core-ci voted on patch set 2 V -1 10/29/25, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88005
-
Stefan Bürk commented on patch set 2 CR -1 10/30/25, 11:44
Unresolved
Looking into this ... (Reviewing, Playing around, working, ...) -
Stefan Bürk uploaded patch set 3
CR -1V -110/30/25, 14:10 -
Stefan Bürk commented on patch set 3 10/30/25, 14:20
DataHandler.php:6416ReplyNot that simple as I originally thought. Worked on it. -
core-ci voted on patch set 3 V +1 10/30/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88153
-
Thorsten Müller commented on patch set 3 10/30/25, 15:46
DataHandler.php:6416Reply UnresolvedNeither AND nor OR is correct at this point. We need to intercept the following cases: pid=0 AND TCA->ignoreRootLevelRestriction=1. shallIgnoreRootLevelRestriction must be checked, Permissions must not be checked (otherwise a 503 error) pid=0 AND TCA->ignoreRootLevelRestriction=0, shallIgnoreRootLevelRestriction must be checked, Permissions must not be checked, new error message will be logged. pid>0, Permissions must be checked. My new iteration is pushed -
Stefan Bürk marked it work in progress 10/31/25, 15:58
-
Andreas Wolf commented on patch set 3 12/09/25, 15:28
This is also related to #107379 AFAICS. -
Thorsten Müller uploaded patch set 4
V +112/11/25, 15:30 -
core-ci voted on patch set 4 V -1 12/11/25, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92073
-
Thorsten Müller commented on patch set 4 12/11/25, 15:50
This change is ready for review.I tested the changes from Patchset 3, but i got the same error as before. My last changes from Patchset 4 are similar to my first solution, but a bit cleaner. It works as expected, bypassing the hasPagePermission check when pid=0 was given, while throwing a new error, if the records TCA does not ignore root level restriction. If there are some other valid cases that could occur at pid=0, please add them here! -
Christian Kuhn commented on patch set 4 CR -1 12/11/25, 15:54
there are multiple issues in forge about this or very similar things, redirects is afaik affected, too. they should be connected and we have infos on some of the connected ones that should have an eye before taking a decision here. -
Christian Kuhn commented on patch set 4 12/11/25, 15:55
https://review.typo3.org/c/Packages/TYPO3.CMS/+/92067 similar as well? -
Benni Mack updated the commit message in patch set 5
CR -1V -104/22/26, 06:38 -
core-ci voted on patch set 5 V -1 04/22/26, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100745
-
Christian Kuhn wrote 06/18/26, 23:09
Removed reviewer Christian Kuhn. -
Benni Mack abandoned the change 09/02/26, 20:31
Abandoning in favor of #107432, fixed already
DataHandler.php:6416