Review main Merged

91340[FEATURE] Make new content element wizard items sort order configurable

Fabien Udriot CR +2 V +2 Hard +440 −3 updated 02/07/26, 12:57

Commit message

It is now possible to influence the order of content elements
within wizard tabs in the new content element wizard by setting
`before` and `after` values in Page TSconfig at the element level.

The ordering mechanism uses the existing `DependencyOrderingService`
to resolve dependencies and preserve the relative order of elements
without explicit dependencies, while allowing explicit positioning
via `before` and `after` configurations.

Example:
  mod.wizards.newContentElement.wizardItems {
      default.elements {
          textmedia {
              after = header
          }
          header {
              before = textmedia
          }
      }
  }

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2736

Show 811 earlier messages
  1. Fabien Udriot uploaded patch set 1 10/29/25, 15:39

  2. Fabien Udriot marked it work in progress 10/29/25, 15:42

  3. Fabien Udriot uploaded patch set 2 10/29/25, 16:17

  4. Fabien Udriot marked it ready for review 10/29/25, 16:18

  5. Francois Suter commented on patch set 2 CR +1 V +1 10/29/25, 16:58

    Very nice feature!
  6. core-ci voted on patch set 2 V +1 10/29/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88007

  7. core-ci voted on patch set 1 V -1 10/29/25, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88002

  8. Fabien Udriot rebased onto patch set 3 CR +1 V +1 10/29/25, 19:54

  9. core-ci voted on patch set 3 V +1 10/29/25, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88040

  10. Francois Suter voted on patch set 3 CR +1 V +1 10/30/25, 08:45

  11. Jasmina Ließmann voted on patch set 3 V +1 10/30/25, 16:03

  1. Guido Schmechel commented on patch set 3 V -1 10/30/25, 16:42

    If I use incorrect or non-existent keys in the configuration, an empty tile is displayed in the wizard. Can we still intercept this?
  2. Bastien Lutz uploaded patch set 4 CR +1 V +1 02/03/26, 15:17

  3. core-ci voted on patch set 4 V -1 02/03/26, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94924

  4. Bastien Lutz uploaded patch set 5 V -1 02/03/26, 15:34

  5. core-ci voted on patch set 5 V +1 02/03/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94926

  6. Oliver Hader uploaded patch set 6 V +1 02/04/26, 09:17

  7. core-ci voted on patch set 6 V -1 02/04/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94979

  8. Jasmina Ließmann wrote 02/04/26, 09:28

    Removed reviewer Jasmina Ließmann.
  9. Oliver Hader uploaded patch set 7 V -1 02/04/26, 09:49

  10. core-ci voted on patch set 7 V +1 02/04/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94988

  11. Oliver Hader uploaded patch set 8 V +1 02/04/26, 10:48

  12. Oliver Hader voted on patch set 8 CR +1 V +1 02/04/26, 10:50

  13. core-ci voted on patch set 8 V -1 02/04/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95006

  14. Oliver Hader uploaded patch set 9 CR +1 V +1 02/04/26, 15:15

  15. Oliver Hader voted on patch set 9 CR +1 V +1 02/04/26, 15:16

  16. core-ci voted on patch set 9 V +1 02/04/26, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95053

  17. Georg Ringer voted on patch set 9 CR +1 V +1 02/04/26, 19:42

  18. Guido Schmechel voted on patch set 9 CR +1 V +1 02/04/26, 20:39

  19. Oliver Hader voted on patch set 9 CR +2 V +2 02/05/26, 09:11

  20. Oliver Hader merged patch set 10 02/05/26, 09:12

  21. Karsten Nowak commented on patch set 10 02/05/26, 15:53

    What happens if `before`and `after` is set? Even if the two settings are contradictory.
  22. Simon Schaufelberger commented on patch set 10 02/05/26, 22:49

    Reply

    Using both would be between if that is possible. If not, then I don't know.
  23. Karsten Nowak commented on patch set 10 02/06/26, 08:17

    Reply

    The possibility exists, even if it is unlikely. Perhaps through two extensions that define it differently. The order of integration probably also determines the result. I am asking because I want to include a note about this case in the documentation.
  24. Oliver Hader commented on patch set 10 02/06/26, 16:40

    Reply

    Did you test, what actually happens when `before` and `after` are used at the same time? I guess(!) the dependency-ordering-service would throw an exception in that case...
  25. Guido Schmechel commented on patch set 10 02/07/26, 12:57

    Reply Unresolved

    I've tested with: mod.wizards.newContentElement.wizardItems { default.elements { textmedia { before = header } header { before = textmedia } } } (1/1) #1381960494 UnexpectedValueException Your dependencies have cycles. That will not work out. Cycles found: header.->textmedia., textmedia.->header. Looks good for me :-)