91340[FEATURE] Make new content element wizard items sort order configurable
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Guido Schmechel +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 3
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+72 −3
- typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.php+303 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-87435-MakeNewContentElementWizardItemsSortOrderConfigurable.rstnew+65 −0
Review log 2736
Show 811 earlier messages
-
Fabien Udriot uploaded patch set 1 10/29/25, 15:39
-
Fabien Udriot marked it work in progress 10/29/25, 15:42
-
Fabien Udriot uploaded patch set 2 10/29/25, 16:17
-
Fabien Udriot marked it ready for review 10/29/25, 16:18
-
Francois Suter commented on patch set 2 CR +1 V +1 10/29/25, 16:58
Very nice feature! -
core-ci voted on patch set 2 V +1 10/29/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88007
-
core-ci voted on patch set 1 V -1 10/29/25, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88002
-
Fabien Udriot rebased onto patch set 3
CR +1V +110/29/25, 19:54 -
core-ci voted on patch set 3 V +1 10/29/25, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88040
-
Francois Suter voted on patch set 3 CR +1 V +1 10/30/25, 08:45
-
Jasmina Ließmann voted on patch set 3 V +1 10/30/25, 16:03
-
Guido Schmechel commented on patch set 3 V -1 10/30/25, 16:42
If I use incorrect or non-existent keys in the configuration, an empty tile is displayed in the wizard. Can we still intercept this? -
Bastien Lutz uploaded patch set 4
CR +1V +102/03/26, 15:17 -
core-ci voted on patch set 4 V -1 02/03/26, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94924
-
Bastien Lutz uploaded patch set 5
V -102/03/26, 15:34 -
core-ci voted on patch set 5 V +1 02/03/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94926
-
Oliver Hader uploaded patch set 6
V +102/04/26, 09:17 -
core-ci voted on patch set 6 V -1 02/04/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94979
-
Jasmina Ließmann wrote 02/04/26, 09:28
Removed reviewer Jasmina Ließmann. -
Oliver Hader uploaded patch set 7
V -102/04/26, 09:49 -
core-ci voted on patch set 7 V +1 02/04/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94988
-
Oliver Hader uploaded patch set 8
V +102/04/26, 10:48 -
Oliver Hader voted on patch set 8 CR +1 V +1 02/04/26, 10:50
-
core-ci voted on patch set 8 V -1 02/04/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95006
-
Oliver Hader uploaded patch set 9
CR +1V +102/04/26, 15:15 -
Oliver Hader voted on patch set 9 CR +1 V +1 02/04/26, 15:16
-
core-ci voted on patch set 9 V +1 02/04/26, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95053
-
Georg Ringer voted on patch set 9 CR +1 V +1 02/04/26, 19:42
-
Guido Schmechel voted on patch set 9 CR +1 V +1 02/04/26, 20:39
-
Oliver Hader voted on patch set 9 CR +2 V +2 02/05/26, 09:11
-
Oliver Hader merged patch set 10 02/05/26, 09:12
-
Karsten Nowak commented on patch set 10 02/05/26, 15:53
What happens if `before`and `after` is set? Even if the two settings are contradictory. -
Simon Schaufelberger commented on patch set 10 02/05/26, 22:49
Reply
Using both would be between if that is possible. If not, then I don't know. -
Karsten Nowak commented on patch set 10 02/06/26, 08:17
Reply
The possibility exists, even if it is unlikely. Perhaps through two extensions that define it differently. The order of integration probably also determines the result. I am asking because I want to include a note about this case in the documentation. -
Oliver Hader commented on patch set 10 02/06/26, 16:40
Reply
Did you test, what actually happens when `before` and `after` are used at the same time? I guess(!) the dependency-ordering-service would throw an exception in that case... -
Guido Schmechel commented on patch set 10 02/07/26, 12:57
Reply Unresolved
I've tested with: mod.wizards.newContentElement.wizardItems { default.elements { textmedia { before = header } header { before = textmedia } } } (1/1) #1381960494 UnexpectedValueException Your dependencies have cycles. That will not work out. Cycles found: header.->textmedia., textmedia.->header. Looks good for me :-)