Review main Merged

91343[FEATURE] Show editor information in workspace overview

Fabien Udriot CR +2 V +2 Easy +34 −12 updated 10/30/25, 12:49

Commit message

Add a new "Editor" column to the workspace module that displays
the username of the last editor who modified each record. The
editor information is retrieved from the record history and
displayed after the "Last changed on" column.

The column shows the editor's username in a badge, or "Unknown"
if no editor information is available. This helps reviewers
quickly identify who last worked on each workspace record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Fabien Udriot +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Fabien Udriot +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2232

Show 47 earlier messages
  1. Fabien Udriot uploaded patch set 1 10/29/25, 17:26

  2. Fabien Udriot marked it work in progress 10/29/25, 17:26

  3. Fabien Udriot uploaded patch set 2 10/29/25, 17:34

  4. core-ci voted on patch set 1 V +1 10/29/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88016

  5. core-ci voted on patch set 2 V +1 10/29/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88019

  6. Fabien Udriot uploaded patch set 3 V +1 10/29/25, 19:30

  7. core-ci voted on patch set 3 V +1 10/29/25, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88034

  1. Fabien Udriot uploaded patch set 4 V +1 10/29/25, 19:40

  2. Fabien Udriot uploaded patch set 5 10/29/25, 19:41

  3. Fabien Udriot marked it ready for review 10/29/25, 19:43

  4. core-ci voted on patch set 4 V +1 10/29/25, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88035

  5. core-ci voted on patch set 5 V +1 10/29/25, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88036

  6. Oli Bartsch commented on patch set 5 CR -1 10/30/25, 08:12

    HistoryService.php:149

    I really like that change! Please let's not make this public and avoid using this directly. We should always use getHistory() since this also implements a limit of 20 (performance). We should then update underlying getHistory() to provide all necessary information about the backend user. Additionally, please let's combine last changed on and last changed by and not introduce another column which makes this already big view even larger.
  7. Benni Mack commented on patch set 5 10/30/25, 08:42

    HistoryService.php:149 Reply

    If we start to sort by columns, it is necessary to have this in two columns - sort by date, sort by user.
  8. Oli Bartsch commented on patch set 5 10/30/25, 08:44

    HistoryService.php:149 Reply

    But we don't have sorting here. I also would rather introduce dynamic filters to limit the view instead of sorting. This would integrate better in the current UX since we already have a filter bar.
  9. Fabien Udriot uploaded patch set 6 CR -1 V +1 10/30/25, 10:43

  10. core-ci voted on patch set 6 V -1 10/30/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88108

  11. Fabien Udriot uploaded patch set 7 V -1 10/30/25, 11:06

  12. Fabien Udriot commented on patch set 7 10/30/25, 11:08

    HistoryService.php:149 Reply

    The latest version of the change adds column sorting for the "editor" column. We can add sorting for the other columns separately.
  13. Oli Bartsch uploaded patch set 8 10/30/25, 11:09

  14. Oli Bartsch uploaded patch set 9 10/30/25, 11:10

  15. Benni Mack commented on patch set 9 10/30/25, 11:11

    record-table.ts:138

    I don't like the bootstrap styling via classes here, but using a custom component is probably a bit too much for the time being.

    record-table.ts:249

    same
  16. Oli Bartsch commented on patch set 9 CR +1 V +1 10/30/25, 11:12

    HistoryService.php:149 Reply

    Hi Fabien. Let's focus on the info in this patch. If we add sorting or filtering. THis should be done in a whole. We already have components for this, so there wouldn't be the need for custom sorting logic.
  17. core-ci voted on patch set 7 V -1 10/30/25, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88111

  18. core-ci voted on patch set 8 V -1 10/30/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88112

  19. Oli Bartsch uploaded patch set 10 CR +1 V +1 10/30/25, 11:17

  20. Oli Bartsch commented on patch set 10 CR +1 V +1 10/30/25, 11:18

    record-table.ts:138 Reply

    Acknowledged

    record-table.ts:249 Reply

    Acknowledged
  21. core-ci voted on patch set 9 V +1 10/30/25, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88113

  22. core-ci voted on patch set 10 V +1 10/30/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88114

  23. Fabien Udriot voted on patch set 10 CR +1 V +1 10/30/25, 11:39

  24. Benni Mack voted on patch set 10 CR +2 V +2 10/30/25, 12:49

  25. Benni Mack merged patch set 11 10/30/25, 12:49