91343[FEATURE] Show editor information in workspace overview
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Fabien Udriot +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Fabien Udriot +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts4+21 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+5 −0
- typo3/sysext/workspaces/Classes/Service/HistoryService.php5+2 −7
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+5 −2
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+1 −1
Review log 2232
Show 47 earlier messages
-
Fabien Udriot uploaded patch set 1 10/29/25, 17:26
-
Fabien Udriot marked it work in progress 10/29/25, 17:26
-
Fabien Udriot uploaded patch set 2 10/29/25, 17:34
-
core-ci voted on patch set 1 V +1 10/29/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88016
-
core-ci voted on patch set 2 V +1 10/29/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88019
-
Fabien Udriot uploaded patch set 3
V +110/29/25, 19:30 -
core-ci voted on patch set 3 V +1 10/29/25, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88034
-
Fabien Udriot uploaded patch set 4
V +110/29/25, 19:40 -
Fabien Udriot uploaded patch set 5 10/29/25, 19:41
-
Fabien Udriot marked it ready for review 10/29/25, 19:43
-
core-ci voted on patch set 4 V +1 10/29/25, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88035
-
core-ci voted on patch set 5 V +1 10/29/25, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88036
-
Oli Bartsch commented on patch set 5 CR -1 10/30/25, 08:12
-
Benni Mack commented on patch set 5 10/30/25, 08:42
HistoryService.php:149ReplyIf we start to sort by columns, it is necessary to have this in two columns - sort by date, sort by user. -
Oli Bartsch commented on patch set 5 10/30/25, 08:44
HistoryService.php:149ReplyBut we don't have sorting here. I also would rather introduce dynamic filters to limit the view instead of sorting. This would integrate better in the current UX since we already have a filter bar. -
Fabien Udriot uploaded patch set 6
CR -1V +110/30/25, 10:43 -
core-ci voted on patch set 6 V -1 10/30/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88108
-
Fabien Udriot uploaded patch set 7
V -110/30/25, 11:06 -
Fabien Udriot commented on patch set 7 10/30/25, 11:08
HistoryService.php:149ReplyThe latest version of the change adds column sorting for the "editor" column. We can add sorting for the other columns separately. -
Oli Bartsch uploaded patch set 8 10/30/25, 11:09
-
Oli Bartsch uploaded patch set 9 10/30/25, 11:10
-
Benni Mack commented on patch set 9 10/30/25, 11:11
record-table.ts:138I don't like the bootstrap styling via classes here, but using a custom component is probably a bit too much for the time being.record-table.ts:249same -
Oli Bartsch commented on patch set 9 CR +1 V +1 10/30/25, 11:12
HistoryService.php:149ReplyHi Fabien. Let's focus on the info in this patch. If we add sorting or filtering. THis should be done in a whole. We already have components for this, so there wouldn't be the need for custom sorting logic. -
core-ci voted on patch set 7 V -1 10/30/25, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88111
-
core-ci voted on patch set 8 V -1 10/30/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88112
-
Oli Bartsch uploaded patch set 10
CR +1V +110/30/25, 11:17 -
Oli Bartsch commented on patch set 10 CR +1 V +1 10/30/25, 11:18
record-table.ts:138ReplyAcknowledgedrecord-table.ts:249ReplyAcknowledged -
core-ci voted on patch set 9 V +1 10/30/25, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88113
-
core-ci voted on patch set 10 V +1 10/30/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88114
-
Fabien Udriot voted on patch set 10 CR +1 V +1 10/30/25, 11:39
-
Benni Mack voted on patch set 10 CR +2 V +2 10/30/25, 12:49
-
Benni Mack merged patch set 11 10/30/25, 12:49
HistoryService.php:149