91347[TASK] Move page doktype labels into pages.xlf
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Configuration/TCA/pages.php2+10 −10
- typo3/sysext/core/Resources/Private/Language/db/pages/doktype.xlf12deleted+0 −10
- typo3/sysext/core/Resources/Private/Language/db/pages.xlf+50 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+3 −3
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+12 −15
Review log 2634
Show 69 earlier messages
-
Lina Wolf uploaded patch set 1 10/29/25, 18:36
-
core-ci voted on patch set 1 V +1 10/29/25, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88031
-
Maike Kiebele rebased onto patch set 2
V +110/29/25, 19:48 -
core-ci voted on patch set 2 V +1 10/29/25, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88038
-
Maike Kiebele voted on patch set 2 CR +1 V +1 10/30/25, 11:36
-
Jasmina Ließmann commented on patch set 2 10/30/25, 13:45
doktype.xlfPersonal note from me: I would appreciate it if the keys were arranged in alphabetical order – in every language file. From my everyday experience working with many different colleagues, alphabetical filing/sorting is more helpful than a random order in which each developer adds their keys at the top/bottom or in the middle of the document. With alphabetical sorting, existing keys can be found more quickly and duplicates can be avoided. Would it be possible to take this into account when creating new language files?doktype.xlf:34The "folder" key exists twice inside this file. -
Lina Wolf uploaded patch set 3
CR +1V +110/30/25, 14:05 -
Lina Wolf commented on patch set 3 10/30/25, 14:07
pages.php:71ReplyThe current numbers used in the XLF files are not the same like those used by the constants. The numbers themselves do not have any meaning beyond that they are used for database storage. So I believe the names from the constants or enum cases should be used and not a meaningless numerical value. Expeciall not if the two numerical values contradict each other.doktype.xlfReplyI put them in the order in which they appear in the select dropdown which I think is more logic. And all groups together. I would not oppose an automatic tool that sorts for you but manual sorting is a pain in the neck...doktype.xlf:34ReplyDone -
core-ci voted on patch set 3 V +1 10/30/25, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88151
-
Lina Wolf commented on patch set 3 10/30/25, 14:21
doktype.xlfReplyunresolve -
Jasmina Ließmann commented on patch set 3 10/30/25, 14:26
doktype.xlfReplyThis is a newly created file with 10 keys. It shouldn't be that problematic to sort them from the very first start. -
Lina Wolf commented on patch set 3 10/30/25, 14:28
doktype.xlfReplyIt is not worth putting the time in it in my eyes. ppl search these files with PHP storm or some such. Benni agreed when I asked him -
Garvin Hicking commented on patch set 3 CR +1 V +1 11/10/25, 14:37
I acknowledge the wish for alphabetically sorted keys, however I also understand that grouping keys "logically" can be quite helpful too. I hope that's fine, and I think we could discuss changing this systematically on its own? -
Oliver Klee voted on patch set 3 CR +1 V +1 11/12/25, 08:03
-
Benni Mack commented on patch set 3 11/12/25, 08:39
doktype.xlf:1how deep / nested should we go with the files? I thought we'd go with "one file per TCA table" to have the semantics in line. What would be a good "rule of thumb" here? -
Garvin Hicking commented on patch set 3 11/12/25, 10:22
doktype.xlf:1ReplyGood note, I did not properly pay attention to this. I think I would prefer "Language/db/pages.xlf" actually, yes. Makes it too scattered otherwise. -
Lina Wolf commented on patch set 3 11/12/25, 10:27
doktype.xlf:1ReplyMy idea was to use small single purpose domains and then you can do something like `$myDoktype = $languageService->translate($row['doktype'], 'core.db.pages.doktype')??$row['doktype'];` -
Lina Wolf commented on patch set 3 11/12/25, 10:28
doktype.xlf:1Replyinstead of `$myDoktype = $languageService->translate('doktype' . $row['doktype'], 'core.db.pages')??$row['doktype'];` -
Lina Wolf uploaded patch set 4
CR +1V +111/26/25, 13:04 -
Lina Wolf commented on patch set 4 11/26/25, 13:05
doktype.xlf:1ReplyDone -
Lina Wolf updated the commit message in patch set 5 11/26/25, 13:06
-
core-ci voted on patch set 4 V +1 11/26/25, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91028
-
core-ci voted on patch set 5 V +1 11/26/25, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91029
-
Garvin Hicking voted on patch set 5 CR +1 V +1 11/27/25, 08:20
-
Lina Wolf uploaded patch set 6
CR +1V +112/09/25, 09:49 -
core-ci voted on patch set 6 V +1 12/09/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91876
-
Lina Wolf rebased onto patch set 7
V +112/09/25, 15:30 -
core-ci voted on patch set 7 V +1 12/09/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91912
-
Garvin Hicking voted on patch set 7 CR +1 V +1 12/12/25, 11:52
-
Benni Mack voted on patch set 7 CR +2 V +2 12/15/25, 14:25
-
Benni Mack voted on patch set 7 CR 0 V 0 12/15/25, 14:25
-
Simon Schaufelberger uploaded patch set 8
CR +1V +102/12/26, 21:26 -
core-ci voted on patch set 8 V +1 02/12/26, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95782
-
Benni Mack abandoned the change 04/21/26, 14:49
abandoning... has been fixed in the meantime
pages.php:71