Review main Merged

91348[BUGFIX] Improve module body scroll performance and reduce CPU spikes

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 11/11/25, 08:57

Commit message

This is basically the same fix as applied in #97144 for v10 and
in #93489 for v11 (and v12) some years ago.
The performance degraded in v13 due to our module refactoring
in #106381, as we moved the module overflow from `.module` to
`.module-body`.

The performance is not as bad as back in 2022, because
https://issues.chromium.org/issues/40369316 has been resolved
in the meantime (scrolling layers are automatically promoted to
a compositing layer now), but the chromes bugfix still requires a
composition between the transparent `.module-body` background and the
colored `.module` background. By applying an opaque background to the
scrolling element, we can ensure that the browser does not need to
compose against the background elements, which means it "only" has to
shift graphical buffers, without reapplying alpha-compositing (which
is faster than an entire rerender, but still not as fast as shifting
buffers).

Please see commit message of #97144 for more information on the
technical background.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 79

  1. Benjamin Franzke uploaded patch set 1 10/29/25, 20:02

  2. core-ci voted on patch set 1 V +1 10/29/25, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88042

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 10/29/25, 21:06

    On my 120hz macbook pro I believe this affects performance notably, unless I am baited by a placebo effect :)
  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 11/11/25, 08:00

    Resolve Merge-Conflict
  5. Benjamin Kott voted on patch set 2 CR +1 V +1 11/11/25, 08:03

  6. core-ci voted on patch set 2 V +1 11/11/25, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88947

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 11/11/25, 08:54

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 11/11/25, 08:56

  9. Benjamin Franzke merged patch set 3 11/11/25, 08:57