Review main Merged

91349[TASK] Consolidate EXT:lowlevel labels

Lina Wolf CR +2 V +2 Hard +162 −126 updated 11/19/25, 19:30

Commit message

The record statistics submodule was moved to EXT:reports,
so the labels are now moved there, too.

Labels defined in EXT:core, which are only used in EXT:lowlevel,
are now moved into the scope of EXT:lowlevel.

Unused labels are deprecated, and adjusted labels utilize the
new domain syntax.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 3549

Show 1624 earlier messages
  1. Lina Wolf uploaded patch set 1 10/29/25, 20:10

  2. core-ci voted on patch set 1 V +1 10/29/25, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88043

  3. Lina Wolf uploaded patch set 2 V +1 10/30/25, 11:30

  4. core-ci voted on patch set 2 V +1 10/30/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88121

  5. Maike Kiebele voted on patch set 2 CR +1 V +1 10/30/25, 12:43

  6. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 11/10/25, 14:31

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 11/10/25, 14:34

  8. core-ci voted on patch set 3 V +1 11/10/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88857

  9. Benni Mack commented on patch set 3 CR -1 11/10/25, 14:47

    messages.xlf:82

    we should add the "renamed xlfs"

    messages.xlf:3

    original is wrong here.

    RecordStatistics.html:13

    I think we should use domain property here nowadays?
  10. Benni Mack commented on patch set 3 11/10/25, 14:47

    messages.xlf:82 Reply

    Done
  11. Lina Wolf uploaded patch set 4 CR +1 V +1 11/11/25, 03:47

  12. Lina Wolf commented on patch set 4 11/11/25, 03:49

    messages.xlf:3 Reply

    Done

    RecordStatistics.html:13 Reply

    I think both notations are equivalent but if we prefere two parameters to one in the core I am ok with that.
  13. core-ci voted on patch set 4 V +1 11/11/25, 03:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88933

  14. Garvin Hicking commented on patch set 4 11/11/25, 22:55

    Modules.php:17

    this will be changed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/91550 so we could adjust to this then here
  15. Lina Wolf uploaded patch set 5 V +1 11/14/25, 15:27

  16. core-ci voted on patch set 5 V -1 11/14/25, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89696

  17. Lina Wolf commented on patch set 5 11/15/25, 05:30

    Modules.php:17 Reply

    Acknowledged

    RecordStatistics.html:13 Reply

    Done
  18. Lina Wolf uploaded patch set 6 V -1 11/15/25, 05:33

  19. core-ci voted on patch set 6 V +1 11/15/25, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89768

  20. Lina Wolf uploaded patch set 7 V +1 11/16/25, 05:42

  21. core-ci voted on patch set 7 V -1 11/16/25, 05:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89844

  22. Lina Wolf uploaded patch set 8 V -1 11/19/25, 05:53

  23. core-ci voted on patch set 8 V +1 11/19/25, 06:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90096

  24. Benni Mack commented on patch set 8 11/19/25, 06:07

    ConfigurationController.php:39

    I don't think we need a constant for 1 usage?
  1. Lina Wolf commented on patch set 8 11/19/25, 06:09

    ConfigurationController.php:39 Reply

    My idea was to have it the same like in the DataBase Integrity controller
  2. Lina Wolf commented on patch set 8 11/19/25, 06:11

    ConfigurationController.php:39 Reply

    You can then use functionalites of phpstorm to find all usages without having to do a text-search
  3. Lina Wolf uploaded patch set 9 V +1 11/19/25, 09:05

  4. Lina Wolf commented on patch set 9 11/19/25, 09:05

    ConfigurationController.php:39 Reply

    Done
  5. Maike Kiebele voted on patch set 9 CR +1 V +1 11/19/25, 09:09

  6. Garvin Hicking commented on patch set 9 CR -1 11/19/25, 09:12

    ConfigurationController.php:39 Reply

    I really think we should not introduce a constant for this. This is not the best practice we want to promote; the calls to the language service should IMO not be related on any other constant or so for core usage. It also "pollutes" the controller with additional pseudo-state... (It is redundancy, I agree - but this makes searching for labels actually easier in my oppinion, if we know there is no 'magic' constant resolving involved)
  7. core-ci voted on patch set 9 V +1 11/19/25, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90107

  8. Lina Wolf uploaded patch set 10 CR +1 V +1 11/19/25, 12:08

  9. Lina Wolf commented on patch set 10 11/19/25, 12:08

    ConfigurationController.php:39 Reply

    Removed them
  10. core-ci voted on patch set 10 V +1 11/19/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90131

  11. Garvin Hicking commented on patch set 10 11/19/25, 12:35

    ConfigurationController.php:39 Reply

    thanks!

    Modules.php:17

    With last weeks patch we consolidated all module definitions to use the "magic" unified syntax, without subarray. Do you think we can keep that single 'labels' string here too?
  12. Lina Wolf uploaded patch set 11 V +1 11/19/25, 12:40

  13. Lina Wolf commented on patch set 10 11/19/25, 12:41

    Modules.php:17 Reply

    Must have slipped in during merging, thanks for noting! Done
  14. core-ci voted on patch set 11 V +1 11/19/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90134

  15. Garvin Hicking commented on patch set 11 11/19/25, 13:52

    messages.xlf:1

    How about putting these labels into a file like Language/Modules/statistics.xlf to align with other backend modules? (I'm so sorry Lina that I come with stop-and-go-feedback dripping in like this. My kids are sick and I can always only catch a glimpse between caring for them.)
  16. Lina Wolf uploaded patch set 12 V +1 11/19/25, 15:30

  17. Lina Wolf commented on patch set 12 11/19/25, 15:32

    messages.xlf:1 Reply

    Done
  18. Lina Wolf uploaded patch set 13 11/19/25, 15:34

  19. core-ci voted on patch set 12 V +1 11/19/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90160

  20. core-ci voted on patch set 13 V +1 11/19/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90162

  21. Lina Wolf uploaded patch set 14 V +1 11/19/25, 16:02

  22. core-ci voted on patch set 14 V +1 11/19/25, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90171

  23. Garvin Hicking voted on patch set 14 CR +1 V +1 11/19/25, 17:55

  24. Georg Ringer voted on patch set 14 CR +2 V +2 11/19/25, 19:30

  25. Georg Ringer merged patch set 15 11/19/25, 19:30