91349[TASK] Consolidate EXT:lowlevel labels
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+2 −1
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php7+2 −4
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+46 −45
- typo3/sysext/lowlevel/Configuration/Services.yaml+20 −20
- typo3/sysext/lowlevel/Resources/Private/Language/Modules/database_integrity.xlf+3 −3
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+34 −34
- typo3/sysext/lowlevel/Resources/Private/Templates/Configuration.fluid.html+2 −2
- typo3/sysext/lowlevel/Resources/Private/Templates/CustomSearch.fluid.html+7 −7
- typo3/sysext/reports/Resources/Private/Language/Modules/statistics.xlf+36 −0
- typo3/sysext/reports/Resources/Private/Templates/RecordStatistics.fluid.html+10 −10
Review log 3549
Show 1624 earlier messages
-
Lina Wolf uploaded patch set 1 10/29/25, 20:10
-
core-ci voted on patch set 1 V +1 10/29/25, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88043
-
Lina Wolf uploaded patch set 2
V +110/30/25, 11:30 -
core-ci voted on patch set 2 V +1 10/30/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88121
-
Maike Kiebele voted on patch set 2 CR +1 V +1 10/30/25, 12:43
-
Garvin Hicking updated the commit message in patch set 3
CR +1V +111/10/25, 14:31 -
Garvin Hicking voted on patch set 3 CR +1 V +1 11/10/25, 14:34
-
core-ci voted on patch set 3 V +1 11/10/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88857
-
Benni Mack commented on patch set 3 CR -1 11/10/25, 14:47
messages.xlf:3original is wrong here.RecordStatistics.html:13I think we should use domain property here nowadays? -
Benni Mack commented on patch set 3 11/10/25, 14:47
messages.xlf:82ReplyDone -
Lina Wolf uploaded patch set 4
CR +1V +111/11/25, 03:47 -
Lina Wolf commented on patch set 4 11/11/25, 03:49
messages.xlf:3ReplyDoneRecordStatistics.html:13ReplyI think both notations are equivalent but if we prefere two parameters to one in the core I am ok with that. -
core-ci voted on patch set 4 V +1 11/11/25, 03:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88933
-
Garvin Hicking commented on patch set 4 11/11/25, 22:55
Modules.php:17this will be changed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/91550 so we could adjust to this then here -
Lina Wolf uploaded patch set 5
V +111/14/25, 15:27 -
core-ci voted on patch set 5 V -1 11/14/25, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89696
-
Lina Wolf commented on patch set 5 11/15/25, 05:30
Modules.php:17ReplyAcknowledgedRecordStatistics.html:13ReplyDone -
Lina Wolf uploaded patch set 6
V -111/15/25, 05:33 -
core-ci voted on patch set 6 V +1 11/15/25, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89768
-
Lina Wolf uploaded patch set 7
V +111/16/25, 05:42 -
core-ci voted on patch set 7 V -1 11/16/25, 05:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89844
-
Lina Wolf uploaded patch set 8
V -111/19/25, 05:53 -
core-ci voted on patch set 8 V +1 11/19/25, 06:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90096
-
Benni Mack commented on patch set 8 11/19/25, 06:07
ConfigurationController.php:39I don't think we need a constant for 1 usage?
-
Lina Wolf commented on patch set 8 11/19/25, 06:09
ConfigurationController.php:39ReplyMy idea was to have it the same like in the DataBase Integrity controller -
Lina Wolf commented on patch set 8 11/19/25, 06:11
ConfigurationController.php:39ReplyYou can then use functionalites of phpstorm to find all usages without having to do a text-search -
Lina Wolf uploaded patch set 9
V +111/19/25, 09:05 -
Lina Wolf commented on patch set 9 11/19/25, 09:05
ConfigurationController.php:39ReplyDone -
Maike Kiebele voted on patch set 9 CR +1 V +1 11/19/25, 09:09
-
Garvin Hicking commented on patch set 9 CR -1 11/19/25, 09:12
ConfigurationController.php:39ReplyI really think we should not introduce a constant for this. This is not the best practice we want to promote; the calls to the language service should IMO not be related on any other constant or so for core usage. It also "pollutes" the controller with additional pseudo-state... (It is redundancy, I agree - but this makes searching for labels actually easier in my oppinion, if we know there is no 'magic' constant resolving involved) -
core-ci voted on patch set 9 V +1 11/19/25, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90107
-
Lina Wolf uploaded patch set 10
CR +1V +111/19/25, 12:08 -
Lina Wolf commented on patch set 10 11/19/25, 12:08
ConfigurationController.php:39ReplyRemoved them -
core-ci voted on patch set 10 V +1 11/19/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90131
-
Garvin Hicking commented on patch set 10 11/19/25, 12:35
ConfigurationController.php:39Replythanks!Modules.php:17With last weeks patch we consolidated all module definitions to use the "magic" unified syntax, without subarray. Do you think we can keep that single 'labels' string here too? -
Lina Wolf uploaded patch set 11
V +111/19/25, 12:40 -
Lina Wolf commented on patch set 10 11/19/25, 12:41
Modules.php:17ReplyMust have slipped in during merging, thanks for noting! Done -
core-ci voted on patch set 11 V +1 11/19/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90134
-
Garvin Hicking commented on patch set 11 11/19/25, 13:52
messages.xlf:1How about putting these labels into a file like Language/Modules/statistics.xlf to align with other backend modules? (I'm so sorry Lina that I come with stop-and-go-feedback dripping in like this. My kids are sick and I can always only catch a glimpse between caring for them.) -
Lina Wolf uploaded patch set 12
V +111/19/25, 15:30 -
Lina Wolf commented on patch set 12 11/19/25, 15:32
messages.xlf:1ReplyDone -
Lina Wolf uploaded patch set 13 11/19/25, 15:34
-
core-ci voted on patch set 12 V +1 11/19/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90160
-
core-ci voted on patch set 13 V +1 11/19/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90162
-
Lina Wolf uploaded patch set 14
V +111/19/25, 16:02 -
core-ci voted on patch set 14 V +1 11/19/25, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90171
-
Garvin Hicking voted on patch set 14 CR +1 V +1 11/19/25, 17:55
-
Georg Ringer voted on patch set 14 CR +2 V +2 11/19/25, 19:30
-
Georg Ringer merged patch set 15 11/19/25, 19:30
messages.xlf:82