91356[!!!][TASK] Utilize translation domain in all pages related showitem
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Maike Kiebele +1
-
Verified V +2 Done
- Benni Mack +2
- Maike Kiebele +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html2+1 −1
- typo3/sysext/core/Classes/Configuration/Tca/TcaEnrichment.php+1 −1
- typo3/sysext/core/Configuration/TCA/pages.php2+59 −59
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107789-CoreTCATabLabelsUseShortFormReferences.rst2+70 −0
- typo3/sysext/core/Resources/Private/Language/db/general.xlf2+22 −17
- typo3/sysext/core/Resources/Private/Language/db/pages.xlf2new+185 −0
- typo3/sysext/core/Resources/Private/Language/locallang_general.xlf+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaEnrichmentTest.php+1 −1
Review log 1827
Show 12 earlier messages
-
Riccardo De Contardi uploaded patch set 1 10/30/25, 09:25
-
core-ci voted on patch set 1 V +1 10/30/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88096
-
Riccardo De Contardi uploaded patch set 2
V +110/30/25, 09:39 -
core-ci voted on patch set 2 V +1 10/30/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88098
-
Maike Kiebele commented on patch set 2 CR +1 V +1 10/30/25, 10:33
Looks good to me 😊 -
Lina Wolf commented on patch set 2 CR +1 10/30/25, 10:57
Code looks good, didnt test -
Benni Mack commented on patch set 2 10/30/25, 11:08
NewPages.html:212I think we should utilize this properly now if we use the short syntax on ViewHelpers: <f:translate key="doktype" domain="core.db.pages" />pages.php:883didn't we want to centralize these and use the core.db.general domain?Breaking-107789-CoreTCATabLabelsUseShortFormReferences.rst:160there is a superfluous space at the end of the filegeneral.xlf:8the rest of the file is using tabs, let's be consistent here.pages.xlf:143there is a trailing space here -
Riccardo De Contardi commented on patch set 3
CR +1V +110/30/25, 11:17Published edit on patch set 2. -
Riccardo De Contardi commented on patch set 4 10/30/25, 11:19
Published edit on patch set 3. -
Riccardo De Contardi commented on patch set 5 10/30/25, 11:21
Published edit on patch set 4. -
Riccardo De Contardi commented on patch set 6 10/30/25, 11:24
Published edit on patch set 5. -
core-ci voted on patch set 3 V +1 10/30/25, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88115
-
core-ci voted on patch set 4 V +1 10/30/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88116
-
core-ci voted on patch set 6 V +1 10/30/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88118
-
core-ci voted on patch set 5 V +1 10/30/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88117
-
Riccardo De Contardi commented on patch set 7
V +110/30/25, 11:40Published edit on patch set 6. -
Riccardo De Contardi commented on patch set 8 10/30/25, 11:41
Published edit on patch set 7. -
Riccardo De Contardi commented on patch set 8 10/30/25, 11:42
I think I covered up everything. txNewPages.html:212Replydonepages.php:883ReplyDoneBreaking-107789-CoreTCATabLabelsUseShortFormReferences.rst:160ReplyDonegeneral.xlf:8ReplyDonepages.xlf:143ReplyDone -
core-ci voted on patch set 7 V +1 10/30/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88127
-
core-ci voted on patch set 8 V +1 10/30/25, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88130
-
Benni Mack commented on patch set 8 CR -1 10/30/25, 13:20
On it. -
Benni Mack uploaded patch set 9
CR -1V +110/30/25, 15:29 -
Benni Mack voted on patch set 9 CR +1 V +1 10/30/25, 15:31
-
Maike Kiebele voted on patch set 9 CR +1 V +1 10/30/25, 15:33
-
core-ci voted on patch set 9 V +1 10/30/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88161
-
Benni Mack voted on patch set 9 CR +2 V +2 10/30/25, 15:41
-
Benni Mack merged patch set 10 10/30/25, 15:41