Review main Merged Breaking

91356[!!!][TASK] Utilize translation domain in all pages related showitem

Riccardo De Contardi CR +2 V +2 Hard +340 −80 updated 10/30/25, 15:41

Commit message

Due to historical reasons (~8-10 years ago), new labels were
added for pages in v7/v8. At this point,
there was no plan on how to deal with XLF / label files
and how to move / change and deprecate this.

So, in order to avoid breaking changes, new labels
were added and the labels were added to the FormEngine
list, instead of the actual field definition.

Nowadays, this can now be consolidated, and used
a) for all TCA tables - these files are put into core.db.general
b) existing fields in pages get new labels in their "label"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Maike Kiebele +1
  • Verified V +2 Done
    • Benni Mack +2
    • Maike Kiebele +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1827

Show 12 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 10/30/25, 09:25

  2. core-ci voted on patch set 1 V +1 10/30/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88096

  1. Riccardo De Contardi uploaded patch set 2 V +1 10/30/25, 09:39

  2. core-ci voted on patch set 2 V +1 10/30/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88098

  3. Maike Kiebele commented on patch set 2 CR +1 V +1 10/30/25, 10:33

    Looks good to me 😊
  4. Lina Wolf commented on patch set 2 CR +1 10/30/25, 10:57

    Code looks good, didnt test
  5. Benni Mack commented on patch set 2 10/30/25, 11:08

    NewPages.html:212

    I think we should utilize this properly now if we use the short syntax on ViewHelpers: <f:translate key="doktype" domain="core.db.pages" />

    pages.php:883

    didn't we want to centralize these and use the core.db.general domain?

    Breaking-107789-CoreTCATabLabelsUseShortFormReferences.rst:160

    there is a superfluous space at the end of the file

    general.xlf:8

    the rest of the file is using tabs, let's be consistent here.

    pages.xlf:143

    there is a trailing space here
  6. Riccardo De Contardi commented on patch set 3 CR +1 V +1 10/30/25, 11:17

    Published edit on patch set 2.
  7. Riccardo De Contardi commented on patch set 4 10/30/25, 11:19

    Published edit on patch set 3.
  8. Riccardo De Contardi commented on patch set 5 10/30/25, 11:21

    Published edit on patch set 4.
  9. Riccardo De Contardi commented on patch set 6 10/30/25, 11:24

    Published edit on patch set 5.
  10. core-ci voted on patch set 3 V +1 10/30/25, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88115

  11. core-ci voted on patch set 4 V +1 10/30/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88116

  12. core-ci voted on patch set 6 V +1 10/30/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88118

  13. core-ci voted on patch set 5 V +1 10/30/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88117

  14. Riccardo De Contardi commented on patch set 7 V +1 10/30/25, 11:40

    Published edit on patch set 6.
  15. Riccardo De Contardi commented on patch set 8 10/30/25, 11:41

    Published edit on patch set 7.
  16. Riccardo De Contardi commented on patch set 8 10/30/25, 11:42

    I think I covered up everything. tx

    NewPages.html:212 Reply

    done

    pages.php:883 Reply

    Done

    Breaking-107789-CoreTCATabLabelsUseShortFormReferences.rst:160 Reply

    Done

    general.xlf:8 Reply

    Done

    pages.xlf:143 Reply

    Done
  17. core-ci voted on patch set 7 V +1 10/30/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88127

  18. core-ci voted on patch set 8 V +1 10/30/25, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88130

  19. Benni Mack commented on patch set 8 CR -1 10/30/25, 13:20

    On it.
  20. Benni Mack uploaded patch set 9 CR -1 V +1 10/30/25, 15:29

  21. Benni Mack voted on patch set 9 CR +1 V +1 10/30/25, 15:31

  22. Maike Kiebele voted on patch set 9 CR +1 V +1 10/30/25, 15:33

  23. core-ci voted on patch set 9 V +1 10/30/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88161

  24. Benni Mack voted on patch set 9 CR +2 V +2 10/30/25, 15:41

  25. Benni Mack merged patch set 10 10/30/25, 15:41