Review main Merged

91359[TASK] Merge backend modules "Setup" and "Settings"

Benni Mack CR +2 V +2 Expert +1510 −465 updated 11/23/25, 20:42

Commit message

A new "Tiles" view option has been added to the overview of the
"Sites" >"Setup" backend module. This new view provides users with a
quick overview of the sites in the installation. More detailed
information about a site, such as the settings configured in the site
configuration and active site settings, can be viewed in a newly
introduced detail view.

Sites without a site configuration are now displayed in a separate
section, similar to the unassigned site configurations.

Finally, a small information section has been added to the overview,
indicating how many sites are in the installation, how many of them
lack a site configuration, and the number of unassigned site
configurations.

Furthermore, the overview page of the backend module
"Sites" > "Settings" was removed and the existing additional views
of that module were moved to the module "Sites" > "Setup".

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 86135

Show 66110 earlier messages
  1. Benni Mack uploaded patch set 1 10/30/25, 10:47

  2. core-ci voted on patch set 1 V +1 10/30/25, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88109

  3. Jasmina Ließmann uploaded patch set 2 V +1 11/04/25, 09:05

  4. core-ci voted on patch set 2 V -1 11/04/25, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88442

  5. Jasmina Ließmann uploaded patch set 3 V -1 11/04/25, 11:54

  6. core-ci voted on patch set 3 V -1 11/04/25, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88459

  7. Benjamin Franzke commented on patch set 3 11/04/25, 13:58

    No, they can be merged.
  8. Jasmina Ließmann uploaded patch set 4 V -1 11/05/25, 14:15

  9. core-ci voted on patch set 4 V -1 11/05/25, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88522

  10. Jasmina Ließmann uploaded patch set 5 V -1 11/11/25, 16:41

  11. core-ci voted on patch set 5 V -1 11/11/25, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89039

  12. Jasmina Ließmann uploaded patch set 6 V -1 11/14/25, 16:32

  13. Jasmina Ließmann uploaded patch set 7 11/14/25, 16:33

  14. Jasmina Ließmann uploaded patch set 8 11/14/25, 16:34

  15. core-ci voted on patch set 6 V -1 11/14/25, 16:41 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89698

  16. core-ci voted on patch set 7 V -1 11/14/25, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89699

  17. core-ci voted on patch set 8 V -1 11/14/25, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89700

  18. Jasmina Ließmann uploaded patch set 9 V -1 11/18/25, 12:09

  19. Jasmina Ließmann commented on patch set 9 11/18/25, 12:09

    Reply

    Acknowledged
  20. core-ci voted on patch set 9 V -1 11/18/25, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90019

  21. Jasmina Ließmann uploaded patch set 10 V -1 11/18/25, 15:40

  22. Jasmina Ließmann uploaded patch set 11 11/18/25, 15:40

  23. core-ci voted on patch set 10 V -1 11/18/25, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90047

  24. core-ci voted on patch set 11 V -1 11/18/25, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90048

  25. Jasmina Ließmann uploaded patch set 12 V -1 11/19/25, 11:19

  26. core-ci voted on patch set 12 V +1 11/19/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90126

  27. Jasmina Ließmann uploaded patch set 13 V +1 11/19/25, 13:30

  28. core-ci voted on patch set 13 V +1 11/19/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90138

  29. Jasmina Ließmann uploaded patch set 14 V +1 11/19/25, 15:07

  30. Jasmina Ließmann uploaded patch set 15 11/19/25, 15:34

  31. core-ci voted on patch set 14 V +1 11/19/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90157

  32. Jasmina Ließmann uploaded patch set 16 11/19/25, 15:41

  33. core-ci voted on patch set 15 V +1 11/19/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90161

  34. core-ci voted on patch set 16 V +1 11/19/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90168

  35. Jasmina Ließmann uploaded patch set 17 V +1 11/19/25, 16:04

  36. core-ci voted on patch set 17 V +1 11/19/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90172

  37. Jasmina Ließmann uploaded patch set 18 V +1 11/19/25, 17:02

  38. core-ci voted on patch set 18 V +1 11/19/25, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90179

  39. Jasmina Ließmann rebased onto patch set 19 V +1 11/20/25, 10:34

  40. core-ci voted on patch set 19 V +1 11/20/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90259

  41. Jasmina Ließmann uploaded patch set 20 V +1 11/20/25, 14:02

  42. core-ci voted on patch set 20 V +1 11/20/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90294

  43. Jasmina Ließmann uploaded patch set 21 V +1 11/20/25, 14:34

  44. core-ci voted on patch set 21 V -1 11/20/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90296

  45. Jasmina Ließmann uploaded patch set 22 V -1 11/20/25, 16:29

  46. Jasmina Ließmann uploaded patch set 23 11/20/25, 16:32

  47. core-ci voted on patch set 22 V -1 11/20/25, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90317

  48. core-ci voted on patch set 23 V +1 11/20/25, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90318

  49. Jasmina Ließmann uploaded patch set 24 V +1 11/21/25, 01:10

  50. core-ci voted on patch set 24 V +1 11/21/25, 01:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90427

  51. Oli Bartsch commented on patch set 24 11/21/25, 09:45

    Really cool improvement! While this is still WIP I just want to take the chance to already give some feedback: 1. I would like to have the info boxes like "Unassigned site configurations" below the listing. Actually I seem to have ~20 unassigned sites and this leads to I almost don't see the listing without scrolling 2. A tooltip for the "and X more" would be helpfull to have the possibility again to see all langauges in the listing directly again. 3. Maybe I'm dumb but I don't find it obvious where to edit the site settings now. I acutally had a hard time to find the button in the detail view. Could we please add it back to edit view and maybe also directly into the listing?
  52. Jasmina Ließmann uploaded patch set 25 V +1 11/21/25, 12:55

  53. core-ci voted on patch set 25 V +1 11/21/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90501

  54. Jasmina Ließmann uploaded patch set 26 V +1 11/21/25, 13:44

  55. core-ci voted on patch set 26 V -1 11/21/25, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90526

  56. Jasmina Ließmann uploaded patch set 27 V -1 11/21/25, 15:40

  57. core-ci voted on patch set 27 V -1 11/21/25, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90538

  58. Jasmina Ließmann uploaded patch set 28 V -1 11/21/25, 16:23

  59. core-ci voted on patch set 28 V +1 11/21/25, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90549

  60. Jasmina Ließmann updated the commit message in patch set 29 V +1 11/21/25, 16:59

  61. Jasmina Ließmann updated the commit message in patch set 30 11/21/25, 17:01

  62. core-ci voted on patch set 29 V +1 11/21/25, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90554

  63. core-ci voted on patch set 30 V +1 11/21/25, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90555

  64. Oli Bartsch uploaded patch set 31 V +1 11/22/25, 09:44

  65. core-ci voted on patch set 31 V -1 11/22/25, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90625

  66. Jasmina Ließmann rebased onto patch set 32 V -1 11/22/25, 15:44

  67. core-ci voted on patch set 32 V -1 11/22/25, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90654

  68. Jasmina Ließmann uploaded patch set 33 V -1 11/22/25, 16:48

  69. core-ci voted on patch set 33 V -1 11/22/25, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90666

  70. Andreas Kienast commented on patch set 33 11/22/25, 17:00

    Feedback from having a very quick look at it: I like it! One minor thing that bugs me: when I'm in the detail view, the button order at the top is "Edit site configuration", then "Edit site settings". In the site overview, the edit buttons at the bottom of the tiles are switched.
  71. Jasmina Ließmann commented on patch set 33 11/22/25, 17:17

    Reply

    Thank you for your feedback; it's helpful at every stage of the patch. Regarding point 1: I understand your point and have moved the content of the info boxes back down. Perhaps sometime, we could consider moving these informations ("Pages without site configuration" and "Unassigned site configurations") to an own submodule entry. Otherwise, this information could get lost at the bottom of the overview page in installations with a large number of sites. Regarding point 2: I've decided against adding a tooltip. The tile view is intended to only display a brief overview of the most important informations of a site. If a site has 15+ languages, this could quickly become cluttered in a tooltip. Driven by further feedback, I've implemented a view switch that now offers both the new tile view and the familiar list view. The list view displays the language information as usual. Users can now choose which view they prefer. I hope this is ok for you? Regarding point 3: I have reinstated the cross-references in both EditActions. This allows direct switching between the two actions again. Otherwise, I added the button "View details" to the list view, so the same buttons ("View details", "Edit site settings", "Edit site configuration", and "Delete") are now present in both list and tile views. In the DetailAction, you can jump to either EditAction from the DocHeader.
  72. Jasmina Ließmann uploaded patch set 34 V -1 11/22/25, 17:25

  73. Jasmina Ließmann uploaded patch set 35 11/22/25, 17:28

  74. Jasmina Ließmann commented on patch set 35 11/22/25, 17:34

    Reply

    Understood. I wanted to group the actions of the site configuration (Edit, Delete), so I swapped the positions of "Edit site settings" and "Edit site configuration" in list and tile views. I've now restored the original button order in the list view and applied it to the tile view as well.
  75. core-ci voted on patch set 34 V +1 11/22/25, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90671

  76. core-ci voted on patch set 35 V +1 11/22/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90672

  77. Jasmina Ließmann updated the commit message in patch set 36 V +1 11/22/25, 17:44

  78. core-ci voted on patch set 36 V +1 11/22/25, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90674

  79. Jasmina Ließmann uploaded patch set 37 V +1 11/22/25, 18:31

  80. core-ci voted on patch set 37 V +1 11/22/25, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90679

  81. Jasmina Ließmann updated the commit message in patch set 38 V +1 11/22/25, 19:14

  82. Jasmina Ließmann updated the commit message in patch set 39 11/22/25, 19:16

  83. Jasmina Ließmann uploaded patch set 40 11/22/25, 19:23

  84. core-ci voted on patch set 38 V +1 11/22/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90683

  85. Jasmina Ließmann commented on patch set 40 11/22/25, 19:23

    Reply

    Done
  86. core-ci voted on patch set 39 V +1 11/22/25, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90684

  87. core-ci voted on patch set 40 V +1 11/22/25, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90685

  88. Oli Bartsch commented on patch set 40 11/22/25, 21:23

    Great work, will review soon (tomorrow) in detail.

    SiteConfigurationController.php:169

    this looks risky.

    SiteConfigurationController.php:966

    I dont quite get this method. It actually does not do what the PHPdoc says. Just from reading, it returns a single record with the 'uid' <=> $pageUid?
  89. Jasmina Ließmann commented on patch set 40 11/22/25, 22:09

    SiteConfigurationController.php:966 Reply

    I need the page title for the h1 in the detail action. It's a modified copy of the function getAllSitePages() above this new function. I forgot to change the PHPdoc.
  90. Georg Ringer commented on patch set 40 11/23/25, 06:55

    really like the current approach

    Overview.fluid.html:19

    guess we should use the new label identifiers there and below
  91. Lina Wolf commented on patch set 40 CR -1 11/23/25, 07:33

    Working on the fluid templates, georg has a point there
  92. Lina Wolf uploaded patch set 41 CR -1 V +1 11/23/25, 08:01

  93. Lina Wolf commented on patch set 41 11/23/25, 08:02

    Overview.fluid.html:19 Reply

    Done
  94. Lina Wolf commented on patch set 41 11/23/25, 08:05

    I like this approach, however I think invalid sets should be marked more clear in overview like thy have been before this change in both the Sites and Settings modules
  95. core-ci voted on patch set 41 V +1 11/23/25, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90730

  96. Oli Bartsch commented on patch set 41 11/23/25, 10:45

    SiteConfigurationController.php:966 Reply

    So, we could just use BackendUtility::getRecord()?
  97. Jasmina Ließmann uploaded patch set 42 V +1 11/23/25, 14:26

  98. Jasmina Ließmann commented on patch set 41 11/23/25, 14:27

    SiteConfigurationController.php:966 Reply

    Thank you, I've modified it accordingly.
  99. core-ci voted on patch set 42 V +1 11/23/25, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90749

  100. Jasmina Ließmann commented on patch set 42 11/23/25, 14:35

    Reply

    I made a note of it and would tackle this again in a separate patch. I hope that's okay with you? In fact, there is already an infobox / variable `{invalidSets}`, which should display incorrect sets below the table / tiles. Unfortunately I haven't been able to get this to work yet.

    Overview.fluid.html:19 Reply

    Thank you so much for adapting it. I'm not yet very familiar with the new notation and couldn't get it to work.
  101. Christian Kuhn commented on patch set 42 CR -1 11/23/25, 14:49

    on it.

    ViewMode.php:23

    its good this is internal, and i think it would be good to additionally rename to 'SetupModuleViewMode' or similar to not elevate this enum to a generic one too much at this point: filelist has a similar ones for its module but that's a different extension. we need it once now, so lets give it a more restricted naming, at least for now.
  102. Christian Kuhn commented on patch set 42 11/23/25, 15:04

    Reply

    1. agree. bottom position of this list is good for now. and there is now this 'overview' line on top 'you have x sites and y without config'. this summary is very useful in this regard. 2. tooltips can easily become massive in this case, plus they tend to add mobile and accessibility issues. i like the card overview. i only wish they'd auto-scale in number to have 3 or more next to each other when there is room. that's why we use wide screens. this can of course be sorted out with another patch if desired, since this patch is mostly about merging the two main modules, so we may want to skip discussion about too many details.

    SiteConfigurationController.php:169 Reply

    Done

    ViewMode.php:23 Reply

    Done
  103. Jasmina Ließmann uploaded patch set 43 CR -1 V +1 11/23/25, 15:05

  104. core-ci voted on patch set 43 V +1 11/23/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90751

  105. Jasmina Ließmann commented on patch set 43 11/23/25, 15:14

    Reply

    Based on your feedback, I have removed the exclamation mark icon and now display the same "Invalid Sets" alert as in the list view.
  106. Christian Kuhn uploaded patch set 44 V +1 11/23/25, 15:16

  107. Christian Kuhn commented on patch set 43 11/23/25, 15:17

    ViewMode.php:23 Reply

    i also moved the 'simple/advanced' mode selector of site settings to this namespace, which was mislocated in ext:core.
  108. Christian Kuhn uploaded patch set 45 11/23/25, 15:18

  109. Christian Kuhn voted on patch set 45 CR -1 11/23/25, 15:19

  110. core-ci voted on patch set 44 V +1 11/23/25, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90755

  1. core-ci voted on patch set 45 V +1 11/23/25, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90756

  2. Christian Kuhn uploaded patch set 46 CR -1 V +1 11/23/25, 16:00

  3. Christian Kuhn voted on patch set 46 CR +1 V +1 11/23/25, 16:00

  4. Christian Kuhn uploaded patch set 47 CR +1 V +1 11/23/25, 16:05

  5. Christian Kuhn voted on patch set 47 CR +1 V +1 11/23/25, 16:05

  6. Georg Ringer voted on patch set 47 CR +1 V +1 11/23/25, 16:09

  7. core-ci voted on patch set 46 V +1 11/23/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90758

  8. core-ci voted on patch set 47 V +1 11/23/25, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90760

  9. Oli Bartsch commented on patch set 47 11/23/25, 17:23

    Reply

    reviewing now
  10. Oli Bartsch uploaded patch set 48 CR +1 V +1 11/23/25, 18:29

  11. Oli Bartsch commented on patch set 47 11/23/25, 18:29

    SiteConfigurationController.php:224

    This results in a TypeError for creating new sites ("Add new site configuration for site") for existing pages.

    SiteSettingsController.php:85

    Let's properly utilize ModuleData API here.

    locallang_siteconfiguration_module.xlf:16

    I think this is unused and also in a deprecated file.

    Detail.fluid.html:24

    I'm still not in this whole grid rewrite discussion, but I suggest to avoid those classes here if possible. I don't like this patch to be block for such reason.

    Overview.fluid.html:17

    Should we add this to a infobox component? It looks uncommon to have a "intro text" in a module with important information just as normal text.

    Overview.fluid.html:18

    This should be checked again, as it for me leads to some hard to understand messages. In my example: three root pages, no site config for them. Only sone site config, which however is not assigned to any page. This now leads to: >The installation includes 1 site(s). Of these, 3 site(s) are lacking a site configuration. >There are currently 1 site configuration(s) that are not assigned to any page. Reason: "allSites" contains the not assigned site, and the the three root pages have no site. And the unassigned site is then mentioned again in the second sentence.

    Overview.fluid.html:95

    This is wrong here. I have three root pages, but did not yet adda site config for any of them. Therefore, those three pages are listed below the "Pages without site configuration" allowing me to create site configs. But this info box anyways is displayed and reads: "No Root Pages Available Please create at least one root page in the Page module. A root page must be a content page at the top level (not a folder or separator) or have the "Root Page" flag enabled (Page Properties → Behavior tab)." Especially with the intro text saying: >The installation includes 1 site(s). Of these, 3 site(s) are lacking a site configuration. > There are currently 1 site configuration(s) that are not assigned to any page. In this example.

    locallang_info.xlf:46

    Sites » Setup

    locallang_info.xlf:52

    Sites » Setup
  12. Oli Bartsch commented on patch set 48 11/23/25, 18:30

    SiteConfigurationController.php:224 Reply

    Done

    SiteSettingsController.php:85 Reply

    Done

    locallang_siteconfiguration_module.xlf:16 Reply

    Done

    locallang_info.xlf:46 Reply

    Done

    locallang_info.xlf:52 Reply

    Done
  13. Oli Bartsch commented on patch set 48 11/23/25, 18:35

    Reply

    Works really good! I've adjusted the flow in the controllers a bit, and fixed some TypeErrors. Please just check the comments in the templates regarding those grid classes and some "wrong" messages.
  14. core-ci voted on patch set 48 V +1 11/23/25, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90765

  15. Jasmina Ließmann commented on patch set 48 11/23/25, 18:46

    Detail.fluid.html:24 Reply

    I understand your point. This structure is already used in "(Backend) User > Detail". For consistency reasons, I would keep it as is for now and then address both occurrences in a separate patch.

    Overview.fluid.html:17 Reply

    I had already received feedback that an infobox was inappropriate in this location and that the information would be better presented as introductory text. Therefore, I changed the infobox to introductory text.
  16. Oli Bartsch commented on patch set 48 11/23/25, 18:53

    Overview.fluid.html:17 Reply

    Where can I find this feedback? I don't get waht would be inappropriate about having an infobox at the top of the module. Every other backend module is handling information this way.
  17. Jasmina Ließmann uploaded patch set 49 V +1 11/23/25, 19:58

  18. Jasmina Ließmann commented on patch set 49 11/23/25, 20:01

    Reply

    Done

    Reply

    Acknowledged

    Overview.fluid.html:17 Reply

    I got the feedback via Slack. I now changed it back to an infobox.

    Overview.fluid.html:18 Reply

    I have updated the texts and conditions in fluid accordingly.

    Overview.fluid.html:95 Reply

    See above: I have updated the fluid conditions and texts.
  19. Christian Kuhn voted on patch set 49 CR +1 V +1 11/23/25, 20:02

  20. core-ci voted on patch set 49 V +1 11/23/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90767

  21. Georg Ringer voted on patch set 49 CR +1 V +1 11/23/25, 20:39

  22. Jasmina Ließmann voted on patch set 49 CR +1 V +1 11/23/25, 20:40

  23. Jasmina Ließmann voted on patch set 49 CR +2 11/23/25, 20:42

  24. Jasmina Ließmann voted on patch set 49 V +2 11/23/25, 20:42

  25. Jasmina Ließmann merged patch set 50 11/23/25, 20:42