91367[BUGFIX] Move DatabaseIntegrityCheck from EXT:lowlevel to EXT:reports
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/14.3/Deprecation-107931-LowlevelDatabaseIntegrityCheck.rstnew+38 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php2+4 −7
- typo3/sysext/reports/Classes/Integrity/DatabaseIntegrityCheck.phpnew+214 −0
- typo3/sysext/reports/Classes/Service/RecordStatisticsService.php+8 −11
Review log 1821
-
Georg Ringer uploaded patch set 1 10/30/25, 13:34
-
Georg Ringer commented on patch set 1 10/30/25, 13:35
This change is ready for review. -
Lina Wolf commented on patch set 1 10/30/25, 13:42
I think making the DatabaseIntegrityCheck internal is a breaking change, as it has not yet been internal (even though it should be). So I would make a change log entry about this -
core-ci voted on patch set 1 V +1 10/30/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88145
-
Benni Mack commented on patch set 1 10/30/25, 15:34
Reply
let's just use a Class Alias. WDYT? -
Lina Wolf commented on patch set 1 10/30/25, 18:29
Reply
making it internal makes sense -
Benni Mack uploaded patch set 2
V +104/07/26, 12:20 -
core-ci voted on patch set 2 V +1 04/07/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99693
-
Georg Ringer voted on patch set 2 CR +1 V +1 04/07/26, 19:45
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/07/26, 21:41
-
Sven Liebert voted on patch set 2 CR +1 V +1 04/08/26, 08:21
-
Christian Kuhn voted on patch set 2 CR -1 04/08/26, 10:37
-
Christian Kuhn commented on patch set 2 04/08/26, 10:47
I agree the class could and should be moved to ext:reports and should be declared @internal along the way. It gives us the opportunity to also clean it up in v15. Let's please deprecate the old location right away.DatabaseIntegrityCheck.php:38ext:reports is the only usage of the class which is resolved with the patch. I think we should deprecate this class right away, and include the deprecation in this patch. -
Benni Mack commented on patch set 2 CR -1 04/08/26, 11:09
on it -
Benni Mack uploaded patch set 3
CR +1V +104/08/26, 11:32 -
core-ci voted on patch set 3 V +1 04/08/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99759
-
Benni Mack commented on patch set 3 04/08/26, 12:03
Reply
DoneDatabaseIntegrityCheck.php:38ReplyDone -
Christian Kuhn voted on patch set 3 CR +1 V +1 04/08/26, 12:11
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 04/08/26, 12:30
-
Benni Mack voted on patch set 3 CR +2 V +2 04/08/26, 14:13
-
Benni Mack merged patch set 4 04/08/26, 14:13