Review main Merged

91367[BUGFIX] Move DatabaseIntegrityCheck from EXT:lowlevel to EXT:reports

Georg Ringer CR +2 V +2 Hard +269 −18 updated 04/08/26, 14:13

Commit message

Remove the undesired dependency of EXT:reports' record
statistics to EXT:lowlevel by copying the
DatabaseIntegrityCheck parts to the reports module.

The old class is now marked as deprecated

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1821

  1. Georg Ringer uploaded patch set 1 10/30/25, 13:34

  2. Georg Ringer commented on patch set 1 10/30/25, 13:35

    This change is ready for review.
  3. Lina Wolf commented on patch set 1 10/30/25, 13:42

    I think making the DatabaseIntegrityCheck internal is a breaking change, as it has not yet been internal (even though it should be). So I would make a change log entry about this
  4. core-ci voted on patch set 1 V +1 10/30/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88145

  5. Benni Mack commented on patch set 1 10/30/25, 15:34

    Reply

    let's just use a Class Alias. WDYT?
  6. Lina Wolf commented on patch set 1 10/30/25, 18:29

    Reply

    making it internal makes sense
  7. Benni Mack uploaded patch set 2 V +1 04/07/26, 12:20

  8. core-ci voted on patch set 2 V +1 04/07/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99693

  9. Georg Ringer voted on patch set 2 CR +1 V +1 04/07/26, 19:45

  10. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/07/26, 21:41

  11. Sven Liebert voted on patch set 2 CR +1 V +1 04/08/26, 08:21

  12. Christian Kuhn voted on patch set 2 CR -1 04/08/26, 10:37

  13. Christian Kuhn commented on patch set 2 04/08/26, 10:47

    I agree the class could and should be moved to ext:reports and should be declared @internal along the way. It gives us the opportunity to also clean it up in v15. Let's please deprecate the old location right away.

    DatabaseIntegrityCheck.php:38

    ext:reports is the only usage of the class which is resolved with the patch. I think we should deprecate this class right away, and include the deprecation in this patch.
  14. Benni Mack commented on patch set 2 CR -1 04/08/26, 11:09

    on it
  15. Benni Mack uploaded patch set 3 CR +1 V +1 04/08/26, 11:32

  16. core-ci voted on patch set 3 V +1 04/08/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99759

  17. Benni Mack commented on patch set 3 04/08/26, 12:03

    Reply

    Done

    DatabaseIntegrityCheck.php:38 Reply

    Done
  18. Christian Kuhn voted on patch set 3 CR +1 V +1 04/08/26, 12:11

  19. Simon Schaufelberger voted on patch set 3 CR +1 V +1 04/08/26, 12:30

  20. Benni Mack voted on patch set 3 CR +2 V +2 04/08/26, 14:13

  21. Benni Mack merged patch set 4 04/08/26, 14:13