Review main Merged

91372[BUGFIX] Mount a page moved in workspaces as pagetree treeroot

Ayke Halder CR +2 V +2 Normal +52 −3 updated 10/23/26, 13:23

Commit message

Mounting a page as temporary treeroot in a workspace failed with a
TypeError when the page itself or any of its ancestors was moved in
that workspace: the mount point path was built from the live rootline
and every page was overlaid with move pointers unset, which turns a
moved page into "false".

As the mount point is persisted in the user settings, the pagetree
was permanently broken for the user afterwards.

The mount point path is now built from the workspace-overlaid
rootline, which already contains the workspace titles. This also
shows the path at the workspace location of a moved page, matching
the pagetree itself.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Ayke Halder uploaded patch set 1 10/30/25, 17:43

  2. core-ci voted on patch set 1 V +1 10/30/25, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88174

  3. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:25

  4. core-ci voted on patch set 2 V -1 04/22/26, 06:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100694

  5. Benni Mack rebased onto patch set 3 V -1 09/15/26, 05:50

  6. core-ci voted on patch set 3 V +1 09/15/26, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108573

  7. Benni Mack updated the commit message in patch set 4 V +1 09/15/26, 10:28

  8. Benni Mack voted on patch set 4 CR +1 V +1 09/15/26, 10:28

  9. core-ci voted on patch set 4 V +1 09/15/26, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108608

  10. Benni Mack uploaded patch set 5 CR +1 V +1 10/02/26, 10:09

  11. core-ci voted on patch set 5 V +1 10/02/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109901

  12. Benni Mack voted on patch set 5 CR +1 V +1 10/02/26, 10:20

  13. Benni Mack voted on patch set 5 CR +2 V +2 10/23/26, 13:23

  14. Benni Mack merged patch set 6 10/23/26, 13:23