Review main Merged

91375[TASK] Deprecate unused XLF files

Lina Wolf CR +2 V +2 Normal +80 −5 updated 11/11/25, 09:19

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1724

  1. Lina Wolf uploaded patch set 1 10/30/25, 19:12

  2. Lina Wolf marked it work in progress 10/30/25, 19:12

  3. core-ci voted on patch set 1 V +1 10/30/25, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88180

  4. Lina Wolf uploaded patch set 2 V +1 11/03/25, 14:49

  5. Lina Wolf updated the commit message in patch set 3 11/03/25, 14:50

  6. Lina Wolf uploaded patch set 4 11/03/25, 14:52

  7. Lina Wolf marked it ready for review 11/03/25, 14:52

  8. core-ci voted on patch set 2 V -1 11/03/25, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88386

  9. core-ci voted on patch set 3 V -1 11/03/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88387

  10. Lina Wolf uploaded patch set 5 11/03/25, 15:01

  11. core-ci voted on patch set 4 V -1 11/03/25, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88388

  12. core-ci voted on patch set 5 V +1 11/03/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88389

  13. Benni Mack commented on patch set 5 11/04/25, 07:46

    LocalizationFactory.php:78

    I think we should mark this method internal.
  14. Lina Wolf uploaded patch set 6 V +1 11/04/25, 12:22

  15. Lina Wolf commented on patch set 6 11/04/25, 12:22

    LocalizationFactory.php:78 Reply

    Done
  16. core-ci voted on patch set 6 V +1 11/04/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88460

  17. Benni Mack commented on patch set 7 V +1 11/04/25, 16:47

    Published edit on patch set 6.
  18. core-ci voted on patch set 7 V +1 11/04/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88471

  19. Garvin Hicking commented on patch set 7 11/10/25, 14:52

    TranslationDomainListCommand.php:59

    This can be done in a follow-up: I think we should also have a "only-deprecated" option too, to see which active domains are there that are deprecated. (I'm open to the naming, not sure if we could combine that in a single option like "--deprecations=only|show|hide" or so)

    TranslationDomainListCommand.php:129

    I think the number of columns in CLI is an issue. Could we rather include something like "(deprecated)" (with color?) as the first line of the "Label resource" instead? Once we integrate JSON output that would be a distinct JSON key then. Also: The column would only make sense if "includeDeprecated" is enabled, right?
  20. Lina Wolf commented on patch set 7 11/11/25, 03:39

    TranslationDomainListCommand.php:129 Reply

    I thought of it of a general column to show status information, the deprecation informaion being the first but we could also have information like "fully reviewed" or "XLIFF 1.2" in there. But I am also ok with hiding it if it is empty
  21. Garvin Hicking commented on patch set 7 CR +1 V +1 11/11/25, 08:53

    TranslationDomainListCommand.php:59 Reply

    Done

    TranslationDomainListCommand.php:129 Reply

    Let's work on this in a follow-up, I didn't want to stall progress here.
  22. Sven Liebert voted on patch set 7 CR +1 V +1 11/11/25, 09:02

  23. Garvin Hicking voted on patch set 7 CR +2 V +2 11/11/25, 09:19

  24. Garvin Hicking merged patch set 8 11/11/25, 09:19