Review main Merged

91376[TASK] Migrate Help Modules into User Toolbar

Michael Binder CR +2 V +2 Normal +54 −167 updated 11/12/25, 19:28

Commit message

Relocates the help modules from the help toolbar
as an own section to the user toolbar.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2736

Show 711 earlier messages
  1. Michael Binder uploaded patch set 1 10/30/25, 19:23

  2. core-ci voted on patch set 1 V -1 10/30/25, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88181

  3. Michael Binder uploaded patch set 2 V -1 10/30/25, 19:38

  4. core-ci voted on patch set 2 V -1 10/30/25, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88184

  5. Michael Binder uploaded patch set 3 V -1 10/30/25, 20:04

  6. core-ci voted on patch set 3 V +1 10/30/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88188

  7. Oli Bartsch commented on patch set 3 10/30/25, 21:22

    I think below is a leftover?

    Modules.php:20

    Not sure if this should not better be a third level module, WDYT @benni@typo3.org?

    Modules.php:20

    We need at least a "go back" button in the about view to allow getting back to the user settings: ``` $view->addButtonToButtonBar($this->componentFactory->createBackButton($this->uriBuilder->buildUriFromRoute('user_setup'))); ```

    Main.html:19

    We usually do not use those classes for styling.

    Main.html:21

    The form should always be on the top.
  8. Michael Binder uploaded patch set 4 V +1 10/31/25, 12:42

  9. Michael Binder commented on patch set 4 10/31/25, 12:43

    Reply

    Yes it was a leftover

    Modules.php:20 Reply

    I have added the back button.

    Main.html:19 Reply

    Hopefully converted correctly

    Main.html:21 Reply

    The form is now always on top
  10. core-ci voted on patch set 4 V +1 10/31/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88252

  11. Benni Mack commented on patch set 4 10/31/25, 16:22

    Modules.php:20 Reply

    I don't think this needs to be accessed anymore. Dashboard should be the intro
  1. Oliver Klee updated the commit message in patch set 5 V +1 10/31/25, 17:44

  2. core-ci voted on patch set 5 V +1 10/31/25, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88285

  3. Oli Bartsch uploaded patch set 6 V +1 11/07/25, 17:17

  4. Oli Bartsch uploaded patch set 7 11/07/25, 17:20

  5. core-ci voted on patch set 6 V +1 11/07/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88659

  6. core-ci voted on patch set 7 V -1 11/07/25, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88660

  7. Oli Bartsch uploaded patch set 8 V -1 11/07/25, 17:35

  8. core-ci voted on patch set 8 V +1 11/07/25, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88663

  9. Oli Bartsch voted on patch set 8 CR +1 V +1 11/07/25, 17:53

  10. Georg Ringer commented on patch set 8 V -1 11/08/25, 08:07

    I am not sure if we really want that? now the user settings are even more cluttered with: - user settings - help with at least 2 lines - recently switched users - light/dark mode switch - logout I am not blocking anything but for me this is now less clean and having a dedicated help bar was nicer for me
  11. Simon Schaufelberger commented on patch set 8 CR -1 V -1 11/08/25, 09:18

    Reply

    I must agree with Georg. having these menu items there feels wrong to me.
  12. Simon Schaufelberger commented on patch set 8 11/08/25, 09:21

    I would ask the ux team what they think about that
  13. Benni Mack commented on patch set 8 11/08/25, 10:39

    Reply

    The bigger picture here is to make the "User" module menu more prominent, where can you can also modify your bookmarks / shortcuts in a better way, have proper help and an overview of your settings. The current situation that we have had forever does not suit anymore when we compare TYPO3 with other CMSes.
  14. Oli Bartsch commented on patch set 8 11/08/25, 10:56

    Reply

    Hi Simon, as we are currently still in a sprint release, not everything we merge is the final solution. This as a pre patch. It allows to further work on a more state-of-the-art user hub for LTS. This is covered by UX analysis and research.
  15. Simon Schaufelberger commented on patch set 8 11/08/25, 11:57

    Reply

    Bookmarks makes sense as this is user specific but help is not user related. That is why it feels wrong to me. Additionally I never use these links and always use google or AI for help or go directly to docs.typo3.org. I would find it annoying to have these links there suddenly. That is why I would like to see the bigger picture here.
  16. Simon Schaufelberger commented on patch set 8 11/08/25, 12:06

    Reply

    Wordpess has a little menu directly at the top left corner over the Wordpress Icon. That feels much more intuitive than under the user menu.
  17. Benni Mack commented on patch set 8 11/12/25, 19:15

    AboutController.php:25

    this change seems unrelated?
  18. Georg Ringer voted on patch set 8 CR +1 V +1 11/12/25, 19:15

  19. Benni Mack commented on patch set 8 11/12/25, 19:18

    Reply

    I don't this is as intuitive, rather really hidden. esp. since in TYPO3 you can also modify the icon. So this "Help" would be hidden behind the "Technische Universität München" logo? I also double-checked with Laura, my UX colleague, again today, (I created a new ticket again after talking to her) - the amount of icons on the top bar is incredibly unintuitve nowadays, we need to slowly migrate to another concept - https://forge.typo3.org/issues/108076
  20. Benni Mack uploaded patch set 9 CR +1 V +1 11/12/25, 19:19

  21. Benni Mack commented on patch set 9 11/12/25, 19:20

    Reply

    see https://forge.typo3.org/issues/108076 - will close this now, as we can move along and integrate a real "user hub" like in GitHub/GitLab/AWS/Drupal/Sulu CMS

    AboutController.php:25 Reply

    Done
  22. Benni Mack voted on patch set 9 CR +1 V +1 11/12/25, 19:20

  23. core-ci voted on patch set 9 V +1 11/12/25, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89391

  24. Georg Ringer voted on patch set 9 CR +2 V +2 11/12/25, 19:28

  25. Georg Ringer merged patch set 10 11/12/25, 19:28