Review main Merged Breaking

91379[!!!][TASK] Avoid rewriting CSS files in FE

Christian Kuhn CR +2 V +2 Hard +60 −301 updated 06/18/26, 23:10

Commit message

When FE is configured via TypoScript to create
compressed CSS files, it also parses CSS and
tries to remove comments and some whitespaces.

The patch removes this: The solution is based on
regexes that can potentially go wrong and may mess
up CSS, leading to hard to debug FE issues. This
becomes more likely with modern CSS syntax
additions. From a performance point of view, removing
comments does not reduce client parsetime measurably,
and transferring a couple of additional bytes is
insignificant, especially with text/css being
usually HTTP compressed by default web server
configuration already.

Instances truly worried about CSS file size should
use specialized asset management tools to minify
content instead of relying on a brittle custom
TYPO3 implementation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Markus Klein +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1013

  1. Christian Kuhn uploaded patch set 1 10/30/25, 22:29

  2. Christian Kuhn uploaded patch set 2 10/30/25, 22:35

  3. core-ci voted on patch set 1 V -1 10/30/25, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88201

  4. core-ci voted on patch set 2 V +1 10/30/25, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88202

  5. Christian Kuhn uploaded patch set 3 V +1 10/30/25, 23:59

  6. core-ci voted on patch set 3 V +1 10/31/25, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88203

  7. Markus Klein voted on patch set 3 CR +1 V +1 10/31/25, 10:33

  8. Georg Ringer voted on patch set 3 CR +1 V +1 10/31/25, 10:52

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 10/31/25, 14:51

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 10/31/25, 14:56

  11. Christian Kuhn merged patch set 4 10/31/25, 14:56

  12. Lina Wolf commented on patch set 4 11/02/25, 05:37

  13. Lina Wolf commented on patch set 4 11/02/25, 05:51

    Reply Unresolved

    The description in the tsref.xml also needs to be changed accordingly, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/91401