Review main Merged Breaking

91381[!!!][TASK] Merge FlexFormService into FlexFormTools

Christian Kuhn CR +2 V +2 Expert +517 −494 updated 11/02/25, 07:16

Commit message

We worked hard to turn FlexFormTools into a stateless service
in TYPO3 v13. It contains all casual service helper methods
around flex form handling except two methods in FlexFormService.

There is no good distinction between the two classes anymore,
except historical reasons. Various consuming classes actually
request injection of both services.

The patch merges the two main service methods from FlexFormService
into FlexFormTools. It establishes a class alias and configures
the dependency injection to still allow using the old class name
in TYPO3 v14. The two methods keep their name, two de facto obsolete
arguments vanish. A third method is inlined as internal private helper.

Due to the signature changes and the visibility change of the helper
method, the patch is declared breaking, even though consumers can
usually just switch the class name and call it a day.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 1321

  1. Christian Kuhn uploaded patch set 1 10/31/25, 00:24

  2. Christian Kuhn uploaded patch set 2 10/31/25, 00:43

  3. Christian Kuhn uploaded patch set 3 10/31/25, 01:03

  4. core-ci voted on patch set 1 V -1 10/31/25, 01:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88206

  5. core-ci voted on patch set 3 V -1 10/31/25, 01:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88210

  6. Christian Kuhn uploaded patch set 4 V -1 10/31/25, 01:33

  7. Christian Kuhn uploaded patch set 5 10/31/25, 01:34

  8. core-ci voted on patch set 2 V -1 10/31/25, 01:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88207

  9. core-ci voted on patch set 4 V +1 10/31/25, 01:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88211

  10. core-ci voted on patch set 5 V +1 10/31/25, 01:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88212

  11. Christian Kuhn uploaded patch set 6 V +1 10/31/25, 01:58

  12. core-ci voted on patch set 6 V -1 10/31/25, 02:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88213

  13. Christian Kuhn uploaded patch set 7 V -1 10/31/25, 02:29

  14. Christian Kuhn uploaded patch set 8 10/31/25, 02:30

  15. core-ci voted on patch set 8 V +1 10/31/25, 02:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88216

  16. core-ci voted on patch set 7 V -1 10/31/25, 02:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88215

  17. Benni Mack commented on patch set 8 CR +1 V +1 10/31/25, 15:01

    thanks
  18. Stefan Bürk voted on patch set 8 CR +1 V +1 10/31/25, 16:21

  19. Christian Kuhn voted on patch set 8 CR +2 V +2 10/31/25, 17:04

  20. Christian Kuhn merged patch set 9 10/31/25, 17:04

  21. Lina Wolf commented on patch set 9 11/02/25, 07:16