Review main Merged

91385[TASK] Remove attribute space='preserve' from xlf files

Georg Ringer CR +2 V +2 Nightmare +2196 −2209 updated 01/18/26, 08:39

Commit message

The attribute `xml:space="preserve"` must only be used if the spaces
are relevant and must be preserved. Even though there is no official
support for the attribute, it should be used correctly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 2330

Show 45 earlier messages
  1. Georg Ringer uploaded patch set 1 10/31/25, 08:12

  2. Georg Ringer commented on patch set 1 10/31/25, 08:12

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/31/25, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88231

  4. Lina Wolf commented on patch set 1 11/03/25, 12:48

    I carefully reviewed all changes and found one where I would have said changes need to be preserved.

    Database.xlf:1271

    This one might need space. It contains a new line that marks a paragraph
  5. Georg Ringer uploaded patch set 2 V +1 11/03/25, 20:48

  1. Georg Ringer commented on patch set 2 11/03/25, 20:48

    Database.xlf:1271 Reply

    Done
  2. core-ci voted on patch set 2 V +1 11/03/25, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88417

  3. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/04/25, 01:18

  4. Lina Wolf voted on patch set 2 CR +1 V +1 11/04/25, 12:29

  5. Simon Schaufelberger commented on patch set 2 11/04/25, 13:03

    locallang.xlf:291

    can this be trimmed or is it necessary to keep the whitespace her?
  6. Georg Ringer uploaded patch set 3 CR +1 V +1 12/29/25, 17:39

  7. core-ci voted on patch set 3 V -1 12/29/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92782

  8. Georg Ringer uploaded patch set 4 V -1 01/09/26, 07:51

  9. core-ci voted on patch set 4 V +1 01/09/26, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93137

  10. Simon Schaufelberger uploaded patch set 5 V +1 01/13/26, 01:33

  11. Simon Schaufelberger uploaded patch set 6 01/13/26, 01:34

  12. Simon Schaufelberger commented on patch set 6 CR +1 V +1 01/13/26, 01:36

    locallang.xlf:291 Reply

    Done
  13. Simon Schaufelberger uploaded patch set 7 CR +1 V +1 01/13/26, 01:42

  14. core-ci voted on patch set 6 V -1 01/13/26, 01:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93300

  15. Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/13/26, 01:43

  16. Simon Schaufelberger uploaded patch set 8 CR +1 V +1 01/13/26, 01:48

  17. core-ci voted on patch set 7 V -1 01/13/26, 01:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93301

  18. Simon Schaufelberger uploaded patch set 9 01/13/26, 01:52

  19. core-ci voted on patch set 9 V +1 01/13/26, 01:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93303

  20. Simon Schaufelberger commented on patch set 9 01/13/26, 02:01

    locallang_core.xlf:903

    this is not used in the core and should be deprecated, or?
  21. Georg Ringer commented on patch set 9 01/13/26, 21:14

    locallang_core.xlf:903 Reply

    don't know tbh but not part of that issue
  22. Anja Leichsenring voted on patch set 9 CR +1 V +1 01/15/26, 08:00

  23. Simon Schaufelberger commented on patch set 9 CR +1 V +1 01/15/26, 09:33

    locallang_core.xlf:903 Reply

    Done
  24. Benni Mack voted on patch set 9 CR +2 V +2 01/18/26, 08:39

  25. Benni Mack merged patch set 10 01/18/26, 08:39