91388[TASK] Support "attributes" for all kind of buttons
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Christian Kuhn +1
- Josua Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Christian Kuhn +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Template/Components/Buttons/AbstractButton.php+22 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php+3 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+3 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php4+9 −5
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/SplitButtonTest.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107823-ComponentFactoryForBackendComponents.rst+6 −2
Review log 2329
Show 34 earlier messages
-
Oli Bartsch uploaded patch set 1 10/31/25, 10:47
-
core-ci voted on patch set 1 V +1 10/31/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88244
-
Josua Vogel voted on patch set 1 CR +1 V +1 10/31/25, 11:04
-
Garvin Hicking commented on patch set 1 10/31/25, 11:19
notes I submitted to Oli also via DM: - We should enhance the componentnfactory ReST file to note these enhancements for the API (so they can be documented) - should DropDownButton also receive these attributes? It's also lacking dataAttributes atm
-
Christian Kuhn voted on patch set 1 CR +1 V +1 10/31/25, 11:21
-
Oli Bartsch uploaded patch set 2
CR +1V +110/31/25, 12:20 -
Oli Bartsch uploaded patch set 3 10/31/25, 12:21
-
Oli Bartsch commented on patch set 3 10/31/25, 12:22
Reply
I've added this to the RST. `DropDownButton` is dedicated to be the button to toggle the dropdown and does not provide any further API. Therefore it does not extend any Abstract class. -
core-ci voted on patch set 2 V +1 10/31/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88250
-
core-ci voted on patch set 3 V +1 10/31/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88251
-
Garvin Hicking voted on patch set 3 CR +1 V +1 10/31/25, 12:30
-
Josua Vogel voted on patch set 3 CR +1 V +1 10/31/25, 12:33
-
Christian Kuhn voted on patch set 3 CR +1 V +1 10/31/25, 12:34
-
Ayke Halder commented on patch set 3 CR -1 10/31/25, 12:42
SplitButton.php:200Is there a reason for not using `GeneralUtility::implodeAttributes($attributes, true)` here? This is usually always done so - see `LinkButton`, `GenericButton::getAttributesString()` etc. -
Oli Bartsch uploaded patch set 4
CR +1V +110/31/25, 12:47 -
Oli Bartsch commented on patch set 4 10/31/25, 12:48
SplitButton.php:200ReplyWhile this is irrelevant to this patch, I have changed this anyways. -
Josua Vogel voted on patch set 4 CR +1 V +1 10/31/25, 12:49
-
Ayke Halder commented on patch set 4 CR -1 10/31/25, 12:53
SplitButton.php:208Now this needs a proper blank space here: ```suggestion $primaryButtonHTML = '<button ' . $attributesString . ' type="submit"> ``` -
Oli Bartsch commented on patch set 5
CR +1V +110/31/25, 12:55Published edit on patch set 4. -
Oli Bartsch commented on patch set 5 10/31/25, 12:55
SplitButton.php:208ReplyFix applied. -
core-ci voted on patch set 4 V -1 10/31/25, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88254
-
Oli Bartsch uploaded patch set 6 10/31/25, 12:58
-
core-ci voted on patch set 5 V -1 10/31/25, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88255
-
Christian Kuhn voted on patch set 6 CR +1 V +1 10/31/25, 13:00
-
core-ci voted on patch set 6 V +1 10/31/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88256
-
Josua Vogel voted on patch set 6 CR +1 V +1 10/31/25, 13:10
-
Garvin Hicking voted on patch set 6 CR +1 V +1 10/31/25, 13:13
-
Oli Bartsch voted on patch set 6 CR +2 V +2 10/31/25, 13:22
-
Oli Bartsch merged patch set 7 10/31/25, 13:22