Review main Merged

9139[FEATURE] Make saltedpasswords conversion task options configurable

Philipp Gampe CR +2 V +2 Hard +281 −24 updated 06/03/13, 20:49

Commit message

The saltedpassword password conversion task for the schedular features
two configuration option:
 * canDeactivateSelf to disable the task after all records are processed
 * numberOfRecords to define how many records should be processed at
   once
Make those two options configurable via the schedular task edit
interface.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 7

Review log 24

  1. Christian Kuhn merged patch set 1 06/30/12, 12:26

  2. Philipp Gampe uploaded patch set 2 06/30/12, 12:26

    Releases line needs to be update before merge
  3. Philipp Gampe commented on patch set 2 06/30/12, 12:26

    Note: we need to check whether this could destroy existing passwords.
  4. Oliver Klee commented on patch set 3 06/30/12, 12:26

    No score
  5. Oliver Klee commented on patch set 3 06/30/12, 12:26

    (1 inline comment)
  6. Oliver Klee commented on patch set 3 06/30/12, 12:26

    (10 inline comments)
  7. Oliver Klee commented on patch set 3 3 comments 06/30/12, 12:26

    Looks good to me, but someone else must approve
  8. Xavier Perseguers commented on patch set 3 06/30/12, 12:26

    (12 inline comments) Otherwise looks OK
  9. Philipp Gampe commented on patch set 3 06/30/12, 12:26

    (1 inline comment) Duno if this still applies
  10. Philipp Gampe uploaded patch set 3 06/30/12, 12:26

  11. Philipp Gampe commented on patch set 3 06/30/12, 12:26

    I will upload a new version soon
  12. Philipp Gampe commented on patch set 3 06/30/12, 12:26

    I just changed a lot of doc comments. Now the classes are without warnings in my IDE :) The change can not do any harm to the passwords, because if only resets the counter and sets how many records are processed. Safety checks to not convert an already converted passwords are already in place and independent from this change.
  13. Mr. Jenkins commented on patch set 1 06/30/12, 12:26

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3355/ : FAILURE
  14. Mr. Jenkins commented on patch set 2 06/30/12, 12:26

  15. Mr. Jenkins commented on patch set 3 06/30/12, 12:26

  16. Wouter Wolters commented on patch set 3 06/30/12, 12:26

    (22 inline comments)

    class.tx_saltedpasswords_tasks_bulkupdate.php:109 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:111 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:113 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:149 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:172 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:175 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:177 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:259 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:268 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:273 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:275 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:280 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate.php:282 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:29 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:32 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:43 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:46 Reply

    If we do this then: PHP Fatal error: Declaration of tx_saltedpasswords_Tasks_BulkUpdate_AdditionalFieldProvider::getAdditionalFields() must be compatible with that of tx_scheduler_AdditionalFieldProvider::getAdditionalFields() will happen

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:69 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:110 Reply

    Done

    class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:125 Reply

    Done

    ext_tables.php:50 Reply

    Done

    locallang.xlf:31 Reply

    This looks Ok.
  17. Christian Kuhn uploaded patch set 5 06/30/12, 12:26

  18. Christian Kuhn commented on patch set 5 06/30/12, 12:26

    Verified; Looks good to me, but someone else must approve
  19. Christian Kuhn commented on patch set 5 V 0 06/30/12, 12:26

    by team member; Looks good to me, approved
  20. Mr. Jenkins commented on patch set 4 06/30/12, 12:26

  21. Mr. Jenkins commented on patch set 5 06/30/12, 12:26

  22. Wouter Wolters uploaded patch set 4 06/30/12, 12:26

  23. Wouter Wolters commented on patch set 5 06/30/12, 12:26

    Verified; Looks good to me, but someone else must approve
  24. Philipp Gampe commented on patch set 5 06/30/12, 12:26

    Thanks Wouter for taking care.