9139[FEATURE] Make saltedpasswords conversion task options configurable
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 7
- typo3/sysext/saltedpasswords/classes/tasks/class.tx_saltedpasswords_tasks_bulkupdate.php27+83 −23
- typo3/sysext/saltedpasswords/classes/tasks/class.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php15new+152 −0
- typo3/sysext/saltedpasswords/ext_autoload.php+1 −0
- typo3/sysext/saltedpasswords/ext_localconf.php+1 −1
- typo3/sysext/saltedpasswords/ext_tables.php2+2 −0
- typo3/sysext/saltedpasswords/locallang.xlf2+15 −0
- typo3/sysext/saltedpasswords/locallang_csh_saltedpasswords.xlfnew+27 −0
Review log 24
-
Christian Kuhn merged patch set 1 06/30/12, 12:26
-
Philipp Gampe uploaded patch set 2 06/30/12, 12:26
Releases line needs to be update before merge -
Philipp Gampe commented on patch set 2 06/30/12, 12:26
Note: we need to check whether this could destroy existing passwords. -
Oliver Klee commented on patch set 3 06/30/12, 12:26
No score -
Oliver Klee commented on patch set 3 06/30/12, 12:26
(1 inline comment) -
Oliver Klee commented on patch set 3 06/30/12, 12:26
(10 inline comments) -
Oliver Klee commented on patch set 3 3 comments 06/30/12, 12:26
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 3 06/30/12, 12:26
(12 inline comments) Otherwise looks OK -
Philipp Gampe commented on patch set 3 06/30/12, 12:26
(1 inline comment) Duno if this still applies -
Philipp Gampe uploaded patch set 3 06/30/12, 12:26
-
Philipp Gampe commented on patch set 3 06/30/12, 12:26
I will upload a new version soon -
Philipp Gampe commented on patch set 3 06/30/12, 12:26
I just changed a lot of doc comments. Now the classes are without warnings in my IDE :) The change can not do any harm to the passwords, because if only resets the counter and sets how many records are processed. Safety checks to not convert an already converted passwords are already in place and independent from this change. -
Mr. Jenkins commented on patch set 1 06/30/12, 12:26
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3355/ : FAILURE -
Mr. Jenkins commented on patch set 2 06/30/12, 12:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3357/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/30/12, 12:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3493/ : SUCCESS -
Wouter Wolters commented on patch set 3 06/30/12, 12:26
(22 inline comments)class.tx_saltedpasswords_tasks_bulkupdate.php:109ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:111ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:113ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:149ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:172ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:175ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:177ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:259ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:268ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:273ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:275ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:280ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate.php:282ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:29ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:32ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:43ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:46ReplyIf we do this then: PHP Fatal error: Declaration of tx_saltedpasswords_Tasks_BulkUpdate_AdditionalFieldProvider::getAdditionalFields() must be compatible with that of tx_scheduler_AdditionalFieldProvider::getAdditionalFields() will happenclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:69ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:110ReplyDoneclass.tx_saltedpasswords_tasks_bulkupdate_additionalfieldprovider.php:125ReplyDoneext_tables.php:50ReplyDonelocallang.xlf:31ReplyThis looks Ok. -
Christian Kuhn uploaded patch set 5 06/30/12, 12:26
-
Christian Kuhn commented on patch set 5 06/30/12, 12:26
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 5 V 0 06/30/12, 12:26
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 4 06/30/12, 12:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4627/ : SUCCESS -
Mr. Jenkins commented on patch set 5 06/30/12, 12:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4641/ : SUCCESS -
Wouter Wolters uploaded patch set 4 06/30/12, 12:26
-
Wouter Wolters commented on patch set 5 06/30/12, 12:26
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 06/30/12, 12:26
Thanks Wouter for taking care.