Review main Merged

91392[FEATURE] Add filter for currently logged-in BE users

Stefan Froemken CR +2 V +2 Hard +237 −27 updated 11/04/25, 15:27

Commit message

New option allows integrators to list users
active within the configured backend session timeout.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1623

  1. Stefan Froemken uploaded patch set 1 10/31/25, 13:16

  2. core-ci voted on patch set 1 V -1 10/31/25, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88257

  3. Stefan Froemken uploaded patch set 2 V -1 10/31/25, 14:15

  4. core-ci voted on patch set 2 V -1 10/31/25, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88262

  5. Stefan Froemken uploaded patch set 3 V -1 10/31/25, 14:28

  6. HOJA M A voted on patch set 3 CR +1 10/31/25, 14:33

  7. core-ci voted on patch set 3 V +1 10/31/25, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88264

  8. Georg Ringer commented on patch set 3 10/31/25, 17:40

    BackendUserRepository.php:95

    can we change that to an else/if oder switch? as drive by we could also change it in the constraints above too
  9. Stefan Froemken uploaded patch set 4 11/03/25, 06:35

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  10. Stefan Froemken uploaded patch set 5 CR +1 V +1 11/03/25, 06:35

  11. Stefan Froemken commented on patch set 5 11/03/25, 06:36

    BackendUserRepository.php:95 Reply

    Done
  12. Stefan Froemken updated the commit message in patch set 6 11/03/25, 06:40

  13. core-ci voted on patch set 4 V +1 11/03/25, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88345

  14. core-ci voted on patch set 5 V +1 11/03/25, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88346

  15. core-ci voted on patch set 6 V +1 11/03/25, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88347

  16. Georg Ringer voted on patch set 6 CR +1 V +1 11/03/25, 09:21

  17. Garvin Hicking uploaded patch set 7 CR +1 V +1 11/03/25, 19:24

  18. Georg Ringer voted on patch set 7 CR +1 V +1 11/03/25, 19:24

  19. Garvin Hicking commented on patch set 7 CR +1 V +1 11/03/25, 19:25

    I think I misled Stefan with my idea of using a match statement, but I just couldn't get over the looks of it. Patchset 7 offers a switch/case syntax which I find more readable. But I'm fine either way, feel free to discard and I'll revote. Thanks for this! :)
  20. core-ci voted on patch set 7 V +1 11/03/25, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88416

  21. Lina Wolf commented on patch set 7 CR +1 V +1 11/04/25, 13:27

    Works good for me, I think the switch statement is ok, certainly more readable then the former if statement
  22. Benni Mack voted on patch set 7 CR +2 V +2 11/04/25, 15:27

  23. Benni Mack merged patch set 8 11/04/25, 15:27