91400[TASK] Cleanup phpstan baseline for extbase functional tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 10
- Build/phpstan/phpstan-baseline.neon+1 −73
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Administrator.php+3 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyLoadingProxyTest.php+0 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyObjectStorageTest.php+1 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/RepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Property/PropertyMapperTest.php8+0 −3
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+3 −6
Review log 1214
-
Torben Hansen uploaded patch set 1 11/01/25, 08:53
-
core-ci voted on patch set 1 V +1 11/01/25, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88301
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/01/25, 17:59
-
Simon Schaufelberger commented on patch set 1 11/01/25, 18:00
would it be good to backport this? -
Oliver Klee commented on patch set 1 V +1 11/02/25, 10:01
PropertyMapperTest.php:224This line shouldn't be necessary as the `phpstan/phpstan-phpunit` package can deduct this from the `assertInstanceOf` call.PropertyMapperTest.php:246Ditto.PropertyMapperTest.php:291Ditto. -
Torben Hansen commented on patch set 1 11/02/25, 11:37
Reply
I do not this that it would provide any value for v13.PropertyMapperTest.php:224ReplyI moved those after the `assertInstanceOf`, so we still have code completion for the object in the IDE. OK to keep them? What do you think? -
Oliver Klee commented on patch set 1 11/02/25, 12:11
PropertyMapperTest.php:224ReplyI'd prefer to not have the type annotation (as redundant PHPDoc type annotations need to be maintained manually and tend to get out of sync). I don't see this as a blocker for me, though. So if you strongly prefer to keep them, please feel free do so. -
Torben Hansen uploaded patch set 2
CR +1V +111/02/25, 13:16 -
Torben Hansen commented on patch set 2 11/02/25, 13:23
PropertyMapperTest.php:224ReplyThanks for sharing your thoughts. I have now removed the `@var` annotations for affected variables in `PropertyMapperTest`. It seems, the IDE (at least phpstorm/intellij) also resolves the type of `$result` and provides code completion for properties and methods. -
Torben Hansen commented on patch set 2 11/02/25, 13:23
PropertyMapperTest.php:246ReplyDonePropertyMapperTest.php:291ReplyDone -
core-ci voted on patch set 2 V +1 11/02/25, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88320
-
Oliver Klee voted on patch set 2 CR +1 V +1 11/02/25, 14:37
-
Benni Mack voted on patch set 2 CR +2 V +2 11/03/25, 09:03
-
Benni Mack merged patch set 3 11/03/25, 09:03