91402[FEATURE] Search translated pages in page tree filter
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Garvin Hicking +1
- Josua Vogel +1
- Sven Liebert +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Garvin Hicking +1
- Josua Vogel +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 21
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+51 −0
- Build/Sources/TypeScript/backend/tree/tree-node.ts+1 −0
- Build/Sources/TypeScript/backend/tree/tree.ts2+10 −3
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+19 −2
- typo3/sysext/backend/Classes/Dto/Tree/Label/Label.php+2 −0
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeFilter.php2+420 −2
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php2+35 −12
- typo3/sysext/backend/Configuration/user.tsconfig+1 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/tree.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/be_users_language_restricted.csvnew+6 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/be_users_no_translated_search.csvnew+3 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/TranslatedPages.csvnew+3 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/TranslatedPagesMultiByteCharacters.csvnew+8 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/TranslatedPagesMultipleLanguages.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/PageTreeFilterTest.phpnew+545 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/PageTreeRepositoryTest.php+116 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-107961-SearchTranslatedPagesInPageTree.rst6new+109 −0
Show 1 more file
Review log 2430
Show 35 earlier messages
-
Oli Bartsch uploaded patch set 1 11/02/25, 09:49
-
core-ci voted on patch set 1 V -1 11/02/25, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88318
-
Oli Bartsch uploaded patch set 2
V -111/02/25, 10:04 -
core-ci voted on patch set 2 V +1 11/02/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88319
-
Lina Wolf commented on patch set 2 11/05/25, 12:47
I found the old layout from the previous patch easier to understand without description, also it had the advantage to be understandable without applying meaning to color (which is not accessible)
-
Lina Wolf commented on patch set 2 11/05/25, 12:48
The highlighting of the found string inside of the page tree is now missing. Therefore it is harder to quickly detect where in the title the word was found -
Oli Bartsch uploaded patch set 3
V +111/26/25, 06:36 -
Oli Bartsch commented on patch set 2 11/26/25, 06:37
Reply
why is this relevant? This even does not work if you use a nac title and search for the title (in default) and does obviously also not work for localizations. So there is a single use case when this would work at all => search for title and only title is set for a page.Reply
Previous patch also used color, which is not accessible in the current implementation as well. This patch even improves this by adding the information to the label that a node was found and in which language. -
core-ci voted on patch set 3 V +1 11/26/25, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90999
-
Garvin Hicking commented on patch set 3 11/26/25, 07:12
Feature-107961-SearchTranslatedPagesInPageTree.rstThis file needs to be moved to 14.1 -
Oli Bartsch uploaded patch set 4
V +111/26/25, 07:18 -
Oli Bartsch commented on patch set 4 11/26/25, 07:19
Feature-107961-SearchTranslatedPagesInPageTree.rstReplyDone -
core-ci voted on patch set 4 V +1 11/26/25, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91003
-
Oli Bartsch commented on patch set 4 11/26/25, 07:30
Reply
And to give more context, I've removed this based on feedback, which showed that the regex on every node item already has quite performance implications. Those are also resolved with this patch. -
Garvin Hicking commented on patch set 4 11/27/25, 09:20
Reply
As discussed privately: I also would not want to live without the highlighting feature here. It is applied only to the nodes found in a search result, and the impact should not really be that much. If you have that many results that the regexps matter, you have other browser UI performance problems already. In that case I would only remove regexp highlighting for let's say 100+ results. We could also remove the highlighting when only 1 character is entered for the search? 2 characters would also have a benefit when for example search for product codes and having 2 numbers.Very nice. Once the string highlight is back I would like to have this! :)PageTreeRepository.php:551I understand the "else" part receiving secure gating, but here for a constant "0" I think we can prevent named parameters for some micro optimizationFeature-107961-SearchTranslatedPagesInPageTree.rst:83While I can understand the reasoning and I would be okay with it, it feels a bit too "christmas-tree-y" to me with that many labels. Personally I would be fine with only having "orange" as a label indicating a match for a translation ONLY. The results that contain the searchword in only the "original" and in original AND translation could just have no coloured label. (My subjective opinion)Feature-107961-SearchTranslatedPagesInPageTree.rst:85```suggestion Flexibility for developers ``` -
Oli Bartsch uploaded patch set 5
V +112/03/25, 10:39 -
core-ci voted on patch set 5 V -1 12/03/25, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91514
-
Oli Bartsch uploaded patch set 6
V -112/03/25, 11:01 -
core-ci voted on patch set 6 V +1 12/03/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91515
-
Oli Bartsch commented on patch set 6 12/03/25, 11:21
Reply
DonePageTreeRepository.php:551ReplyDoneFeature-107961-SearchTranslatedPagesInPageTree.rst:83ReplyWe now only use one color.Feature-107961-SearchTranslatedPagesInPageTree.rst:85ReplyDone -
Josua Vogel commented on patch set 6 12/04/25, 10:54
tree.ts:1129Is it an existing performance problem, or is it caused by this change?PageTreeFilter.php:214I am undecided as to whether “Search result” should always appear on the label/title. Ultimately, this item represents a search result, even if it refers to the translations hidden “behind” it.Feature-107961-SearchTranslatedPagesInPageTree.rst:22maybe we should mention the backend name, e.g. ```suggestion title or "Alternative Navigation Title" (nav_title), the corresponding default language page will be found and ``` -
Jochen Roth voted on patch set 6 CR +1 V +1 12/04/25, 13:10
-
Sven Liebert voted on patch set 6 CR +1 V +1 12/04/25, 15:13
-
Oli Bartsch commented on patch set 6 12/04/25, 22:23
tree.ts:1129ReplyAccording to @benjamin.kott@outlook.com it is an existing problem. Thats why I removed this feature initially but added it again with those "limitations". (see comments by Garvin)PageTreeFilter.php:214ReplyFor me this would duplicate the information and would hinder the distinction between direct match and translated page.Feature-107961-SearchTranslatedPagesInPageTree.rst:22ReplyI would like to keep it, because this is a technical description of the fields, being considered for filtering. Such changelog is usually not meant as an editor guide. Such information would be placed in the official docs instead. -
Oli Bartsch commented on patch set 6 12/04/25, 22:24
Reply
Done -
Josua Vogel voted on patch set 6 CR +1 V +1 12/05/25, 05:58
-
Garvin Hicking commented on patch set 6 12/05/25, 10:13
reviewing -
Garvin Hicking commented on patch set 6 CR +1 V +1 12/05/25, 11:56
Very helpful, and motivates me to finish the "search by frontend URI" patch. Thanks!Reply
Done -
Oli Bartsch voted on patch set 6 CR +2 V +2 12/05/25, 13:04
-
Oli Bartsch merged patch set 7 12/05/25, 13:04