Review main Merged

91403[BUGFIX] Define height for modal size "small"

Jochen Roth CR +2 V +2 Easy +7 −0 updated 11/03/25, 11:17

Commit message

Currently, when opening a modal of size "small"
using the iframe type, the modal height is 0px

This has been fixed by defining css height (same
as width) when a iframe is used. A max-height
is now also defined to ensure the complete modal
is visible in the viewport.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Jochen Roth uploaded patch set 1 11/02/25, 15:24

  2. core-ci voted on patch set 1 V +1 11/02/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88321

  3. Oli Bartsch commented on patch set 1 11/02/25, 22:02

    _modal.scss:233

    "height" with "--typo3-modal-width" 🤔
  4. Jochen Roth commented on patch set 1 11/02/25, 22:42

    _modal.scss:233 Reply

    I wanted it to be square :-)
  5. Benjamin Franzke uploaded patch set 2 V +1 11/03/25, 10:05

  6. Benjamin Franzke commented on patch set 2 11/03/25, 10:05

    v13 is also "affected", did you forgot to mention v13 or do you also see the need in v14?

    _modal.scss:232

    We can actually simply use `&.modal-type-iframe`

    _modal.scss:233 Reply

    Let's have a static value.

    _modal.scss:234

    Unneeded, we always have that set.
  7. core-ci voted on patch set 2 V +1 11/03/25, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88353

  8. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 11/03/25, 10:56

  9. Oli Bartsch commented on patch set 3 CR +1 V +1 11/03/25, 10:57

    Reply

    Done
  10. Benjamin Franzke voted on patch set 3 CR +1 V +1 11/03/25, 10:58

  11. core-ci voted on patch set 3 V +1 11/03/25, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88356

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 11/03/25, 11:17

  13. Oli Bartsch merged patch set 4 11/03/25, 11:17