91403[BUGFIX] Define height for modal size "small"
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1013
-
Jochen Roth uploaded patch set 1 11/02/25, 15:24
-
core-ci voted on patch set 1 V +1 11/02/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88321
-
Oli Bartsch commented on patch set 1 11/02/25, 22:02
-
Jochen Roth commented on patch set 1 11/02/25, 22:42
_modal.scss:233ReplyI wanted it to be square :-) -
Benjamin Franzke uploaded patch set 2
V +111/03/25, 10:05 -
Benjamin Franzke commented on patch set 2 11/03/25, 10:05
v13 is also "affected", did you forgot to mention v13 or do you also see the need in v14?_modal.scss:232We can actually simply use `&.modal-type-iframe`_modal.scss:233ReplyLet's have a static value._modal.scss:234Unneeded, we always have that set. -
core-ci voted on patch set 2 V +1 11/03/25, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88353
-
Oli Bartsch updated the commit message in patch set 3
CR +1V +111/03/25, 10:56 -
Oli Bartsch commented on patch set 3 CR +1 V +1 11/03/25, 10:57
Reply
Done -
Benjamin Franzke voted on patch set 3 CR +1 V +1 11/03/25, 10:58
-
core-ci voted on patch set 3 V +1 11/03/25, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88356
-
Oli Bartsch voted on patch set 3 CR +2 V +2 11/03/25, 11:17
-
Oli Bartsch merged patch set 4 11/03/25, 11:17
_modal.scss:233