Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Orphaned Breaking

91404[!!!][TASK] Remove re-login password popup functionality

Torben Hansen CR +1 V +1 Hard +62 −198 updated 11/25/25, 10:11

Commit message

When a backend session has timed out, TYPO3 shows a
modal/popup where the backend user can enter the password
to re-login. However, the functionality does not take
into account that TYPO3 users may have logged in using an
external SSO provider and therefore do not have a password
in TYPO3. Additionally, the functionality does not work
when an admin impersonates another user, as the password
of the impersonated user is required to re-login.

This change removes the re-login password functionality
without replacement. When a backend session has timed
out, the web-browser will now show the regular TYPO3
backend login instead.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/04/91404/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/04/91404/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Sven Liebert +1
  • Verified V +1 Needs a vote
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1518

  1. Torben Hansen uploaded patch set 1 11/02/25, 18:29

  2. core-ci voted on patch set 1 V +1 11/02/25, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88322

  3. Benjamin Franzke commented on patch set 1 11/03/25, 13:07

    Unresolved

    sounds like a BUG that could be fixable, we can detect change-user(?)

    Unresolved

    well, it's still there and will do redirects, that is a replacement, no? (I'm actually only stating that, because the redirect to the login causes context lost – we'd at least need to preserve context using a (safe)redirect back to the previous state)

    login-refresh.ts:144 Unresolved

    This let's user "lose" all their current context, can we try to open the login in a new tab instead? I know that we still need to update tokens, but we're discussing ways to update all tokens in order to also handle cases where multiple tabs were logged in and are expected to be interopable (again) after reauthenticating in another tab.

    login-refresh.ts:196 Unresolved

    leftover

    login-refresh.ts:248 Unresolved

    I'd love to avoid this, logging out every tab a user has opened is destructive. As mentioned in another comment, we should instead ways to automatically pickup a reauthentication from another tab (via browser broadcast message) and update local tokens in order to let the user go-on or restart from where an action stopped.
  4. Lina Wolf commented on patch set 1 11/03/25, 15:46

    To me, the reasons you listed don’t seem unfixable. Instead of removing the functionality entirely, could we introduce a system setting to disable it in projects where SSO without passwords is used? Removing a convenient feature for all users because it doesn’t fit a few installations feels a bit excessive.
  5. Torben Hansen commented on patch set 1 11/03/25, 17:08

    Reply

    Please see comments in the 3 year old forge ticket. Several core developers opted to remove the functionality. Additionally, I have seen scenarios, where the password dialog did not work after session expiration (maybe due to login token expiration), but I have not digged deeper into the problem. I'm on the code sprint next week in DUS and open for discussions about the topic.
  6. Oli Bartsch commented on patch set 1 11/04/25, 08:24

    Reply

    this would be the now removed $TYPO3_CONF_VARS[BE][showRefreshLoginPopup] option.
  7. Markus Klein commented on patch set 1 11/04/25, 10:06

    I appreciate this change, but we should/must add an indication on how long a session is still valid, for accessibility reasons. (Like you probably know that from banking sites)
  8. Lina Wolf commented on patch set 1 11/04/25, 13:10

    Reply

    I would suggest to add such a functionality as a feature in a separate change
  9. Lina Wolf commented on patch set 1 11/04/25, 13:20

    login-refresh.ts:275

    The language strings are now unused and should be marked as such
  10. Lina Wolf uploaded patch set 2 V +1 11/04/25, 13:20

  11. Lina Wolf commented on patch set 2 11/04/25, 13:21

    login-refresh.ts:275 Reply

    Done
  12. core-ci voted on patch set 2 V +1 11/04/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88463

  13. Markus Klein voted on patch set 2 CR +1 11/04/25, 17:13

  14. Sven Liebert uploaded patch set 3 CR +1 V +1 11/24/25, 15:53

  15. core-ci voted on patch set 3 V +1 11/24/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90861

  16. Sven Liebert voted on patch set 3 CR +1 V +1 11/24/25, 18:31

  17. Lina Wolf commented on patch set 3 11/25/25, 09:58

    @derhansen@gmail.com are you still working on this?
  18. Torben Hansen commented on patch set 3 11/25/25, 10:11

    Reply

    Yes, but at least not today. Those https://forge.typo3.org/issues/108298 are Benni and my ideas in this area for >= v14