91405[TASK] Allow types for sys_redirect table
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 24
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php2+23 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107963-SysRedirectDefaultTypeName.rstnew+66 −0
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+36 −0
- typo3/sysext/redirects/Classes/Command/CleanupRedirectsCommand.php+10 −0
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+5 −0
- typo3/sysext/redirects/Classes/Repository/Demand.php5+26 −2
- typo3/sysext/redirects/Classes/Repository/RedirectRepository.php4+22 −0
- typo3/sysext/redirects/Configuration/Backend/Modules.php2+3 −0
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php11+9 −2
- typo3/sysext/redirects/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+1 −0
- typo3/sysext/redirects/Tests/Functional/Controller/ManagementControllerTest.php+4 −1
- typo3/sysext/redirects/Tests/Functional/EventListener/Fixtures/Redirects.csv+4 −4
- typo3/sysext/redirects/Tests/Functional/Fixtures/sys_redirect.csv+3 −3
- typo3/sysext/redirects/Tests/Functional/Repository/Fixtures/RedirectRepositoryTest_redirects.csv+8 −8
- typo3/sysext/redirects/Tests/Functional/Repository/RedirectRepositoryTest.php+1 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RegExp/case1.csv+4 −4
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RegExp/case2.csv+4 −4
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RegExp/case3.csv+4 −4
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_regexp.csv+19 −19
Show 4 more files
Review log 3248
Show 1423 earlier messages
-
Jochen Roth uploaded patch set 1 11/02/25, 20:30
-
Jochen Roth updated the commit message in patch set 2 11/02/25, 20:31
-
core-ci voted on patch set 1 V -1 11/02/25, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88326
-
core-ci voted on patch set 2 V -1 11/02/25, 20:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88327
-
Jochen Roth uploaded patch set 3
V -111/02/25, 20:51 -
Jochen Roth uploaded patch set 4 11/02/25, 20:55
-
core-ci voted on patch set 3 V -1 11/02/25, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88328
-
core-ci voted on patch set 4 V +1 11/02/25, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88329
-
Oli Bartsch commented on patch set 4 11/02/25, 22:06
-
Jochen Roth uploaded patch set 5
V +111/02/25, 23:11 -
Jochen Roth uploaded patch set 6 11/02/25, 23:17
-
core-ci voted on patch set 5 V -1 11/02/25, 23:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88330
-
core-ci voted on patch set 6 V +1 11/02/25, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88331
-
Simon Schaufelberger commented on patch set 6 11/02/25, 23:33
Demand.php:64can we make it an int?Demand.php:341no useless modifications pleaseRedirectRepository.php:225typesRedirectRepository.php:230since querybuilder is not reused, it can be inlinedModules.php:22reuse the constant from the DTO here?sys_redirect.php:39to be consistent, add a whitespacesys_redirect.php:61reuse the DTO constant here?sys_redirect.csv:3why is it a string here? would 1 not be enough?DemandTest.php:32why a string? -
Jochen Roth uploaded patch set 7
V +111/03/25, 18:28 -
Jochen Roth uploaded patch set 8 11/03/25, 18:29
-
Jochen Roth commented on patch set 8 11/03/25, 18:31
sys_redirect.php:61ReplyThanks, fixed it. :-) -
core-ci voted on patch set 7 V +1 11/03/25, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88408
-
core-ci voted on patch set 8 V +1 11/03/25, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88409
-
Simon Schaufelberger commented on patch set 8 11/03/25, 22:36
Demand.php:341ReplyDoneRedirectRepository.php:225ReplyDonesys_redirect.php:39ReplyDone -
Jochen Roth uploaded patch set 9
V +111/08/25, 09:39 -
Jochen Roth uploaded patch set 10 11/08/25, 09:44
-
core-ci voted on patch set 9 V -1 11/08/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88687
-
core-ci voted on patch set 10 V +1 11/08/25, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88688
-
Jochen Roth uploaded patch set 11
V +111/08/25, 09:58 -
core-ci voted on patch set 11 V +1 11/08/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88689
-
Oli Bartsch uploaded patch set 12
V +111/09/25, 16:57 -
core-ci voted on patch set 12 V -1 11/09/25, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88746
-
Oli Bartsch uploaded patch set 13
V -111/09/25, 17:05 -
Oli Bartsch commented on patch set 13 CR +1 V +1 11/09/25, 17:07
Demand.php:64```suggestion string $redirectType = self::DEFAULT_REDIRECT_TYPE, ```RedirectRepository.php:230ReplyDoneModules.php:22ReplyDonesys_redirect.php:61ReplyDone -
core-ci voted on patch set 13 V +1 11/09/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88747
-
Garvin Hicking commented on patch set 13 11/10/25, 13:13
sys_redirect.php:35Talked to Oli about this - maybe we should keep "1" here to not unneccessarily break instances extending the "1" type specifically (instead of "addToAllTypes"). Otherwise, a migration for this could be added too. -
Garvin Hicking commented on patch set 13 11/10/25, 13:13
sys_redirect.php:35Reply("1" as a string, even though looking bad, would technically still work with the varchar column) -
Garvin Hicking voted on patch set 13 V +1 11/10/25, 13:17
-
Oli Bartsch uploaded patch set 14
CR +1V +111/10/25, 13:43 -
Oli Bartsch commented on patch set 14 11/10/25, 13:43
sys_redirect.php:35ReplyDone -
core-ci voted on patch set 14 V +1 11/10/25, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88852
-
Oli Bartsch voted on patch set 14 CR +1 V +1 11/10/25, 13:52
-
Benni Mack commented on patch set 14 11/10/25, 15:20
TcaMigration.php:1847should we merge showitem values?sys_redirect.php:35I personally don't like using constants in TCA (but that's a personal taste) and we tried to avoid this in most places (except PageRepository), mainly because one needs to load the class (PHP class loader) for the string. In addition, I think we're currently mis-using the "Demand" object (which is there for the search in the backend, not even public API), and I'd rather go with "default" -
Oli Bartsch uploaded patch set 15
CR +1V +111/10/25, 15:33 -
Oli Bartsch commented on patch set 15 11/10/25, 15:34
TcaMigration.php:1847ReplyNot necessary. Override is the correct strategy here as it supports both usages `.=` and `=`.sys_redirect.php:35ReplyDone -
core-ci voted on patch set 15 V -1 11/10/25, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88869
-
Benni Mack commented on patch set 15 11/10/25, 15:44
Demand.php:64Replythis falls back to "default" now.sys_redirect.csv:3Reply"default" is now used, better than magic numbers.DemandTest.php:32Replythis falls back to "default" now. -
Oli Bartsch uploaded patch set 16
V -111/10/25, 15:46 -
Oli Bartsch voted on patch set 16 CR +1 V +1 11/10/25, 15:46
-
core-ci voted on patch set 16 V +1 11/10/25, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88872
-
Benni Mack voted on patch set 16 CR +2 V +2 11/10/25, 15:55
-
Benni Mack merged patch set 17 11/10/25, 15:55
sys_redirect.php:61