91406[TASK] Have explicit request handling in PageRenderer
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Helmut Hummel +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 36
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/MovePageController.php+1 −1
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php+1 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/Controller/MfaController.php+1 −1
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+4 −4
- typo3/sysext/backend/Classes/ElementBrowser/DatabaseBrowser.php+1 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+2 −2
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.php+1 −7
- typo3/sysext/core/Classes/Localization/Locale.php+1 −1
- typo3/sysext/core/Classes/Page/ImportMap.php6+42 −42
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+67 −66
- typo3/sysext/core/Classes/Page/PageRenderer.php+188 −117
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-109286-ExplicitRequestHandlingInPageRenderer.rstnew+66 −0
- typo3/sysext/core/Tests/Functional/Page/ImportMapTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Page/JavaScriptRendererTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+34 −46
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+2 −0
Show 16 more files
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+6 −4
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFileBrowser.php+1 −1
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFolderBrowser.php+1 −1
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+1 −1
- typo3/sysext/filelist/Classes/ElementBrowser/FolderBrowser.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/PageRendererViewHelperTest.php+12 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Page/FooterDataViewHelperTest.php+13 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Page/HeaderDataViewHelperTest.php+13 −1
- typo3/sysext/form/Classes/Domain/Finishers/FlashMessageFinisher.php+1 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+3 −4
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+3 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ImageContentObjectTest.php+5 −3
- typo3/sysext/install/Classes/Controller/InstallerController.php+1 −1
- typo3/sysext/install/Classes/Controller/LayoutController.php1+1 −1
- typo3/sysext/redirects/Classes/Service/RedirectService.php+1 −1
Review log 4274
Show 2849 earlier messages
-
Helmut Hummel uploaded patch set 1 11/03/25, 09:31
-
core-ci voted on patch set 1 V +1 11/03/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88352
-
Benjamin Franzke commented on patch set 1 11/03/25, 10:29
ImportMap.php:163This implicitly defines the url prefix to be `/` on CLI. This will break subdir installation cache warmup (If I'm not overseeing things), since all paths will be generated as if the installation is installed into the server document root. -
Helmut Hummel commented on patch set 1 11/03/25, 10:34
ImportMap.php:163Replyok, thanks. I wasn't aware of CLI cache warmup. This then logically means, we can NOT (pre-)generate URLs at all for the cache, or the other way around, we must NOT cache generated URIs -
Helmut Hummel uploaded patch set 2
V +111/03/25, 11:44 -
Helmut Hummel commented on patch set 2 11/03/25, 11:51
ImportMap.php:163Replypatch set 2 deals with that and generates URLs on rendering and puts the resource identifier in cache. to me this makes sense like that and I'd be fine not having a request dependency at all (although I still think it would be cleaner that way, in terms of adhering to the new interface for uri building)LayoutController.php:79as to be seen here, the resolveImport methods has a dependency to request, or at least sitePath, which I added to the API right now as third argument. Imho would make more sense to have it as second and non optional. I'm fine either way -
Helmut Hummel rebased onto patch set 3 11/03/25, 11:52
-
core-ci voted on patch set 2 V -1 11/03/25, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88361
-
core-ci voted on patch set 3 V -1 11/03/25, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88365
-
Helmut Hummel uploaded patch set 4
V -111/03/25, 12:26 -
Helmut Hummel uploaded patch set 5 11/03/25, 12:26
-
Helmut Hummel commented on patch set 5 11/03/25, 12:27
ImportMap.php:126ReplyDoneImportMap.php:163ReplyDone -
core-ci voted on patch set 5 V +1 11/03/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88370
-
core-ci voted on patch set 4 V +1 11/03/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88369
-
Helmut Hummel rebased onto patch set 6
V +111/03/25, 17:52 -
core-ci voted on patch set 6 V -1 11/03/25, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88405
-
Helmut Hummel rebased onto patch set 7
V -111/03/25, 18:42 -
core-ci voted on patch set 7 V +1 11/03/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88411
-
Helmut Hummel rebased onto patch set 8
V +111/03/25, 19:11 -
core-ci voted on patch set 8 V +1 11/03/25, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88414
-
Helmut Hummel marked it work in progress 11/18/25, 11:49
-
Helmut Hummel uploaded patch set 9
V +111/18/25, 12:12 -
core-ci voted on patch set 9 V +1 11/18/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90020
-
Helmut Hummel uploaded patch set 10
V +111/18/25, 19:09 -
core-ci voted on patch set 10 V -1 11/18/25, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90071
-
Helmut Hummel uploaded patch set 11
V -111/19/25, 09:09 -
core-ci voted on patch set 11 V -1 11/19/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90108
-
Helmut Hummel uploaded patch set 12
V -111/19/25, 09:39 -
Helmut Hummel rebased onto patch set 13 11/19/25, 09:39
-
core-ci voted on patch set 13 V -1 11/19/25, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90113
-
core-ci voted on patch set 12 V -1 11/19/25, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90112
-
Helmut Hummel uploaded patch set 14
V -111/19/25, 09:56 -
core-ci voted on patch set 14 V +1 11/19/25, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90117
-
Helmut Hummel uploaded patch set 15
V +111/20/25, 11:32 -
core-ci voted on patch set 15 V +1 11/20/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90270
-
Helmut Hummel uploaded patch set 16
V +112/04/25, 08:08 -
core-ci voted on patch set 16 V -1 12/04/25, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91574
-
Helmut Hummel uploaded patch set 17
V -112/04/25, 08:40 -
core-ci voted on patch set 17 V +1 12/04/25, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91576
-
Helmut Hummel rebased onto patch set 18
V +112/09/25, 23:49 -
core-ci voted on patch set 18 V +1 12/09/25, 23:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91940
-
Christian Kuhn uploaded patch set 19
V +112/10/25, 22:28 -
core-ci voted on patch set 19 V -1 12/10/25, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92029
-
Christian Kuhn uploaded patch set 20
V -103/18/26, 11:03 -
Christian Kuhn uploaded patch set 21 03/18/26, 11:05
-
Christian Kuhn uploaded patch set 22 03/18/26, 11:10
-
Helmut Hummel uploaded patch set 23 03/18/26, 11:25
-
core-ci voted on patch set 20 V -1 03/18/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98161
-
core-ci voted on patch set 22 V -1 03/18/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98167
-
core-ci voted on patch set 23 V -1 03/18/26, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98168
-
core-ci voted on patch set 21 V -1 03/18/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98162
-
Christian Kuhn uploaded patch set 24
V -103/18/26, 12:06 -
Christian Kuhn uploaded patch set 25 03/18/26, 12:12
-
Christian Kuhn uploaded patch set 26 03/18/26, 12:15
-
core-ci voted on patch set 25 V -1 03/18/26, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98180
-
core-ci voted on patch set 26 V -1 03/18/26, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98181
-
Christian Kuhn uploaded patch set 27
V -103/18/26, 13:13 -
core-ci voted on patch set 24 V -1 03/18/26, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98176
-
core-ci voted on patch set 27 V -1 03/18/26, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98189
-
core-ci voted on patch set 27 V +1 03/18/26, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98189
-
Christian Kuhn uploaded patch set 28
V +103/18/26, 13:46 -
Christian Kuhn uploaded patch set 29 03/18/26, 13:56
-
core-ci voted on patch set 28 V -1 03/18/26, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98195
-
core-ci voted on patch set 29 V +1 03/18/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98196
-
Christian Kuhn updated the commit message in patch set 30
V +103/18/26, 14:32 -
core-ci voted on patch set 30 V +1 03/18/26, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98198
-
Christian Kuhn uploaded patch set 31
V +103/18/26, 14:53 -
Christian Kuhn commented on patch set 31 03/18/26, 14:53
This change is ready for review. -
Christian Kuhn voted on patch set 31 CR +1 V +1 03/18/26, 14:57
-
core-ci voted on patch set 31 V +1 03/18/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98203
-
Helmut Hummel voted on patch set 31 CR +1 V +1 03/18/26, 15:27
-
Stefan Bürk voted on patch set 31 CR +1 V +1 03/18/26, 18:05
-
Stefan Bürk voted on patch set 31 CR +2 V +2 03/18/26, 18:05
-
Stefan Bürk merged patch set 32 03/18/26, 18:05
ImportMap.php:126