Review 13.4 Merged

91408[BUGFIX] Define height for modal size "small"

Oli Bartsch CR +2 V +2 Easy +7 −0 updated 11/03/25, 13:08

Commit message

Currently, when opening a modal of size "small"
using the iframe type, the modal height is 0px

This has been fixed by defining css height when an
iframe is used.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Oli Bartsch uploaded patch set 1 11/03/25, 11:16

  2. core-ci voted on patch set 1 V +1 11/03/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88360

  3. Benjamin Franzke uploaded patch set 2 V +1 11/03/25, 12:53

  4. Benjamin Franzke commented on patch set 2 11/03/25, 12:53

    _modal.scss:251

    I guess you already noticed, but I just wanted to state that this does not work as-is in v13, since v13 does not use the `typo3-` prefix for modal variables.
  5. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 11/03/25, 12:54

  6. core-ci voted on patch set 2 V +1 11/03/25, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88376

  7. core-ci voted on patch set 3 V +1 11/03/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88377

  8. Benjamin Franzke merged patch set 4 11/03/25, 13:08