Review main Abandoned

91413[WIP][TASK] Avoid CSS Nano errors due to usage of calc()

Benni Mack CR -1 V -1 Hard +255 −277 updated 11/03/25, 17:12

Commit message

Review

  • Code review CR -1
    • Benjamin Franzke -1
  • Verified V -1
    • core-ci -1 CI

Files 8

Review log 67

  1. Benni Mack uploaded patch set 1 11/03/25, 16:57

  2. Benjamin Franzke commented on patch set 1 CR -1 11/03/25, 16:59

    Yes, this avoids the warnings, but also disabled all optimizations for those `calc()` statements that are understood. We should keep them, even if the situation is not nice.
  3. Benjamin Franzke commented on patch set 1 11/03/25, 17:02

    Reply

    So if this is blocking someone and to be constructive (😜), we should try to add "ignore" statements… I haven't looked up how that works in this case, but still wanted to mention that as a possibility.
  4. core-ci voted on patch set 1 V -1 11/03/25, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88402

  5. Benni Mack commented on patch set 1 11/03/25, 17:07

    Reply

    The reason why I created it: Well, it shows up every time when I build the CSS with " Lexical error on line 1: Unrecognized text." so I assume this is an error, I'd like to have no errors when handling CSS. I had 10 contributors last week where I told them "Yes, there are errors, but don't look at it too closely, this is "normal" makes it hard to teach them when there is an error they should look out to, or errors we should keep.
  6. Benni Mack abandoned the change 11/03/25, 17:07

  7. Benjamin Franzke commented on patch set 1 11/03/25, 17:12

    Reply

    Yup, I see and agree with the hurdle . Therefore I wrote: > we should try to add "ignore" statements