Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

91414[TASK] Generalize component conversion of button to dropdown item

Ayke Halder CR 0 V 0 Normal +119 −30 updated 11/03/25, 19:23

Commit message

This implements "visitor pattern" for button component.

This refactors the button to dropdown item conversion to use the new
"visitor".

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/91414/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/91414/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 91414 [TASK] Generalize component conversion of button to dropdown item This change

  2. main 91386[TASK] Only use GenericButton when needed, prefer Input/LinkButton This change is based on it Merged Garvin Hicking CR +2 V +2 Normal +31 −42

    The chain has patch set 8 of 11, the changes above it need a rebase.

Files 6

Review log 36

  1. Ayke Halder uploaded patch set 1 11/03/25, 17:38

  2. core-ci voted on patch set 1 V -1 11/03/25, 17:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88403

  3. Ayke Halder uploaded patch set 2 V -1 11/03/25, 18:50

  4. core-ci voted on patch set 2 V -1 11/03/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88412

  5. Ayke Halder uploaded patch set 3 V -1 11/03/25, 19:13

  6. core-ci voted on patch set 3 V +1 11/03/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88415