Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
91414[TASK] Generalize component conversion of button to dropdown item
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/91414/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/91414/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
91414 [TASK] Generalize component conversion of button to dropdown item This change
-
main
91386[TASK] Only use GenericButton when needed, prefer Input/LinkButton
The chain has patch set 8 of 11, the changes above it need a rebase.
Files 6
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+5 −28
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItemConversionVisitor.phpnew+55 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/ButtonVisitableInterface.phpnew+23 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/ButtonVisitorInterface.phpnew+24 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php+6 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+6 −1
Review log 36
-
Ayke Halder uploaded patch set 1 11/03/25, 17:38
-
core-ci voted on patch set 1 V -1 11/03/25, 17:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88403
-
Ayke Halder uploaded patch set 2
V -111/03/25, 18:50 -
core-ci voted on patch set 2 V -1 11/03/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88412
-
Ayke Halder uploaded patch set 3
V -111/03/25, 19:13 -
core-ci voted on patch set 3 V +1 11/03/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88415