Review main Merged

91416[TASK] Declare private properties in final classes

Simon Schaufelberger CR +2 V +2 Hard +329 −309 updated 12/10/25, 06:44

Commit message

The patch declares the majority of properties and
constants of final classes private, partially methods
as well. Some more edgy cases are left out for now.
Doing this is technically kinda irrelevant but can
help IDE's to find unused properties and methods more
easily. phpstan is also a bit more picky, a couple of
entries are added and coupled with some @todo comments
in the codebase. The patch comes with minor adaptions
like slightly improved DI and similar.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 93

Show 73 more files

Review log 2029

Show 24 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 11/03/25, 22:58

  2. core-ci voted on patch set 1 V -1 11/03/25, 23:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88420

  3. Simon Schaufelberger uploaded patch set 2 V -1 11/03/25, 23:20

  4. core-ci voted on patch set 2 V -1 11/03/25, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88421

  1. Simon Schaufelberger uploaded patch set 3 V -1 11/04/25, 00:02

  2. core-ci voted on patch set 3 V +1 11/04/25, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88423

  3. Simon Schaufelberger uploaded patch set 4 V +1 11/04/25, 00:32

  4. Simon Schaufelberger marked it work in progress 11/04/25, 01:16

  5. Simon Schaufelberger uploaded patch set 5 12/09/25, 17:30

  6. core-ci voted on patch set 5 V -1 12/09/25, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91921

  7. Simon Schaufelberger uploaded patch set 6 V -1 12/09/25, 19:14

  8. core-ci voted on patch set 6 V +1 12/09/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91926

  9. Simon Schaufelberger commented on patch set 6 12/09/25, 21:07

    This change is ready for review.
  10. Christian Kuhn uploaded patch set 7 V +1 12/09/25, 22:24

  11. Christian Kuhn commented on patch set 7 12/09/25, 22:25

    PreviewProcessing.php:30

    i actually tend to keep the interface. benni probably added this by intention to make it obvious this class is a processor as well, even though localImage is one already.
  12. core-ci voted on patch set 7 V +1 12/09/25, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91934

  13. Christian Kuhn uploaded patch set 8 V +1 12/09/25, 22:44

  14. Christian Kuhn uploaded patch set 9 12/09/25, 22:48

  15. core-ci voted on patch set 8 V +1 12/09/25, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91935

  16. core-ci voted on patch set 9 V +1 12/09/25, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91936

  17. Christian Kuhn voted on patch set 9 CR +1 V +1 12/09/25, 22:59

  18. Oliver Klee voted on patch set 9 CR +1 V +1 12/09/25, 23:22

  19. Christian Kuhn updated the commit message in patch set 10 CR +1 V +1 12/09/25, 23:52

  20. Christian Kuhn voted on patch set 10 CR +1 V +1 12/09/25, 23:52

  21. Simon Schaufelberger commented on patch set 10 12/09/25, 23:55

    maybe side adaptions?
  22. Simon Schaufelberger commented on patch set 10 12/09/25, 23:55

    Reply

    Done
  23. core-ci voted on patch set 10 V +1 12/10/25, 00:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91941

  24. Stefan Bürk voted on patch set 10 CR +2 V +2 12/10/25, 06:44

  25. Stefan Bürk merged patch set 11 12/10/25, 06:44