91416[TASK] Declare private properties in final classes
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 93
- Build/phpstan/phpstan-baseline.neon+42 −0
- typo3/sysext/backend/Classes/Controller/Event/ModifyAllowedItemsEvent.php+2 −2
- typo3/sysext/backend/Classes/Controller/Event/ModifyLinkHandlersEvent.php+2 −2
- typo3/sysext/backend/Classes/Controller/LinkController.php+3 −3
- typo3/sysext/backend/Classes/Controller/SubmoduleOverviewController.php+5 −11
- typo3/sysext/backend/Classes/EventListener/FailedLoginAttemptNotification.php+3 −3
- typo3/sysext/backend/Classes/EventListener/FailedMfaAttemptNotification.php+2 −2
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+4 −4
- typo3/sysext/backend/Classes/Search/EventListener/AddLiveSearchResultActionsListener.php+8 −12
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+21 −21
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+11 −11
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchRepository.php+3 −3
- typo3/sysext/backend/Classes/Security/SudoMode/Exception/RequestGrantedException.php+1 −1
- typo3/sysext/backend/Classes/Security/SudoMode/Exception/VerificationRequiredException.php+1 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+13 −13
- typo3/sysext/backend/Classes/View/BackendViewFactory.php+2 −2
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+10 −10
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+4 −4
- typo3/sysext/core/Classes/Configuration/Event/SiteConfigurationBeforeWriteEvent.php+2 −2
- typo3/sysext/core/Classes/Configuration/Event/SiteConfigurationLoadedEvent.php+2 −2
Show 73 more files
- typo3/sysext/core/Classes/Core/Event/BootCompletedEvent.php+2 −1
- typo3/sysext/core/Classes/Country/CountryFilter.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/Identifier.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/MfaProviderPass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/SoftReferenceParserPass.php+1 −1
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php+2 −2
- typo3/sysext/core/Classes/Page/JavaScriptItems.php+2 −2
- typo3/sysext/core/Classes/Pagination/SimplePagination.php+1 −4
- typo3/sysext/core/Classes/Pagination/SlidingWindowPagination.php+6 −6
- typo3/sysext/core/Classes/PasswordPolicy/Event/EnrichPasswordValidationContextDataEvent.php+3 −3
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php1+2 −2
- typo3/sysext/core/Classes/Schema/Capability/FieldCapability.php+1 −1
- typo3/sysext/core/Classes/Schema/Capability/LabelCapability.php+4 −4
- typo3/sysext/core/Classes/Schema/Capability/LanguageAwareSchemaCapability.php+4 −4
- typo3/sysext/core/Classes/Schema/Capability/RootLevelCapability.php+2 −2
- typo3/sysext/core/Classes/Schema/Capability/ScalarCapability.php+2 −1
- typo3/sysext/core/Classes/Schema/Capability/SystemInternalFieldCapability.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/CategoryFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/FieldCollection.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/FileFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/GroupFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/InlineFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/Field/SelectRelationFieldType.php+1 −1
- typo3/sysext/core/Classes/Schema/Struct/FlexSectionContainer.php+5 −4
- typo3/sysext/core/Classes/Schema/Struct/FlexSheet.php+6 −5
- typo3/sysext/core/Classes/Schema/ActiveRelation.php+2 −2
- typo3/sysext/core/Classes/Schema/FlexFormSchema.php+2 −2
- typo3/sysext/core/Classes/Schema/FlexFormSchemaFactory.php+3 −3
- typo3/sysext/core/Classes/Schema/PassiveRelation.php+3 −3
- typo3/sysext/core/Classes/Schema/RelationMap.php+1 −1
- typo3/sysext/core/Classes/Schema/SchemaCollection.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineStream.php+1 −1
- typo3/sysext/dashboard/Classes/DashboardEntry.php+2 −2
- typo3/sysext/extbase/Classes/Event/Configuration/BeforeFlexFormConfigurationOverrideEvent.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/BindVariableValue.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Comparison.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/EquiJoinCondition.php+4 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LogicalAnd.php+4 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LogicalNot.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LogicalOr.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LowerCase.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Ordering.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/PropertyValue.php+4 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Statement.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/UpperCase.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_data_mapper/Classes/Domain/Model/ConstructorPromotionExample.php+8 −8
- typo3/sysext/extensionmanager/Classes/Updates/ExtensionModel.php+5 −5
- typo3/sysext/felogin/Classes/Event/LoginErrorOccurredEvent.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/FinisherVariableProvider.php+1 −1
- typo3/sysext/form/Classes/Event/BeforeEmailFinisherInitializedEvent.php+2 −2
- typo3/sysext/form/Classes/Mvc/Property/Exception/TypeConverterException.php+1 −1
- typo3/sysext/form/Classes/Slot/FilePersistenceSlot.php+1 −1
- typo3/sysext/frontend/Classes/Event/ModifyPageLinkConfigurationEvent.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/TimeTrackerInitialization.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageAccessFailureReasons.php+1 −1
- typo3/sysext/impexp/Classes/Domain/Repository/PresetRepository.php+13 −22
- typo3/sysext/indexed_search/Classes/Pagination/SlicePaginator.php+2 −2
- typo3/sysext/indexed_search/Tests/Functional/Upgrades/IndexedSearchCTypeMigrationTest.php+0 −3
- typo3/sysext/install/Classes/Command/PasswordSetCommand.php+3 −3
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/ProviderRegistry.php+1 −1
- typo3/sysext/lowlevel/Classes/DependencyInjection/ConfigurationModuleProviderPass.php+1 −1
- typo3/sysext/redirects/Classes/EventListener/IncrementHitCount.php+2 −7
- typo3/sysext/reports/Classes/Controller/RecordStatisticsController.php+3 −3
- typo3/sysext/reports/Classes/Controller/StatusReportController.php+2 −2
- typo3/sysext/reports/Classes/Service/RecordStatisticsService.php+3 −3
- typo3/sysext/reports/Classes/Service/StatusService.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+21 −23
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineFalSelectSingle12Foreign.php+1 −1
- typo3/sysext/sys_note/Classes/Provider/ButtonBarProvider.php+10 −10
- typo3/sysext/sys_note/Classes/Provider/InfoModuleProvider.php+2 −2
- typo3/sysext/sys_note/Classes/Provider/PageModuleProvider.php+2 −2
Review log 2029
Show 24 earlier messages
-
Simon Schaufelberger uploaded patch set 1 11/03/25, 22:58
-
core-ci voted on patch set 1 V -1 11/03/25, 23:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88420
-
Simon Schaufelberger uploaded patch set 2
V -111/03/25, 23:20 -
core-ci voted on patch set 2 V -1 11/03/25, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88421
-
Simon Schaufelberger uploaded patch set 3
V -111/04/25, 00:02 -
core-ci voted on patch set 3 V +1 11/04/25, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88423
-
Simon Schaufelberger uploaded patch set 4
V +111/04/25, 00:32 -
Simon Schaufelberger marked it work in progress 11/04/25, 01:16
-
Simon Schaufelberger uploaded patch set 5 12/09/25, 17:30
-
core-ci voted on patch set 5 V -1 12/09/25, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91921
-
Simon Schaufelberger uploaded patch set 6
V -112/09/25, 19:14 -
core-ci voted on patch set 6 V +1 12/09/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91926
-
Simon Schaufelberger commented on patch set 6 12/09/25, 21:07
This change is ready for review. -
Christian Kuhn uploaded patch set 7
V +112/09/25, 22:24 -
Christian Kuhn commented on patch set 7 12/09/25, 22:25
PreviewProcessing.php:30i actually tend to keep the interface. benni probably added this by intention to make it obvious this class is a processor as well, even though localImage is one already. -
core-ci voted on patch set 7 V +1 12/09/25, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91934
-
Christian Kuhn uploaded patch set 8
V +112/09/25, 22:44 -
Christian Kuhn uploaded patch set 9 12/09/25, 22:48
-
core-ci voted on patch set 8 V +1 12/09/25, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91935
-
core-ci voted on patch set 9 V +1 12/09/25, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91936
-
Christian Kuhn voted on patch set 9 CR +1 V +1 12/09/25, 22:59
-
Oliver Klee voted on patch set 9 CR +1 V +1 12/09/25, 23:22
-
Christian Kuhn updated the commit message in patch set 10
CR +1V +112/09/25, 23:52 -
Christian Kuhn voted on patch set 10 CR +1 V +1 12/09/25, 23:52
-
Simon Schaufelberger commented on patch set 10 12/09/25, 23:55
maybe side adaptions? -
Simon Schaufelberger commented on patch set 10 12/09/25, 23:55
Reply
Done -
core-ci voted on patch set 10 V +1 12/10/25, 00:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91941
-
Stefan Bürk voted on patch set 10 CR +2 V +2 12/10/25, 06:44
-
Stefan Bürk merged patch set 11 12/10/25, 06:44