91417[FEATURE] Improved DocHeader layout
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 49
- Build/tests/playwright/e2e/open-in-new-window-language-switching.spec.ts2+18 −22
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+49 −15
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+144 −41
- typo3/sysext/backend/Classes/Controller/RecordListController.php+150 −128
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+40 −12
- typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php+18 −0
- typo3/sysext/backend/Classes/Template/Components/DocHeaderComponent.php2+67 −3
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php2+38 −38
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+0 −78
- typo3/sysext/backend/Resources/Private/Partials/Menus/SelectBoxJumpMenu.htmldeleted+0 −15
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+0 −11
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.html+6 −13
- typo3/sysext/backend/Resources/Private/Templates/RecordList.html+0 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.php+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.php+1 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.php+1 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst6new+224 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+15 −3
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListGroupCest.php+4 −1
Show 29 more files
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php+4 −1
- typo3/sysext/core/Tests/Acceptance/Application/ConfigurationModule/ConfigurationModuleProviderCest.php+7 −2
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/GetExtensionsCest.php+4 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+3 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+10 −5
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+6 −4
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/ContentElementsCest.php+5 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FormFrameworkCest.php+5 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FrontendLoginCest.php+5 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/IndexedSearchCest.php+5 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/SitemapXmlCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+11 −5
- typo3/sysext/core/Tests/Acceptance/Application/IndexedSearch/IndexedSearchModuleCest.php+20 −5
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/DatabaseRecordListCest.php+16 −10
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/RecordDownloadWithPresetCest.php+6 −3
- typo3/sysext/core/Tests/Acceptance/Application/Redirect/RedirectModuleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Report/ReportModuleCest.php+4 −1
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+47 −18
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.php+2 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+0 −2
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+0 −2
- typo3/sysext/reports/Classes/Controller/RecordStatisticsController.php+0 −5
- typo3/sysext/reports/Classes/Controller/StatusReportController.php+0 −5
- typo3/sysext/styleguide/Classes/Controller/ComponentsController.php+0 −3
- typo3/sysext/styleguide/Classes/Controller/PageTreesController.php+0 −3
- typo3/sysext/styleguide/Classes/Controller/StylesController.php+0 −3
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+0 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+20 −16
- typo3/sysext/webhooks/Classes/Controller/ManagementController.php+0 −3
Review log 5485
Show 3560 earlier messages
-
Oli Bartsch uploaded patch set 1 11/03/25, 23:22
-
core-ci voted on patch set 1 V -1 11/03/25, 23:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88422
-
Oli Bartsch updated the commit message in patch set 2
V -111/04/25, 00:28 -
core-ci voted on patch set 2 V -1 11/04/25, 00:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88424
-
Oli Bartsch uploaded patch set 3
V -111/04/25, 09:13 -
core-ci voted on patch set 3 V -1 11/04/25, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88443
-
Oli Bartsch uploaded patch set 4
V -111/04/25, 09:39 -
Oli Bartsch uploaded patch set 5 11/04/25, 09:41
-
core-ci voted on patch set 4 V -1 11/04/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88446
-
core-ci voted on patch set 5 V -1 11/04/25, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88447
-
Oli Bartsch uploaded patch set 6
V -111/04/25, 10:58 -
Oli Bartsch updated the commit message in patch set 7 11/04/25, 10:59
-
core-ci voted on patch set 6 V -1 11/04/25, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88454
-
core-ci voted on patch set 7 V -1 11/04/25, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88455
-
Oli Bartsch uploaded patch set 8
V -111/04/25, 16:56 -
core-ci voted on patch set 8 V -1 11/04/25, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88472
-
Garvin Hicking updated the commit message in patch set 9
V -111/04/25, 19:27 -
core-ci voted on patch set 9 V -1 11/04/25, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88478
-
Oli Bartsch uploaded patch set 10
V -111/04/25, 20:59 -
core-ci voted on patch set 10 V +1 11/04/25, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88481
-
Benni Mack updated the commit message in patch set 11
V +111/05/25, 10:40 -
core-ci voted on patch set 11 V +1 11/05/25, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88503
-
Oli Bartsch uploaded patch set 12
V +111/05/25, 10:48 -
core-ci voted on patch set 12 V -1 11/05/25, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88504
-
Oli Bartsch commented on patch set 13
V -111/05/25, 11:02Published edit on patch set 12. -
Benni Mack commented on patch set 12 11/05/25, 11:11
open-in-new-window-language-switching.spec.ts:13I'm usually in favor of "name: 'Display Mode'" - now we have some inconsistencies here. -
core-ci voted on patch set 13 V +1 11/05/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88507
-
Oli Bartsch uploaded patch set 14
V +111/05/25, 11:46 -
Oli Bartsch uploaded patch set 15 11/05/25, 11:46
-
Oli Bartsch commented on patch set 15 11/05/25, 11:47
open-in-new-window-language-switching.spec.ts:13ReplyDone -
core-ci voted on patch set 14 V -1 11/05/25, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88512
-
core-ci voted on patch set 15 V +1 11/05/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88513
-
Lina Wolf commented on patch set 15 V +1 11/05/25, 12:17
I tried implementing this in t3docs/example and after some trying managed to do it. I marked some points in the rst that made it harder for me to do so then neccessary. I also tested the dropdown in all modules where it is already integrated and it worked well. I didnt see anything in code review but I am not very deep into these topics, so no vote.Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:180Where do we get the $existingLanguageItems from?Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:189we must mention the type of $this->componentFactoryFeature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:192Can we use the new short syntax for label references? -
Oli Bartsch uploaded patch set 16
V +111/05/25, 14:17 -
Oli Bartsch commented on patch set 16 11/05/25, 14:18
Reply
Thanks for testing!Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:180ReplyDoneFeature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:189ReplyDoneFeature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:192ReplyPlease see my anwser in the page tree patch. We are still working on the new API and we can update / adjust v14 changelogs once this is stable. -
Lina Wolf voted on patch set 16 V +1 11/05/25, 14:19
-
core-ci voted on patch set 16 V +1 11/05/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88523
-
Benjamin Franzke commented on patch set 16 CR -1 11/06/25, 09:28
Let's extract this shared module data functionality into a separate patch. This has a) nothing to do with an improved layout and b) we need to discuss if the concept to share module data is correct, or if we should introduce global state instead: Usecases are: Should modals use this context? If so, then this is not just a module context. I don't want to block this, but I think it's better to separate that. -
Benjamin Kott uploaded patch set 17
CR -1V +111/06/25, 11:53 -
Benjamin Kott uploaded patch set 18 11/06/25, 11:58
-
core-ci voted on patch set 17 V -1 11/06/25, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88565
-
core-ci voted on patch set 18 V -1 11/06/25, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88566
-
Benjamin Kott uploaded patch set 19
V -111/06/25, 12:31 -
core-ci voted on patch set 19 V -1 11/06/25, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88568
-
Benjamin Kott uploaded patch set 20
V -111/06/25, 12:46 -
Benjamin Kott uploaded patch set 21 11/06/25, 12:54
-
Benjamin Kott uploaded patch set 22 11/06/25, 12:56
-
Benjamin Kott uploaded patch set 23 11/06/25, 12:58
-
core-ci voted on patch set 20 V -1 11/06/25, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88569
-
Benjamin Kott commented on patch set 23 11/06/25, 13:02
Reply
DoneModuleTemplate.php:385feels fishy -
Benjamin Kott uploaded patch set 24 11/06/25, 13:04
-
core-ci voted on patch set 21 V -1 11/06/25, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88571
-
core-ci voted on patch set 22 V -1 11/06/25, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88572
-
core-ci voted on patch set 23 V -1 11/06/25, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88573
-
core-ci voted on patch set 24 V -1 11/06/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88574
-
Benjamin Kott uploaded patch set 25
V -111/06/25, 13:48 -
core-ci voted on patch set 25 V +1 11/06/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88577
-
Benjamin Kott commented on patch set 25 11/06/25, 13:59
DocHeaderComponent.php:296breaking? -
Benjamin Kott uploaded patch set 26
V +111/06/25, 16:32 -
Benjamin Kott commented on patch set 26 11/06/25, 16:32
DocHeaderComponent.php:296ReplyDoneModuleTemplate.php:385ReplyDone
-
core-ci voted on patch set 26 V -1 11/06/25, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88592
-
Benjamin Kott uploaded patch set 27
V -111/06/25, 16:46 -
Benjamin Kott voted on patch set 27 CR +1 V +1 11/06/25, 16:47
-
core-ci voted on patch set 27 V +1 11/06/25, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88595
-
Georg Ringer voted on patch set 27 CR +1 V +1 11/06/25, 22:30
-
Benjamin Kott voted on patch set 27 CR +2 V +2 11/07/25, 06:29
-
Benjamin Kott voted on patch set 27 CR +1 V +1 11/07/25, 06:29
-
Benjamin Kott updated the commit message in patch set 28
CR +1V +111/07/25, 06:29 -
Benjamin Kott voted on patch set 28 CR +1 V +1 11/07/25, 06:29
-
core-ci voted on patch set 28 V +1 11/07/25, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88619
-
Andreas Kienast commented on patch set 28 CR -1 11/07/25, 07:06
Found a minor issue: when I'm in a page with translations, I can choose between "Layout" and "Language Comparison". If I use "Language Comparison" and _then_ switch to a page of type "Folder", I have the dropdown labelled as "Display mode" where I can only choose from "Layout". -
Andreas Kienast uploaded patch set 29
CR +1V +111/07/25, 07:15 -
Andreas Kienast commented on patch set 29 11/07/25, 07:16
Reply
Done -
Andreas Kienast voted on patch set 29 CR +1 V +1 11/07/25, 07:16
-
core-ci voted on patch set 29 V +1 11/07/25, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88620
-
Oli Bartsch commented on patch set 29 V -1 11/07/25, 08:26
Reviewing. -
Oli Bartsch uploaded patch set 30
CR +1V +111/07/25, 08:33 -
Oli Bartsch commented on patch set 30 CR +1 V +1 11/07/25, 08:33
Reply
Done -
Benjamin Kott commented on patch set 31
CR +1V +111/07/25, 08:39Published edit on patch set 30. -
core-ci voted on patch set 30 V +1 11/07/25, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88629
-
Benjamin Kott voted on patch set 31 CR +1 V +1 11/07/25, 08:41
-
Andreas Kienast voted on patch set 31 CR +1 V +1 11/07/25, 08:41
-
core-ci voted on patch set 31 V +1 11/07/25, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88630
-
Benjamin Kott voted on patch set 31 CR +2 V +2 11/07/25, 08:55
-
Benjamin Kott merged patch set 32 11/07/25, 08:55