Review main Merged

91417[FEATURE] Improved DocHeader layout

Oli Bartsch CR +2 V +2 Expert +965 −495 updated 11/07/25, 08:55

Commit message

The backend document header has been reorganized
to provide a more consistent and intuitive user
experience across all modules.

A unified language selector is now available in
the top-right area across all modules, allowing
direct page translation creation. The selector
displays the currently selected language as the
button text with a descriptive "Language:" prefix
for screen readers. Languages are organized with
existing translations shown first, followed by a
section for languages that can be created.

The module actions menu is consistently displayed
as a dropdown in the button bar, showing the
currently active module or action as the button
text. Descriptive labels provide screen reader
context (e.g., "Display mode:" for the page module,
"Module actions" for module navigation). The
dropdown is automatically hidden when only one
action is available.

The layout has been reorganized with breadcrumb
navigation on the left and language selector on
the right. Redundant back buttons have been
removed in favor of breadcrumb navigation.

Dropdown buttons support displaying active item
labels through setShowActiveLabelText(). When enabled
with setShowLabelText(true), the dropdown's label is
rendered in a visually-hidden span followed by the
active item's label, ensuring screen readers announce
both the dropdown's purpose and the current selection
(e.g., "Language: English"). When setShowLabelText(false),
accessibility is provided through aria-label and title
attributes instead.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 49

Show 29 more files

Review log 5485

Show 3560 earlier messages
  1. Oli Bartsch uploaded patch set 1 11/03/25, 23:22

  2. core-ci voted on patch set 1 V -1 11/03/25, 23:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88422

  3. Oli Bartsch updated the commit message in patch set 2 V -1 11/04/25, 00:28

  4. core-ci voted on patch set 2 V -1 11/04/25, 00:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88424

  5. Oli Bartsch uploaded patch set 3 V -1 11/04/25, 09:13

  6. core-ci voted on patch set 3 V -1 11/04/25, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88443

  7. Oli Bartsch uploaded patch set 4 V -1 11/04/25, 09:39

  8. Oli Bartsch uploaded patch set 5 11/04/25, 09:41

  9. core-ci voted on patch set 4 V -1 11/04/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88446

  10. core-ci voted on patch set 5 V -1 11/04/25, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88447

  11. Oli Bartsch uploaded patch set 6 V -1 11/04/25, 10:58

  12. Oli Bartsch updated the commit message in patch set 7 11/04/25, 10:59

  13. core-ci voted on patch set 6 V -1 11/04/25, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88454

  14. core-ci voted on patch set 7 V -1 11/04/25, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88455

  15. Oli Bartsch uploaded patch set 8 V -1 11/04/25, 16:56

  16. core-ci voted on patch set 8 V -1 11/04/25, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88472

  17. Garvin Hicking updated the commit message in patch set 9 V -1 11/04/25, 19:27

  18. core-ci voted on patch set 9 V -1 11/04/25, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88478

  19. Oli Bartsch uploaded patch set 10 V -1 11/04/25, 20:59

  20. core-ci voted on patch set 10 V +1 11/04/25, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88481

  21. Benni Mack updated the commit message in patch set 11 V +1 11/05/25, 10:40

  22. core-ci voted on patch set 11 V +1 11/05/25, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88503

  23. Oli Bartsch uploaded patch set 12 V +1 11/05/25, 10:48

  24. core-ci voted on patch set 12 V -1 11/05/25, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88504

  25. Oli Bartsch commented on patch set 13 V -1 11/05/25, 11:02

    Published edit on patch set 12.
  26. Benni Mack commented on patch set 12 11/05/25, 11:11

    open-in-new-window-language-switching.spec.ts:13

    I'm usually in favor of "name: 'Display Mode'" - now we have some inconsistencies here.
  27. core-ci voted on patch set 13 V +1 11/05/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88507

  28. Oli Bartsch uploaded patch set 14 V +1 11/05/25, 11:46

  29. Oli Bartsch uploaded patch set 15 11/05/25, 11:46

  30. Oli Bartsch commented on patch set 15 11/05/25, 11:47

    open-in-new-window-language-switching.spec.ts:13 Reply

    Done
  31. core-ci voted on patch set 14 V -1 11/05/25, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88512

  32. core-ci voted on patch set 15 V +1 11/05/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88513

  33. Lina Wolf commented on patch set 15 V +1 11/05/25, 12:17

    I tried implementing this in t3docs/example and after some trying managed to do it. I marked some points in the rst that made it harder for me to do so then neccessary. I also tested the dropdown in all modules where it is already integrated and it worked well. I didnt see anything in code review but I am not very deep into these topics, so no vote.

    Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:180

    Where do we get the $existingLanguageItems from?

    Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:189

    we must mention the type of $this->componentFactory

    Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:192

    Can we use the new short syntax for label references?
  34. Oli Bartsch uploaded patch set 16 V +1 11/05/25, 14:17

  35. Oli Bartsch commented on patch set 16 11/05/25, 14:18

    Reply

    Thanks for testing!

    Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:180 Reply

    Done

    Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:189 Reply

    Done

    Feature-107875-ImprovedDocHeaderLayoutAndUnifiedLanguageSelector.rst:192 Reply

    Please see my anwser in the page tree patch. We are still working on the new API and we can update / adjust v14 changelogs once this is stable.
  36. Lina Wolf voted on patch set 16 V +1 11/05/25, 14:19

  37. core-ci voted on patch set 16 V +1 11/05/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88523

  38. Benjamin Franzke commented on patch set 16 CR -1 11/06/25, 09:28

    Let's extract this shared module data functionality into a separate patch. This has a) nothing to do with an improved layout and b) we need to discuss if the concept to share module data is correct, or if we should introduce global state instead: Usecases are: Should modals use this context? If so, then this is not just a module context. I don't want to block this, but I think it's better to separate that.
  39. Benjamin Kott uploaded patch set 17 CR -1 V +1 11/06/25, 11:53

  40. Benjamin Kott uploaded patch set 18 11/06/25, 11:58

  41. core-ci voted on patch set 17 V -1 11/06/25, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88565

  42. core-ci voted on patch set 18 V -1 11/06/25, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88566

  43. Benjamin Kott uploaded patch set 19 V -1 11/06/25, 12:31

  44. core-ci voted on patch set 19 V -1 11/06/25, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88568

  45. Benjamin Kott uploaded patch set 20 V -1 11/06/25, 12:46

  46. Benjamin Kott uploaded patch set 21 11/06/25, 12:54

  47. Benjamin Kott uploaded patch set 22 11/06/25, 12:56

  48. Benjamin Kott uploaded patch set 23 11/06/25, 12:58

  49. core-ci voted on patch set 20 V -1 11/06/25, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88569

  50. Benjamin Kott commented on patch set 23 11/06/25, 13:02

    Reply

    Done

    ModuleTemplate.php:385

    feels fishy
  51. Benjamin Kott uploaded patch set 24 11/06/25, 13:04

  52. core-ci voted on patch set 21 V -1 11/06/25, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88571

  53. core-ci voted on patch set 22 V -1 11/06/25, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88572

  54. core-ci voted on patch set 23 V -1 11/06/25, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88573

  55. core-ci voted on patch set 24 V -1 11/06/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88574

  56. Benjamin Kott uploaded patch set 25 V -1 11/06/25, 13:48

  57. core-ci voted on patch set 25 V +1 11/06/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88577

  58. Benjamin Kott commented on patch set 25 11/06/25, 13:59

    DocHeaderComponent.php:296

    breaking?
  59. Benjamin Kott uploaded patch set 26 V +1 11/06/25, 16:32

  60. Benjamin Kott commented on patch set 26 11/06/25, 16:32

    DocHeaderComponent.php:296 Reply

    Done

    ModuleTemplate.php:385 Reply

    Done
  1. core-ci voted on patch set 26 V -1 11/06/25, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88592

  2. Benjamin Kott uploaded patch set 27 V -1 11/06/25, 16:46

  3. Benjamin Kott voted on patch set 27 CR +1 V +1 11/06/25, 16:47

  4. core-ci voted on patch set 27 V +1 11/06/25, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88595

  5. Georg Ringer voted on patch set 27 CR +1 V +1 11/06/25, 22:30

  6. Benjamin Kott voted on patch set 27 CR +2 V +2 11/07/25, 06:29

  7. Benjamin Kott voted on patch set 27 CR +1 V +1 11/07/25, 06:29

  8. Benjamin Kott updated the commit message in patch set 28 CR +1 V +1 11/07/25, 06:29

  9. Benjamin Kott voted on patch set 28 CR +1 V +1 11/07/25, 06:29

  10. core-ci voted on patch set 28 V +1 11/07/25, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88619

  11. Andreas Kienast commented on patch set 28 CR -1 11/07/25, 07:06

    Found a minor issue: when I'm in a page with translations, I can choose between "Layout" and "Language Comparison". If I use "Language Comparison" and _then_ switch to a page of type "Folder", I have the dropdown labelled as "Display mode" where I can only choose from "Layout".
  12. Andreas Kienast uploaded patch set 29 CR +1 V +1 11/07/25, 07:15

  13. Andreas Kienast commented on patch set 29 11/07/25, 07:16

    Reply

    Done
  14. Andreas Kienast voted on patch set 29 CR +1 V +1 11/07/25, 07:16

  15. core-ci voted on patch set 29 V +1 11/07/25, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88620

  16. Oli Bartsch commented on patch set 29 V -1 11/07/25, 08:26

    Reviewing.
  17. Oli Bartsch uploaded patch set 30 CR +1 V +1 11/07/25, 08:33

  18. Oli Bartsch commented on patch set 30 CR +1 V +1 11/07/25, 08:33

    Reply

    Done
  19. Benjamin Kott commented on patch set 31 CR +1 V +1 11/07/25, 08:39

    Published edit on patch set 30.
  20. core-ci voted on patch set 30 V +1 11/07/25, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88629

  21. Benjamin Kott voted on patch set 31 CR +1 V +1 11/07/25, 08:41

  22. Andreas Kienast voted on patch set 31 CR +1 V +1 11/07/25, 08:41

  23. core-ci voted on patch set 31 V +1 11/07/25, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88630

  24. Benjamin Kott voted on patch set 31 CR +2 V +2 11/07/25, 08:55

  25. Benjamin Kott merged patch set 32 11/07/25, 08:55