91419[!!!][BUGFIX] Allow rootless paths in URI implementation
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Oliver Klee +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.php+6 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+7 −1
- typo3/sysext/backend/Tests/Functional/Middleware/BackendModuleValidatorTest.php+6 −1
- typo3/sysext/core/Classes/Http/Uri.php+18 −5
- typo3/sysext/core/Classes/Page/ImportMap.php+3 −3
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Classes/Utility/PathUtility.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-108084-UrlRepresenttionRootlessPaths.rstnew+65 −0
- typo3/sysext/core/Tests/Functional/SystemResource/Publishing/DefaultResourcePublisherTest.php+30 −0
- typo3/sysext/core/Tests/Unit/Http/UriTest.php4+61 −13
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/UriValueTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+3 −1
Review log 2438
Show 713 earlier messages
-
Helmut Hummel uploaded patch set 1 11/04/25, 09:34
-
core-ci voted on patch set 1 V -1 11/04/25, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88445
-
Helmut Hummel uploaded patch set 2
V -111/12/25, 22:00 -
Helmut Hummel marked it work in progress 11/12/25, 22:00
-
core-ci voted on patch set 2 V -1 11/12/25, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89408
-
Helmut Hummel uploaded patch set 3
V -111/12/25, 22:16 -
Helmut Hummel uploaded patch set 4 11/12/25, 22:25
-
core-ci voted on patch set 3 V -1 11/12/25, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89409
-
core-ci voted on patch set 4 V -1 11/12/25, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89410
-
Helmut Hummel uploaded patch set 5
V -111/12/25, 23:05 -
core-ci voted on patch set 5 V -1 11/12/25, 23:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89411
-
Helmut Hummel uploaded patch set 6
V -111/12/25, 23:37 -
core-ci voted on patch set 6 V -1 11/12/25, 23:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89412
-
Helmut Hummel uploaded patch set 7
V -111/13/25, 07:52 -
core-ci voted on patch set 7 V +1 11/13/25, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89431
-
Helmut Hummel uploaded patch set 8
V +111/13/25, 10:17 -
core-ci voted on patch set 8 V +1 11/13/25, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89458
-
Helmut Hummel uploaded patch set 9
V +111/13/25, 10:32 -
core-ci voted on patch set 9 V +1 11/13/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89462
-
Helmut Hummel uploaded patch set 10
V +111/13/25, 11:10 -
core-ci voted on patch set 10 V -1 11/13/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89471
-
Helmut Hummel uploaded patch set 11
V -111/13/25, 11:43 -
Helmut Hummel marked it ready for review 11/13/25, 11:43
-
Helmut Hummel uploaded patch set 12 11/13/25, 11:48
-
core-ci voted on patch set 11 V -1 11/13/25, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89477
-
Helmut Hummel uploaded patch set 13 11/13/25, 11:58
-
core-ci voted on patch set 12 V -1 11/13/25, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89480
-
core-ci voted on patch set 13 V +1 11/13/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89485
-
Helmut Hummel rebased onto patch set 14
V +111/14/25, 07:26 -
core-ci voted on patch set 14 V +1 11/14/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89654
-
Oliver Klee voted on patch set 14 V +1 11/14/25, 08:57
-
Benni Mack voted on patch set 14 CR +1 V +1 11/18/25, 18:07
-
Christian Kuhn voted on patch set 14 CR +1 V +1 11/18/25, 22:49
-
Benjamin Franzke commented on patch set 14 CR -1 11/19/25, 09:30
-
Helmut Hummel commented on patch set 14 11/19/25, 12:41
UriTest.php:118ReplyHm, ok. While I understand the attack scenario as outlined with the examples in https://forge.typo3.org/issues/105170 I don't see such scenario with "domainalike" relative paths. I tried send a redirect header for Chromium with 'www.example.com' and the browser redirected to https://my-testdomain.test/www.example.com exactly as I would have expected. Do you have more resources than the mentioned ticket that explain attack vectors with such relative URIs that resemble domain names? -
Benjamin Franzke commented on patch set 14 CR +1 V +1 11/19/25, 13:33
UriTest.php:118ReplyNo other resources that I know of, only a PDF that is attached to the mentioned issue, which is easy to overlook, but I guess you already found that. I've also tried to reproduce the problems and agree with you that there is no issue to be detected for relative redirects, given that you preceded the relative path by a dot-segment when it contains a colon – thanks for that. Since these test assertions for relative URIs were not reported, but derived by us, it seems we did wrong with these test assertion. Sorry for the trouble, I think we're good to merge here. There a "feeling" left, that we could see issues, whenever "evil.tld\@host.tld" would be "autolinked" to "https://evil.tld\@host.tld" by whatever postprocessing, but I can not imagine/build up a case, so I refrain from seeing that feeling as a blocker. -
Helmut Hummel commented on patch set 14 CR +2 V +2 11/20/25, 11:18
UriTest.php:118Reply> whenever "evil.tld\@host.tld" would be "autolinked" to "https://evil.tld\@host.tld" I would argue, that "autolinking" would be fine in case the result is represented as URI object again, which would then be caught by our validation code. Using an object representation of an URI, converting it to a string and then manipulating this string, should imho be considered as security flaw in the calling code, not the URI imoplementation. I also triple checked UruValue and could not come up with any issue related to this subclass and will merge now. Thanks for taking a very close look into this and your overall analysis. -
Helmut Hummel merged patch set 15 11/20/25, 11:18
UriTest.php:118