Review 13.4 Merged

91427[BUGFIX] Ensure uri.action and link.action work the same

Simon Praetorius CR +2 V +2 Hard +98 −246 updated 11/05/25, 08:40

Commit message

Remove all code duplication from the viewhelpers
by centralizing the code within uri.action.

Furthermore, ensure that all arguments are
processed identical with/-out extbase context.

All arguments have been checked one-by-one
to ensure default values and data types
are processed correctly.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 58

  1. Simon Praetorius commented on patch set 1 11/04/25, 17:25

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php * typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php
  2. core-ci voted on patch set 1 V -1 11/04/25, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88473

  3. Markus Klein uploaded patch set 2 V -1 11/04/25, 18:03

  4. core-ci voted on patch set 2 V +1 11/04/25, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88474

  5. Markus Klein uploaded patch set 3 V +1 11/04/25, 18:24

  6. core-ci voted on patch set 3 V +1 11/04/25, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88476

  7. Simon Praetorius commented on patch set 3 CR +2 V +2 11/05/25, 08:39

    This change is ready for review.
  8. Simon Praetorius merged patch set 4 11/05/25, 08:40