Review main Merged

91428[TASK] Improve enable field labels for users

Lina Wolf CR +2 V +2 Easy +45 −0 updated 11/15/25, 13:28

Commit message

The default labels like "Publish date" and "enabled" do
not really make sense in the context of user accounts.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 4046

Show 1721 earlier messages
  1. Lina Wolf uploaded patch set 1 11/05/25, 14:13

  2. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/05/25, 14:17

  3. Mathias Brodala commented on patch set 1 11/05/25, 14:18

    accounts.xlf:11

    > Active accounts can log in

    accounts.xlf:16

    > Disable account after

    accounts.xlf:21

    I'd strike the 2nd sentence.

    accounts.xlf:31

    No matter how often I read this, I don't get it at all. ;-)

    accounts.xlf:36

    > Enable account after

    accounts.xlf:41

    I'd also strike the 2nd sentence. It does not make sense on subsequent changes.
  4. Mathias Brodala voted on patch set 1 CR -1 11/05/25, 14:18

  5. Simon Schaufelberger voted on patch set 1 CR 0 V 0 11/05/25, 14:20

  6. core-ci voted on patch set 1 V +1 11/05/25, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88521

  7. Riccardo De Contardi commented on patch set 1 11/05/25, 15:00

    accounts.xlf:31 Reply

    what about something like "Disabled group properties (e.g. permissions) will not be taken into account." Is it correct?
  8. Lina Wolf commented on patch set 1 11/05/25, 15:06

    accounts.xlf:41 Reply

    I think the second sentence is important. Otherwise you could presume that you always have to put a date here.
  9. Lina Wolf uploaded patch set 2 CR -1 V +1 11/05/25, 15:09

  10. Mathias Brodala commented on patch set 2 11/05/25, 15:10

    accounts.xlf:41 Reply

    Then maybe include the term "delay". Again, if you edit an existing account, this sentence doesn't make much sense. The account already is active. Only if you then set this, it becomes inactive again until the given date.
  11. Simon Schaufelberger wrote 11/05/25, 15:12

    Removed reviewer Simon Schaufelberger.
  12. Lina Wolf commented on patch set 2 11/05/25, 15:12

    accounts.xlf:11 Reply

    Done

    accounts.xlf:16 Reply

    Done

    accounts.xlf:36 Reply

    Done
  13. core-ci voted on patch set 2 V +1 11/05/25, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88524

  14. Rachel Foucard commented on patch set 2 11/06/25, 11:50

    accounts.xlf:41 Reply

    If the field label is "Enable account after", the description should only contain additional information that helps user to understand what to do. With no dexcription at all, I think that "Enable account after" is enough to understant that the account will be active after the date, so I would not explain it again in the description. On the contrary, the explanation about "what if it is empty" is really useful. So I would just keep "Leave empty to activate immediately."
  15. Rachel Foucard commented on patch set 2 11/06/25, 11:51

    accounts.xlf:21 Reply

    Like the starttime field, I think that only the information about the empty case is useful.
  16. Lina Wolf uploaded patch set 3 V +1 11/07/25, 12:20

  17. Lina Wolf commented on patch set 3 11/07/25, 12:22

    accounts.xlf:21 Reply

    Done

    accounts.xlf:31 Reply

    Adjusted the sentence

    accounts.xlf:41 Reply

    I like the idea of only explaining what happens when you leave it empty as the rest is defined by the main label
  18. core-ci voted on patch set 3 V +1 11/07/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88644

  19. Garvin Hicking updated the commit message in patch set 4 V +1 11/10/25, 14:53

  20. Garvin Hicking commented on patch set 4 11/10/25, 14:57

    accounts.xlf:6

    ```suggestion <source>Account is active</source> ``` (or: "Active account")

    accounts.xlf:11

    ```suggestion <source>Activated accounts can log in.</source> ```
  21. core-ci voted on patch set 4 V +1 11/10/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88859

  1. Lina Wolf commented on patch set 4 11/11/25, 03:34

    accounts.xlf:6 Reply

    Fix applied.
  2. Lina Wolf commented on patch set 4 11/11/25, 03:34

    accounts.xlf:11 Reply

    Fix applied.
  3. Garvin Hicking commented on patch set 4 11/11/25, 22:52

    lgtm
  4. Garvin Hicking voted on patch set 4 CR +1 V +1 11/11/25, 22:52

  5. Rachel Foucard voted on patch set 4 V +1 11/13/25, 08:24

  6. Riccardo De Contardi voted on patch set 4 V +1 11/13/25, 08:40

  7. Lina Wolf commented on patch set 5 CR +1 V +1 11/14/25, 06:42

    Published edit on patch set 4.
  8. core-ci voted on patch set 5 V +1 11/14/25, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89649

  9. Riccardo De Contardi voted on patch set 5 V +1 11/14/25, 16:04

  10. Rachel Foucard voted on patch set 5 V +1 11/14/25, 16:43

  11. Garvin Hicking voted on patch set 5 CR +1 V +1 11/14/25, 18:27

  12. Jasmina Ließmann commented on patch set 5 11/14/25, 19:54

    fe_users.php:8

    Basically, I welcome label adjustments to provide clarity for the user. However, I wonder whether the description "Leave empty for no time restriction." is really necessary for the `starttime` and `endtime` fields, or whether the label adjustment already makes it self-explanatory. If we add descriptions at this point to explain the purpose of an empty datetime field, then this would have to be added to all fields of this type... I would omit the descriptive text in these two fields.
  13. Garvin Hicking commented on patch set 5 11/14/25, 21:08

    fe_users.php:8 Reply

    (would be fine by me to omit this, I have no strong oppinion on it)
  14. Lina Wolf commented on patch set 5 11/15/25, 09:18

    fe_users.php:8 Reply

    I'd keep the note - an empty start time could be read as “never enabled.”
  15. Jasmina Ließmann commented on patch set 5 11/15/25, 09:28

    fe_users.php:8 Reply

    I would argue that it is learned behavior that `starttime` and `endtime` only become active once a value has been entered in one of the two fields (e.g., when working with pages or content elements). The label `Account is active` is sufficiently meaningful.
  16. Lina Wolf commented on patch set 5 11/15/25, 09:30

    fe_users.php:8 Reply

    I see your point, but we want TYPO3 to be easier to understand for new users as well.
  17. Jasmina Ließmann commented on patch set 5 11/15/25, 09:49

    fe_users.php:8 Reply

    I understand that. Nevertheless, I am confident that users will be able to make this association even without additional descriptive text in these two fields. Counterproposal: How about combining the two fields `starttime` and `endtime` in a palette (similar to the view in `pages` and `tt_content`). This palette would then receive a description such as “Restrictions only apply to filled/set fields” or “Leave fields empty for no restrictions.”? This would give the user the desired textual support without repeating the text in the individual fields. This could be part of this patch, or we could omit the description text for the two fields in this patch and create a new one that covers several tables at once (`be_users`, `pages`, `tt_content`, etc.). @112@linawolf.de: What do you think?
  18. Oliver Klee voted on patch set 5 CR +1 V +1 11/15/25, 10:07

  19. Lina Wolf uploaded patch set 6 CR +1 V +1 11/15/25, 11:19

  20. Lina Wolf commented on patch set 6 11/15/25, 11:23

    fe_users.php:8 Reply

    So after a discussion in #cig-ux I uploaded Riccardo's proposal, what do you thing?
  21. core-ci voted on patch set 6 V +1 11/15/25, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89783

  22. Jasmina Ließmann commented on patch set 6 CR +1 V +1 11/15/25, 11:51

    fe_users.php:8 Reply

    That's fine with me. Thank you all for openly discussing and considering a joint solution.
  23. Oliver Klee voted on patch set 6 CR +1 V +1 11/15/25, 12:13

  24. Garvin Hicking voted on patch set 6 CR +2 V +2 11/15/25, 13:28

  25. Garvin Hicking merged patch set 7 11/15/25, 13:28