Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
91430[TASK] Replace "OK" label in modal and use the new syntax for "Discard"
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 11
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/91430/11 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/30/91430/11 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/workspaces/backend.ts+6 −5
- Build/Sources/TypeScript/workspaces/preview.ts+2 −1
- Build/Sources/TypeScript/workspaces/workspaces.ts+2 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+2 −2
- typo3/sysext/workspaces/Resources/Private/Language/action.xlfnew+20 −0
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+8 −8
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Ajax/StageButtons.fluid.html+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/workspaces.js+1 −1
Review log 1727
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 11/05/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88535
-
core-ci voted on patch set 2 V +1 11/05/25, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88536
-
Simon Schaufelberger voted on patch set 2 CR +1 11/06/25, 08:30
-
Riccardo De Contardi commented on patch set 3
CR +1V +111/06/25, 09:00Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 11/06/25, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88558
-
Rachel Foucard voted on patch set 3 V +1 11/06/25, 12:04
-
Lina Wolf voted on patch set 3 CR +1 11/07/25, 12:03
-
Lina Wolf voted on patch set 3 V +1 11/07/25, 12:11
-
Riccardo De Contardi uploaded patch set 4
CR +1V +102/06/26, 11:07 -
core-ci voted on patch set 4 V -1 02/06/26, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95266
-
Riccardo De Contardi commented on patch set 5
V -102/06/26, 11:20Published edit on patch set 4. -
core-ci voted on patch set 5 V -1 02/06/26, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95269
-
Riccardo De Contardi uploaded patch set 6
V -102/06/26, 11:38 -
core-ci voted on patch set 6 V -1 02/06/26, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95273
-
Riccardo De Contardi commented on patch set 7
V -102/06/26, 13:46Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 02/06/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95294
-
Riccardo De Contardi uploaded patch set 8
V +103/02/26, 10:11 -
core-ci voted on patch set 8 V +1 03/02/26, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97095
-
Georg Ringer voted on patch set 8 CR +1 V +1 03/02/26, 17:28
-
Benni Mack updated the commit message in patch set 9
CR +1V +104/22/26, 07:25 -
Benni Mack rebased onto patch set 10 08/07/26, 08:08
-
core-ci voted on patch set 10 V +1 08/07/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106101
-
Benni Mack uploaded patch set 11
V +109/03/26, 23:47 -
core-ci voted on patch set 11 V +1 09/03/26, 23:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107789
-
Simon Schaufelberger voted on patch set 11 CR +1 V +1 09/04/26, 07:48