Review main Merged

91431[FEATURE] Add H6 in header layouts

Kevin Meier CR +2 V +2 Easy +37 −0 updated 10/09/26, 19:29

Commit message

Add a value for header_layout to allow H6 in EXT:fluid_styled_content.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Jörg Bösche +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 5365

Show 3340 earlier messages
  1. Kevin Meier uploaded patch set 1 11/06/25, 09:59

  2. Mathias Brodala updated the commit message in patch set 2 11/06/25, 10:02

  3. Mathias Brodala voted on patch set 2 CR +1 11/06/25, 10:02

  4. core-ci voted on patch set 1 V +1 11/06/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88560

  5. core-ci voted on patch set 2 V +1 11/06/25, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88561

  6. Garvin Hicking commented on patch set 2 11/06/25, 12:29

    locallang_ttc.xlf:106

    We can/should not change the content of an existing label. Even though it's a bit painful, we need to keep I.6 for "hidden" and instead use seomthing like "I.h6" for the "Layout 6" variant. I.6 might have been used for other keys, and also it might have been translated and the translations would never be updated to "Layout 6" in this case.
  7. Garvin Hicking commented on patch set 2 11/06/25, 12:30

    locallang_ttc.xlf:106 Reply

    (a backport to 13.4 should be fine - adding new labels to 12.4 should be avoided I guess)
  8. Kevin Meier updated the commit message in patch set 3 CR +1 V +1 11/07/25, 08:05

  9. Kevin Meier uploaded patch set 4 11/07/25, 08:09

  10. core-ci voted on patch set 3 V +1 11/07/25, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88626

  11. core-ci voted on patch set 4 V +1 11/07/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88627

  12. Mathias Brodala commented on patch set 4 11/07/25, 08:20

    Personally I wouldn't mind changing the label identifiers. The workaround now is highly confusing and *will* lead to more errors. @garvin@hick.ing What issue do you see exactly? Another option would be changing the identifiers of *all* items, then translations could provide the old and new identifiers, thus be safe for use in all TYPO3 versions.
  13. Jasmina Ließmann commented on patch set 4 11/07/25, 08:28

    I would also prefer to change the label. A new label called "I.h6" doesn't match the current structure ("I.6"), and I'm always a fan of consistency. Regardless: What's wrong with adding the new layout option via page TSconfig (`TCEFORM.tt_content.header_layout.addItems`)? Does there really need to be a sixth option in the field?
  14. Mathias Brodala commented on patch set 4 11/07/25, 08:32

    Reply

    If you are a fan of consistency, then you know why. ;-) As written, FSC already supports h6, but by default editors cannot create h6. This does not make sense. Since h6 is perfectly valid, dropping it from FSC would be wrong, so editors must be given this option instead.
  15. Garvin Hicking commented on patch set 4 11/07/25, 09:52

    Reply

    Yes, then lets rename all labels to "h1..6". Changing an existing label is a no go, it will not trigger re-translations.
  16. Garvin Hicking commented on patch set 4 11/07/25, 10:02

    Reply

    (see https://docs.typo3.org/permalink/t3contribute:common-review-checks-xlf last item for reference, that an existing key must not chsnge meaning)
  17. Jasmina Ließmann commented on patch set 4 11/07/25, 10:11

    Reply

    What about naming it "header_layout.6"? It's not save to say that the field `header_layout` is always used for heading semantics, but rather for styling.

    Reply

    What if the h6 option would be added as a TCA override in EXT:fluid_styled_content instead of extending EXT:frontend? (the commit message explicitly refers to EXT:fluid_styled_content; others who don't use EXT:fluid_styled_content might not need the h6 option).
  18. Georg Ringer commented on patch set 4 11/19/25, 20:27

    I suggest for closing the issue because: - it is super easy to add another option using either tsconfig or tca - the current implementation is bad on so many levels: mixing styling with semantic, not checking if there is a proper order, ...
  19. Georg Ringer uploaded patch set 5 V +1 02/06/26, 06:52

  20. Georg Ringer uploaded patch set 6 02/06/26, 06:52

  21. Georg Ringer commented on patch set 6 CR +1 V +1 02/06/26, 06:54

    locallang_ttc.xlf:106 Reply

    I am strictly against a backport. people can use that field in their content elements and using tsconfig to remove items and then after core update the h6 would suddenly appear
  22. core-ci voted on patch set 6 V +1 02/06/26, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95237

  23. Garvin Hicking commented on patch set 6 CR +1 V +1 02/06/26, 07:04

    I hate that we have I.6=100=hidden though. But as far as breakage goes this is probably the best we can do now.
  24. core-ci voted on patch set 5 V -1 02/06/26, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95236

  25. Mathias Brodala commented on patch set 6 02/06/26, 07:33

    Reply

    If only one had been brave enough to use I.0 for "hidden" back then. ;-)
  26. Garvin Hicking commented on patch set 6 04/08/26, 20:13

    How do we feel about this one? 😄
  27. Georg Ringer rebased onto patch set 7 CR +1 V +1 04/08/26, 20:13

  28. core-ci voted on patch set 7 V +1 04/08/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99797

  29. Garvin Hicking voted on patch set 7 CR +1 V +1 04/08/26, 20:40

  30. Simon Schaufelberger voted on patch set 7 CR +1 V +1 04/08/26, 21:25

  31. Josef Glatz voted on patch set 7 CR +1 V +1 04/10/26, 02:15

  32. Jasmina Ließmann commented on patch set 7 04/13/26, 10:32

    Reply

    Resolving this to not block this any further.

    Reply

    Resolving this to not block this any further.
  33. Garvin Hicking voted on patch set 7 CR +2 V +2 04/13/26, 11:18

  34. Garvin Hicking voted on patch set 7 CR +1 V +1 04/13/26, 11:19

  35. Garvin Hicking commented on patch set 7 04/13/26, 11:19

    Reply

    Thinking about this that might be better yes?!
  36. Jasmina Ließmann commented on patch set 7 04/13/26, 13:08

    Reply

    Just leave the patch as it is currently :)
  37. Georg Ringer voted on patch set 7 CR +2 V +2 04/13/26, 17:12

  38. Georg Ringer commented on patch set 7 CR +1 V +1 04/13/26, 17:13

    just thinking if an important rst should be added
  39. Josef Glatz commented on patch set 7 CR -1 04/13/26, 20:39

    on it.
  40. Josef Glatz uploaded patch set 8 CR +1 V +1 04/13/26, 20:46

  1. Josef Glatz voted on patch set 8 CR +1 V +1 04/13/26, 20:47

  2. Josef Glatz commented on patch set 8 04/13/26, 20:48

    Reply

    plz review my important rst

    Reply

    Done
  3. Josef Glatz commented on patch set 8 04/13/26, 20:50

    Reply

    Done
  4. Garvin Hicking commented on patch set 8 04/13/26, 20:51

    Reply

    IDK this feels really heavy handed to do an important.rest for it. What could break? Just adding it to tell people they can now add id (which they could before on their own if they needed it) feels unneeded to me and defeats us calling out "important" things?
  5. core-ci voted on patch set 8 V -1 04/13/26, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100107

  6. Simon Schaufelberger voted on patch set 8 CR +1 V +1 04/13/26, 21:02

  7. core-ci commented on patch set 8 04/13/26, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100107

  8. core-ci commented on patch set 8 04/13/26, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100107

  9. Josef Glatz commented on patch set 8 04/14/26, 04:42

    Reply

    Feel free to remove. I was happy from an integrator perspective. In projects I clearly defined such things. The fact that very old projects are coming from a time where keepItems was not available, you probably used removeItems more and make the new option available without knowing now. That’s something you want to know when upgrading to 14. Also if you never had changed or configured the list of available options and editors had H1-H5. That editors have H6 now, too. Something you have to style, otherwise H6 is probably styled bigger than H5. As I’m coming from a time working on 4.x projects best practice was often not always the best in projects. I was very happy when both options where available side by side (keepItem/removeItems) in the core. The adoption in projects needed longer than expected. So this is the background of my +1. Maybe very theoretical in 2026.
  10. Georg Ringer commented on patch set 8 04/14/26, 04:44

    people now suddenly got a new heading which might is not needed or designed in elements. If I use e.g. contenblocks to reuse the field header_layout with different labels, the h6 is suddenly everywhere as well
  11. Georg Ringer voted on patch set 8 CR +1 V +1 04/14/26, 04:44

  12. Garvin Hicking commented on patch set 8 04/14/26, 05:14

    Reply

    Thx. Resolving this, but I can't really make up my mind. Not blocking it though.
  13. Josef Glatz commented on patch set 8 04/14/26, 07:01

    Also asked my PM (long lasting TYPO3 pm): importantRst would be beneficial. From a practical side such a change is discussable, because having H6 from an SEO perspective could be unnecesary. personally. however, this is project related stuff. TYPO3's the framework. However, from a technical aspect: HTML support H1 - H6. FSC already support h6 in it's fluid partials for Header. This patch resolves the technical side and adds the missing select option. And I use h6 also in my non public wiki TYPO3 website and PKMS. fazit: I would love to see this change in the core 😊
  14. Jasmina Ließmann wrote 06/22/26, 11:33

    Removed cc Jasmina Ließmann.
  15. Simon Schaufelberger commented on patch set 8 CR -1 V -1 06/22/26, 12:08

    Ci is not happy
  16. Georg Ringer uploaded patch set 9 CR +1 V +1 07/05/26, 18:46

  17. core-ci voted on patch set 9 V +1 07/05/26, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104362

  18. Simon Schaufelberger voted on patch set 9 CR +1 V +1 07/05/26, 20:08

  19. Jörg Bösche voted on patch set 9 CR +1 08/04/26, 14:32

  20. Georg Ringer rebased onto patch set 10 CR +1 V +1 08/27/26, 17:40

  21. core-ci voted on patch set 10 V +1 08/27/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107287

  22. Josua Vogel voted on patch set 10 CR +1 V +1 08/28/26, 12:50

  23. Jörg Bösche voted on patch set 10 CR +1 V +1 08/29/26, 20:27

  24. Georg Ringer voted on patch set 10 CR +2 V +2 10/09/26, 19:29

  25. Georg Ringer merged patch set 11 10/09/26, 19:29