Review main Merged

91433[BUGFIX] Implement button with single `class` attribute

TYPO3com CR +2 V +2 Easy +1 −1 updated 11/10/25, 20:04

Commit message

This removes a typo.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Mathias Brodala +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. TYPO3com uploaded patch set 1 11/06/25, 10:40

  2. Ayke Halder updated the commit message in patch set 2 11/06/25, 10:43

  3. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/25, 10:46

  4. core-ci voted on patch set 1 V +1 11/06/25, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88563

  5. core-ci voted on patch set 2 V +1 11/06/25, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88564

  6. Mathias Brodala voted on patch set 2 CR +1 11/06/25, 10:53

  7. Oliver Klee voted on patch set 2 CR +1 V +1 11/06/25, 11:02

  8. Oliver Hader voted on patch set 2 CR +1 V +1 11/06/25, 12:12

  9. Garvin Hicking commented on patch set 2 CR +1 V +1 11/06/25, 12:17

    ($0.02: IMO more of a cleanup task because at least all browsers I checked did not interpret the second "class" attribute and silently discarded it - it's wrong of course, so I'm fine with not relabelling this)
  10. Andreas Nedbal voted on patch set 2 CR +2 V +2 11/10/25, 15:38

  11. Andreas Nedbal merged patch set 3 11/10/25, 20:04