Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review

91435[TASK] Replace "OK" label in impexp modals and use the new syntax

Riccardo De Contardi CR 0 V 0 Normal +143 −25 updated 11/09/26, 14:56

Commit message

within the ext:impexp:
- replace "OK" on the  save, delete, merge, import and update modals
with labels coherent with the actual action performed
- Use the new language domain syntax for the labels inside these
modals
- adjust the modals title and message to be more descriptive

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 22
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/91435/22 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/91435/22 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 9

Review log 3452

Show 1727 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 11/06/25, 16:05

  2. core-ci voted on patch set 1 V +1 11/06/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88591

  3. Rachel Foucard voted on patch set 1 V +1 11/06/25, 16:28

  4. Lina Wolf commented on patch set 1 11/07/25, 11:57

    label.xlf:6

    ```suggestion <source>Delete preset</source> ```

    messages.xlf:6

    ```suggestion <source>Delete this preset? This action can’t be undone.</source> ```
  5. Riccardo De Contardi commented on patch set 1 11/07/25, 12:00

    label.xlf:6 Reply

    Fix applied.
  6. Riccardo De Contardi commented on patch set 2 V +1 11/07/25, 13:40

    Published edit on patch set 1.
  7. Riccardo De Contardi commented on patch set 2 11/07/25, 13:42

    messages.xlf:6 Reply

    "Can't" seems too "spoken" and informal . I agree that "undone" is better IIRC you can ask the opinion of a native english speaker, right?
  8. core-ci voted on patch set 2 V +1 11/07/25, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88647

  9. Lina Wolf commented on patch set 2 11/07/25, 13:57

    messages.xlf:6 Reply

    How about cannot be undone?
  10. Riccardo De Contardi commented on patch set 2 11/07/25, 13:58

    already done with patchset 2, am I right?

    messages.xlf:6 Reply

    Done
  11. Lina Wolf voted on patch set 2 CR +1 V +1 11/07/25, 14:04

  12. Riccardo De Contardi uploaded patch set 3 CR +1 V +1 11/23/25, 16:38

  13. core-ci voted on patch set 3 V +1 11/23/25, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90764

  14. Riccardo De Contardi commented on patch set 4 V +1 01/23/26, 11:04

    Published edit on patch set 3.
  15. Riccardo De Contardi commented on patch set 5 01/23/26, 11:06

    Published edit on patch set 4.
  16. Riccardo De Contardi commented on patch set 6 01/23/26, 11:08

    Published edit on patch set 5.
  17. Riccardo De Contardi commented on patch set 7 01/23/26, 11:10

    Published edit on patch set 6.
  18. core-ci voted on patch set 4 V +1 01/23/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94150

  19. core-ci voted on patch set 5 V +1 01/23/26, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94151

  20. core-ci voted on patch set 6 V +1 01/23/26, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94152

  21. core-ci voted on patch set 7 V +1 01/23/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94154

  22. Riccardo De Contardi commented on patch set 8 V +1 02/04/26, 14:07

    Published edit on patch set 7.
  23. core-ci voted on patch set 8 V +1 02/04/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95036

  24. Riccardo De Contardi commented on patch set 9 V +1 02/04/26, 14:35

    Published edit on patch set 8.
  25. core-ci voted on patch set 9 V +1 02/04/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95040

  26. Riccardo De Contardi uploaded patch set 10 V +1 02/04/26, 15:04

  27. core-ci voted on patch set 10 V -1 02/04/26, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95047

  1. Riccardo De Contardi commented on patch set 11 V -1 02/04/26, 15:20

    Published edit on patch set 10.
  2. Riccardo De Contardi commented on patch set 12 02/04/26, 15:21

    Published edit on patch set 11.
  3. Riccardo De Contardi commented on patch set 13 02/04/26, 15:21

    Published edit on patch set 12.
  4. Riccardo De Contardi commented on patch set 14 02/04/26, 15:21

    Published edit on patch set 13.
  5. Riccardo De Contardi commented on patch set 15 02/04/26, 15:22

    Published edit on patch set 14.
  6. core-ci voted on patch set 15 V -1 02/04/26, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95059

  7. Riccardo De Contardi uploaded patch set 16 V -1 02/04/26, 17:37

  8. core-ci voted on patch set 16 V +1 02/04/26, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95077

  9. Riccardo De Contardi uploaded patch set 17 V +1 02/17/26, 15:14

  10. core-ci voted on patch set 17 V -1 02/17/26, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96063

  11. core-ci voted on patch set 17 V +1 02/17/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96063

  12. Anja Leichsenring voted on patch set 17 CR +1 V +1 02/17/26, 19:54

  13. Benni Mack updated the commit message in patch set 18 CR +1 V +1 04/22/26, 07:25

  14. Riccardo De Contardi uploaded patch set 19 08/06/26, 18:43

  15. core-ci voted on patch set 19 V +1 08/06/26, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106016

  16. David Denicolò commented on patch set 19 CR +1 V +1 08/06/26, 19:47

    tested on main
  17. Simon Schaufelberger voted on patch set 19 CR +1 V +1 11/06/26, 00:47

  18. Riccardo De Contardi uploaded patch set 20 CR +1 V +1 11/08/26, 16:25

  19. core-ci voted on patch set 20 V +1 11/08/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113604

  20. Benni Mack commented on patch set 20 11/09/26, 14:21

    you change the labels for "unused-since 15.0" but also target 14.3 in the commit message, what are your plans? I suggest: main only.
  21. Riccardo De Contardi updated the commit message in patch set 21 V +1 11/09/26, 14:38

  22. Riccardo De Contardi commented on patch set 21 11/09/26, 14:39

    Reply

    Done; no problem for me
  23. Benni Mack updated the commit message in patch set 22 11/09/26, 14:45

  24. core-ci voted on patch set 21 V +1 11/09/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113708

  25. core-ci voted on patch set 22 V +1 11/09/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113709