Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
91435[TASK] Replace "OK" label in impexp modals and use the new syntax
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 22
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/91435/22 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/91435/22 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/impexp/import-export.ts+26 −1
- typo3/sysext/core/Resources/Private/Language/action.xlf+15 −0
- typo3/sysext/impexp/Resources/Private/Language/action.xlfnew+15 −0
- typo3/sysext/impexp/Resources/Private/Language/label.xlf2new+35 −0
- typo3/sysext/impexp/Resources/Private/Language/locallang.xlf+23 −5
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.fluid.html+1 −1
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.fluid.html+17 −11
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.fluid.html+10 −6
- typo3/sysext/impexp/Resources/Public/JavaScript/import-export.js+1 −1
Review log 3452
Show 1727 earlier messages
-
Riccardo De Contardi uploaded patch set 1 11/06/25, 16:05
-
core-ci voted on patch set 1 V +1 11/06/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88591
-
Rachel Foucard voted on patch set 1 V +1 11/06/25, 16:28
-
Lina Wolf commented on patch set 1 11/07/25, 11:57
messages.xlf:6```suggestion <source>Delete this preset? This action can’t be undone.</source> ``` -
Riccardo De Contardi commented on patch set 1 11/07/25, 12:00
label.xlf:6ReplyFix applied. -
Riccardo De Contardi commented on patch set 2
V +111/07/25, 13:40Published edit on patch set 1. -
Riccardo De Contardi commented on patch set 2 11/07/25, 13:42
messages.xlf:6Reply"Can't" seems too "spoken" and informal . I agree that "undone" is better IIRC you can ask the opinion of a native english speaker, right? -
core-ci voted on patch set 2 V +1 11/07/25, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88647
-
Lina Wolf commented on patch set 2 11/07/25, 13:57
messages.xlf:6ReplyHow about cannot be undone? -
Riccardo De Contardi commented on patch set 2 11/07/25, 13:58
already done with patchset 2, am I right?messages.xlf:6ReplyDone -
Lina Wolf voted on patch set 2 CR +1 V +1 11/07/25, 14:04
-
Riccardo De Contardi uploaded patch set 3
CR +1V +111/23/25, 16:38 -
core-ci voted on patch set 3 V +1 11/23/25, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90764
-
Riccardo De Contardi commented on patch set 4
V +101/23/26, 11:04Published edit on patch set 3. -
Riccardo De Contardi commented on patch set 5 01/23/26, 11:06
Published edit on patch set 4. -
Riccardo De Contardi commented on patch set 6 01/23/26, 11:08
Published edit on patch set 5. -
Riccardo De Contardi commented on patch set 7 01/23/26, 11:10
Published edit on patch set 6. -
core-ci voted on patch set 4 V +1 01/23/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94150
-
core-ci voted on patch set 5 V +1 01/23/26, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94151
-
core-ci voted on patch set 6 V +1 01/23/26, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94152
-
core-ci voted on patch set 7 V +1 01/23/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94154
-
Riccardo De Contardi commented on patch set 8
V +102/04/26, 14:07Published edit on patch set 7. -
core-ci voted on patch set 8 V +1 02/04/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95036
-
Riccardo De Contardi commented on patch set 9
V +102/04/26, 14:35Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 02/04/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95040
-
Riccardo De Contardi uploaded patch set 10
V +102/04/26, 15:04 -
core-ci voted on patch set 10 V -1 02/04/26, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95047
-
Riccardo De Contardi commented on patch set 11
V -102/04/26, 15:20Published edit on patch set 10. -
Riccardo De Contardi commented on patch set 12 02/04/26, 15:21
Published edit on patch set 11. -
Riccardo De Contardi commented on patch set 13 02/04/26, 15:21
Published edit on patch set 12. -
Riccardo De Contardi commented on patch set 14 02/04/26, 15:21
Published edit on patch set 13. -
Riccardo De Contardi commented on patch set 15 02/04/26, 15:22
Published edit on patch set 14. -
core-ci voted on patch set 15 V -1 02/04/26, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95059
-
Riccardo De Contardi uploaded patch set 16
V -102/04/26, 17:37 -
core-ci voted on patch set 16 V +1 02/04/26, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95077
-
Riccardo De Contardi uploaded patch set 17
V +102/17/26, 15:14 -
core-ci voted on patch set 17 V -1 02/17/26, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96063
-
core-ci voted on patch set 17 V +1 02/17/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96063
-
Anja Leichsenring voted on patch set 17 CR +1 V +1 02/17/26, 19:54
-
Benni Mack updated the commit message in patch set 18
CR +1V +104/22/26, 07:25 -
Riccardo De Contardi uploaded patch set 19 08/06/26, 18:43
-
core-ci voted on patch set 19 V +1 08/06/26, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106016
-
David Denicolò commented on patch set 19 CR +1 V +1 08/06/26, 19:47
tested on main -
Simon Schaufelberger voted on patch set 19 CR +1 V +1 11/06/26, 00:47
-
Riccardo De Contardi uploaded patch set 20
CR +1V +111/08/26, 16:25 -
core-ci voted on patch set 20 V +1 11/08/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113604
-
Benni Mack commented on patch set 20 11/09/26, 14:21
you change the labels for "unused-since 15.0" but also target 14.3 in the commit message, what are your plans? I suggest: main only. -
Riccardo De Contardi updated the commit message in patch set 21
V +111/09/26, 14:38 -
Riccardo De Contardi commented on patch set 21 11/09/26, 14:39
Reply
Done; no problem for me -
Benni Mack updated the commit message in patch set 22 11/09/26, 14:45
-
core-ci voted on patch set 21 V +1 11/09/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113708
-
core-ci voted on patch set 22 V +1 11/09/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113709
label.xlf:6