Review main Merged

91437[BUGFIX] Correct max-height calculation of dropdowns in docheader

Benjamin Kott CR +2 V +2 Easy +3 −4 updated 11/07/25, 11:20

Commit message

The variable used for calculation did not exist, its now removed
since it is actually unneeded, as we only need to substract the
docheader height.
In addition the clipping is removed to avoid having transparent
scrollbars.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benjamin Kott uploaded patch set 1 11/06/25, 16:38

  2. core-ci voted on patch set 1 V +1 11/06/25, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88594

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/07/25, 07:16

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 11/07/25, 08:58

  5. core-ci voted on patch set 2 V +1 11/07/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88633

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 11/07/25, 09:07

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 11/07/25, 09:15

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 11/07/25, 10:52

  9. Benjamin Franzke merged patch set 3 11/07/25, 11:20