91438[TASK] Add QR Code web-component
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/element/typo3-qrcode.scssnew+8 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/element/qrcode-element.ts12new+129 −0
- typo3/sysext/backend/Classes/Backend/QrCodeSize.php4new+39 −0
- typo3/sysext/backend/Classes/Controller/QrCodeController.php23new+158 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+11 −0
- typo3/sysext/backend/Resources/Private/Language/qrcode.xlfnew+32 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/qrcode-element.jsnew+13 −0
- typo3/sysext/backend/Tests/Functional/Controller/QrCodeControllerTest.phpnew+100 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/qrcode-test.svgnew+2 −0
Review log 2943
Show 1118 earlier messages
-
Jochen Roth uploaded patch set 1 11/06/25, 17:17
-
Jochen Roth marked it work in progress 11/06/25, 17:19
-
core-ci voted on patch set 1 V -1 11/06/25, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88596
-
Jochen Roth uploaded patch set 2
V -111/09/25, 19:26 -
core-ci voted on patch set 2 V -1 11/09/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88751
-
Jochen Roth uploaded patch set 3
V -111/09/25, 20:01 -
core-ci voted on patch set 3 V +1 11/09/25, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88752
-
Jochen Roth updated the commit message in patch set 4
V +111/09/25, 20:10 -
Jochen Roth marked it ready for review 11/09/25, 20:15
-
core-ci voted on patch set 4 V +1 11/09/25, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88753
-
Jochen Roth uploaded patch set 5
V +111/09/25, 20:33 -
core-ci voted on patch set 5 V +1 11/09/25, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88754
-
Benni Mack commented on patch set 5 CR -1 11/10/25, 08:56
qrcode-element.ts:109see above. each action should be its own routelocallang_qrcode.xlf:3please name the whole file just "qrcode.xlf" -
Jochen Roth uploaded patch set 6
CR -1V +111/10/25, 17:58 -
core-ci voted on patch set 6 V -1 11/10/25, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88892
-
Jochen Roth uploaded patch set 7
V -111/10/25, 18:18 -
core-ci voted on patch set 7 V +1 11/10/25, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88893
-
Jochen Roth commented on patch set 7 11/10/25, 18:27
qrcode-element.ts:77ReplyDoneqrcode-element.ts:109ReplyDonelocallang_qrcode.xlf:3ReplyDone
-
Oli Bartsch commented on patch set 7 11/10/25, 18:33
QrCodeController.php:47Please use `'methods' => ['GET']` in AjaxRoutes.phpQrCodeController.php:51undefined array access?QrCodeController.php:53Does it make sense to generate a svg with empty content?QrCodeController.php:55Please let's use PSR-17 factories instead.QrCodeController.php:60Please use `'methods' => ['POST']` in AjaxRoutes.phpQrCodeController.php:68Does it make sense to generate a svg with empty content?QrCodeController.php:94Please let's use PSR-17 factories instead. -
Jochen Roth uploaded patch set 8
V +111/10/25, 21:42 -
core-ci voted on patch set 8 V -1 11/10/25, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88917
-
Jochen Roth uploaded patch set 9
V -111/10/25, 21:53 -
core-ci voted on patch set 9 V +1 11/10/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88918
-
Jochen Roth commented on patch set 9 11/11/25, 15:43
QrCodeController.php:47ReplyDoneQrCodeController.php:51ReplyDoneQrCodeController.php:53ReplyNopeQrCodeController.php:55ReplyDoneQrCodeController.php:60ReplyDoneQrCodeController.php:68ReplyNopeQrCodeController.php:94ReplyDone -
Oli Bartsch commented on patch set 9 11/11/25, 17:45
qrcode-element.ts:45Shouldn't this be `Number`?qrcode-element.ts:46`Number` for TemplateResult? And why is internal rendering state exposed as a property? This should be @state().qrcode-element.ts:51This call to `loadQrCode()` without checking if `this.content` might fail.qrcode-element.ts:110is this really necessary?QrCodeSize.php:28Should be `MEGA`, like used for the avatar component. I also think that defining the same in the JS component again is duplicated and might lead to "out of sync" issues in the future.QrCodeSize.php:34Why 192 and not 128? 😄QrCodeController.php:34I think backend should not depend on EXT:from ;)QrCodeController.php:59We are missing content-type header for svg. While this might work in most browsers, we should define it.QrCodeController.php:74I think dirname() should be removed here.QrCodeController.php:103might trigger array key error -
Jochen Roth uploaded patch set 10
V +111/12/25, 09:05 -
Jochen Roth commented on patch set 10 CR +1 V +1 11/12/25, 09:07
qrcode-element.ts:45ReplyWell, in the end it is a string. e.g. "large", "medium", "small".qrcode-element.ts:46ReplyDoneqrcode-element.ts:51ReplyNow checking for an empty `this.content` and in case it is empty, render not-found icon.qrcode-element.ts:110ReplyGood catch. Not necessary.QrCodeSize.php:28ReplyNow using `MEGA` instead of `EXTRA_LARGE`QrCodeSize.php:34Replyhm... now using 128QrCodeController.php:34ReplyDoneQrCodeController.php:59ReplyDoneQrCodeController.php:74ReplyDoneQrCodeController.php:103ReplyWell, this should return at lease one result. But in case of cases, i added a fallback to 'image/svg+xml' -
Jochen Roth voted on patch set 10 CR 0 V 0 11/12/25, 09:10
-
core-ci voted on patch set 10 V +1 11/12/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89172
-
Oli Bartsch uploaded patch set 11
V +111/12/25, 09:34 -
Oli Bartsch voted on patch set 11 CR +1 V +1 11/12/25, 09:35
-
Benni Mack commented on patch set 11 CR -1 11/12/25, 09:38
We should use more TYPO3 Core APIs -
core-ci voted on patch set 11 V +1 11/12/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89203
-
Benni Mack uploaded patch set 12
CR +1V +111/12/25, 09:45 -
Benni Mack uploaded patch set 13 11/12/25, 09:46
-
core-ci voted on patch set 12 V -1 11/12/25, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89224
-
core-ci voted on patch set 13 V -1 11/12/25, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89225
-
Jochen Roth uploaded patch set 14
V -111/12/25, 13:01 -
Jochen Roth commented on patch set 14 11/12/25, 13:06
QrCodeController.php:151FYI, intentionally not using `GeneralUtility::upload_copy_move($pngFile, $targetPath)`, coz it returns `false` when it copies a file to the destitation. -
core-ci voted on patch set 14 V +1 11/12/25, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89315
-
Oli Bartsch voted on patch set 14 CR +1 V +1 11/12/25, 14:42
-
Benni Mack voted on patch set 14 CR +2 V +2 11/12/25, 20:17
-
Benni Mack merged patch set 15 11/12/25, 20:17
qrcode-element.ts:77