Review main Merged

91446[FEATURE] Unify module button bar

Oli Bartsch CR +2 V +2 Expert +610 −448 updated 11/18/25, 21:45

Commit message

This unifies the module button bar across all backend
modules by automatically adding reload and shortcut
buttons in consistent positions.

Reload and shortcut buttons now always appear on the
right side of the button bar, ensuring they are always the
last two buttons regardless of what other buttons are added
by controllers or event listeners.

The shortcut button now uses a simplified API via
DocHeaderComponent::setShortcutContext() instead of requiring
manual button creation, and preserves full context (e.g., the
specific site, page, or record being edited) with appropriate
labels in the bookmark bar.

All core backend module controllers have been migrated to
use the new automatic button system, establishing a
consistent pattern throughout TYPO3.

Furthermore, the shortcut button does also now
preserve context like the site settings, a user
is currently editing and also uses a corresponding
label in the bookmark bar.

The site configuration and site settings editing
view uses a button to link to each other. This
button is basically the same as the "edit whole
record" button, known from FormEngine. This button
is therefore now aligned to use the "pencil"
icon and to be placed on the left side.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 50

Show 30 more files

Review log 2231

Show 56 earlier messages
  1. Oli Bartsch uploaded patch set 1 11/07/25, 14:06

  2. Benjamin Franzke commented on patch set 1 CR -1 11/07/25, 14:13

    We do not need the reload buttons at all. It makes *no* sense to introduce them everywhere. I think they can be dropped entirely. Users can just reload via their browser functionality, given that we're nowadays able to synchronize module and tree states.
  3. core-ci voted on patch set 1 V +1 11/07/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88652

  4. Oli Bartsch commented on patch set 1 11/07/25, 14:30

    Reply

    Who is "we". It's a difference to reload the whole backend with a huge page tree, a couple of dispatched events etc. instead of just the content frame. We might want to get rid of this in the long run (LTS) for sure. For now, I want unify the controllers so we have a clean state to implement new components.
  5. Oli Bartsch commented on patch set 1 11/09/25, 15:38

    Reply

    Thought about this again and still think it would be a good idea to have a clean and unified state for further changes. You can take my word that the reload button will be reevaluate in the next days. It like with a couple of patches currently. This is not a final solution patch but pre-patch for further, more structural changes. I'm also fine to talk this through on location.
  6. Simon Schaufelberger commented on patch set 1 11/09/25, 23:03

    Reply

    I use the reload button after uploading files a lot because the notification is gone after a few seconds to actually display the files. Another thing is the scheduler.
  1. Josef Glatz commented on patch set 1 11/10/25, 08:22

    Reply

    I use reload everywhere if available. Share buttons: Have it everywhere context aware (selected filter, ...) would be really helpful for editors AND sharing with customers! <3
  2. Oli Bartsch commented on patch set 1 11/11/25, 07:21

    Reply

    @ben@bnf.dev How to proceed here?
  3. Benjamin Franzke commented on patch set 1 CR 0 11/11/25, 12:03

    Reply

    Please consider it as recommendation, I think we are unnecessarily readding browser controls, that are seldomly needed. but Filelist is a good example where we are bad at properly updating, again it wouldn't hurt, because a browser reload also just works and preserves state, but I'll remove my vote.
  4. Oli Bartsch uploaded patch set 2 V +1 11/11/25, 21:36

  5. Oli Bartsch updated the commit message in patch set 3 11/11/25, 21:37

  6. core-ci voted on patch set 2 V -1 11/11/25, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89081

  7. core-ci voted on patch set 3 V -1 11/11/25, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89082

  8. Oli Bartsch uploaded patch set 4 V -1 11/12/25, 08:06

  9. core-ci voted on patch set 4 V +1 11/12/25, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89131

  10. Oli Bartsch uploaded patch set 5 V +1 11/12/25, 21:08

  11. core-ci voted on patch set 5 V +1 11/12/25, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89399

  12. Oli Bartsch uploaded patch set 6 V +1 11/15/25, 09:40

  13. core-ci voted on patch set 6 V +1 11/15/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89776

  14. Lina Wolf commented on patch set 6 CR -1 V +1 11/16/25, 13:38

    I tried this out with t3docs/example's module and it worked a charm. However please make sure that you do not use outdated language files. See also the deprecation log: Sun, 16 Nov 2025 14:36:33 +0100 [NOTICE] request="efd6cbc4a2c83" component="TYPO3.CMS.deprecations": Core: Error handler (BE): TYPO3 Deprecation Notice: The file "EXT:extensionmanager/Resources/Private/Language/locallang_mod.xlf" is deprecated. Please use a label from a different language file instead. in /var/www/html/typo3/sysext/core/Classes/Localization/LocalizationFactory.php line 125

    AbstractController.php:134

    Usage of this language file is deprecated. ```suggestion $activeTitle = $this->translate('title', 'extensionmanager.module'); ```

    AdministrationController.php:128

    This language file is also deprecated
  15. Oli Bartsch uploaded patch set 7 CR -1 V +1 11/17/25, 12:41

  16. Oli Bartsch commented on patch set 7 11/17/25, 12:42

    AbstractController.php:134 Reply

    Done

    AdministrationController.php:128 Reply

    Done
  17. core-ci voted on patch set 7 V +1 11/17/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89939

  18. Lina Wolf uploaded patch set 8 V +1 11/17/25, 13:11

  19. core-ci voted on patch set 8 V +1 11/17/25, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89942

  20. Oli Bartsch uploaded patch set 9 V +1 11/17/25, 20:45

  21. core-ci voted on patch set 9 V +1 11/17/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89965

  22. Lina Wolf voted on patch set 9 CR +1 V +1 11/18/25, 14:37

  23. Jasmina Ließmann voted on patch set 9 CR +1 V +1 11/18/25, 16:08

  24. Oli Bartsch commented on patch set 9 CR +2 V +2 11/18/25, 21:45

    I will merge this for now to continue the work on the doc header. As promised, I will reevaluate the whole reload topic after 14.0 again.
  25. Oli Bartsch merged patch set 10 11/18/25, 21:45