Review main Merged

91450[TASK] Allow Stringable for Extbase UriBuilder

Sascha Nowak CR +2 V +2 Easy +27 −0 updated 11/10/25, 19:25

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Sascha Nowak uploaded patch set 1 11/08/25, 10:52

  2. core-ci voted on patch set 1 V -1 11/08/25, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88695

  3. Sascha Nowak uploaded patch set 2 V -1 11/08/25, 11:14

  4. core-ci voted on patch set 2 V +1 11/08/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88697

  5. Simon Schaufelberger commented on patch set 2 11/08/25, 11:24

    I would give it the TASK prefix as there is no bug
  6. Sascha Nowak commented on patch set 2 11/08/25, 11:27

    Reply

    I’m fine with that, as long as it end up being backported to v13 😊
  7. Simon Schaufelberger commented on patch set 2 11/08/25, 11:29

    Reply

    yes, also tasks can be backported. only features are excluded.
  8. Sascha Nowak updated the commit message in patch set 3 V +1 11/08/25, 11:31

  9. core-ci voted on patch set 3 V +1 11/08/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88699

  10. Simon Schaufelberger commented on patch set 3 CR +1 V +1 11/08/25, 12:12

    Reply

    Done
  11. Oliver Klee voted on patch set 3 CR +1 V +1 11/09/25, 12:45

  12. Garvin Hicking voted on patch set 3 CR +1 V +1 11/09/25, 13:49

  13. Garvin Hicking voted on patch set 3 CR +2 V +2 11/10/25, 17:02

  14. Garvin Hicking merged patch set 4 11/10/25, 19:25