Review main Merged

91456[FEATURE] Multi-language selection in page and list modules

Oli Bartsch CR +2 V +2 Nightmare +4060 −1065 updated 11/22/25, 22:35

Commit message

This change introduces the ability to select multiple
languages simultaneously for comparison in both the
page module and list module.

Language selection state is synchronized between both
modules, providing a consistent editing experience when
switching between page and list views.

All components (BackendLayoutRenderer, DatabaseRecordList,
PageLayoutContext, ContentFetcher) have been updated to
work with multiple selected languages.

This is based on a completely new PageContext API,
which for now is @internal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 42

Show 22 more files

Review log 3553

Show 1628 earlier messages
  1. Oli Bartsch uploaded patch set 1 11/09/25, 15:30

  2. core-ci voted on patch set 1 V -1 11/09/25, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88741

  3. Oli Bartsch uploaded patch set 2 V -1 11/10/25, 09:39

  4. core-ci voted on patch set 2 V -1 11/10/25, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88810

  5. Oli Bartsch uploaded patch set 3 V -1 11/10/25, 10:34

  6. core-ci voted on patch set 3 V +1 11/10/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88823

  7. Oli Bartsch uploaded patch set 4 V +1 11/13/25, 14:32

  8. Oli Bartsch updated the commit message in patch set 5 11/13/25, 14:34

  9. core-ci voted on patch set 4 V -1 11/13/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89522

  10. core-ci voted on patch set 5 V -1 11/13/25, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89523

  11. Oli Bartsch uploaded patch set 6 V -1 11/14/25, 17:14

  12. core-ci voted on patch set 6 V -1 11/14/25, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89702

  13. Oli Bartsch uploaded patch set 7 V -1 11/14/25, 17:32

  14. core-ci voted on patch set 7 V -1 11/14/25, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89704

  15. Oli Bartsch uploaded patch set 8 V -1 11/14/25, 18:01

  16. core-ci voted on patch set 8 V -1 11/14/25, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89705

  17. Oli Bartsch uploaded patch set 9 V -1 11/15/25, 09:23

  18. core-ci voted on patch set 9 V +1 11/15/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89774

  19. Georg Ringer voted on patch set 9 CR +1 V +1 11/15/25, 20:59

  20. Garvin Hicking commented on patch set 9 11/16/25, 00:42

    Feature-108016-MultiLanguageSelectionInPageAndListModules.rst:14

    ```suggestion The :guilabel:`Content > Page` and :guilabel:`Content > List` modules now support ```
  21. Jasmina Ließmann uploaded patch set 10 CR +1 V +1 11/18/25, 16:44

  22. Jasmina Ließmann commented on patch set 10 11/18/25, 16:44

    Feature-108016-MultiLanguageSelectionInPageAndListModules.rst:14 Reply

    Done
  23. Oli Bartsch commented on patch set 10 CR -1 11/18/25, 16:48

    Currently on it
  24. core-ci voted on patch set 10 V +1 11/18/25, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90060

  25. Oli Bartsch uploaded patch set 11 CR -1 V +1 11/18/25, 21:43

  26. Oli Bartsch uploaded patch set 12 11/18/25, 21:54

  27. core-ci voted on patch set 11 V -1 11/18/25, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90075

  28. core-ci voted on patch set 12 V -1 11/18/25, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90077

  1. Oli Bartsch uploaded patch set 13 V -1 11/18/25, 22:31

  2. core-ci voted on patch set 13 V +1 11/18/25, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90079

  3. Georg Ringer commented on patch set 13 11/18/25, 22:52

    I really love the feature. What I am unsure about is the default language item in the compare view in page module. the item looks like it can be unchecked, but of course it is now. in the layout-view this is possible. furthermore the default got a slightly different color then the others. Additionally the "check all" is above the default + languages and with the icon before it looks like it can be unchecked. I suggest to render the default language above (or below the available languages) the items of "create new translation" should maybe also have an icon to be in line? no -1 for such minor nitpicks, and also a personal view!
  4. Oli Bartsch uploaded patch set 14 V +1 11/19/25, 10:31

  5. Oli Bartsch commented on patch set 14 11/19/25, 10:37

    Reply

    Thank you for your input! I've updated the implementation. IN comparison view, the toggle button is now below the available languages, the default is always on the top and separated. All buttons have now title / aria-label describing their purpose and for the default e.g. the reason why it is "disabled". The icons of the toggle button is the same as for multi record selection. For consistency this should be kept. The languages to be translated do not have a left spacing because they are normal links without any state indicator. I would like to also kept this as this is the current API and would need manual adjustments for this single use case.
  6. core-ci voted on patch set 14 V +1 11/19/25, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90122

  7. Oli Bartsch commented on patch set 14 11/19/25, 10:56

    Reply

    Done
  8. Oli Bartsch uploaded patch set 15 V +1 11/19/25, 18:28

  9. core-ci voted on patch set 15 V -1 11/19/25, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90190

  10. Oli Bartsch uploaded patch set 16 V -1 11/19/25, 19:50

  11. core-ci voted on patch set 16 V +1 11/19/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90196

  12. Georg Ringer voted on patch set 16 CR +1 V +1 11/19/25, 21:05

  13. Oli Bartsch uploaded patch set 17 CR +1 V +1 11/19/25, 21:07

  14. Georg Ringer voted on patch set 17 CR +1 V +1 11/19/25, 21:09

  15. core-ci voted on patch set 17 V +1 11/19/25, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90203

  16. Garvin Hicking commented on patch set 17 CR +1 V +1 11/19/25, 21:33

    This is huge in every way. I have to admit: My vote is mostly wishful thinking, and more based on "verified" than "code review". <soapbox /> I believe this is so meaningful to have, that we should take the risk to implement this and fix possible issues in follow-ups. Now is the time for it, and the impact on content editing and API unification is something we should not pass up on for v14.
  17. Georg Ringer commented on patch set 17 V -1 11/19/25, 23:09

    as written via private: root page is now showing tons of "this content is also shown on...."
  18. Oli Bartsch uploaded patch set 18 CR +1 V +1 11/20/25, 07:57

  19. Oli Bartsch commented on patch set 18 11/20/25, 07:58

    Reply

    Thanks, fixed.
  20. core-ci voted on patch set 18 V +1 11/20/25, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90233

  21. Georg Ringer voted on patch set 18 CR +1 V +1 11/20/25, 08:49

  22. Garvin Hicking voted on patch set 18 CR +1 V +1 11/20/25, 08:52

  23. Oli Bartsch voted on patch set 18 CR +2 V +2 11/20/25, 09:00

  24. Oli Bartsch merged patch set 19 11/20/25, 09:00

  25. Christian Kuhn commented on patch set 19 11/22/25, 22:35

    PageContextInitialization.php:61 Unresolved

    looking at this middleware after a debugging session i wonder if that is the best approach we can take after all: * this hard interprets 'id' as page-id. this may be fine but has drawbacks as well, and we already had issues with this in the past, for instance because filelist (mis?)-used id as storage-id:path identifier. this solution finally hard codes 'id' meaning now. * same issue with 'edit', 'cmd' and others below which are now elevated to 'global meaning'. this pulls controller knowledge into central middlewares. * it seems this middleware is relatively epensive for some of the calls that are supposed to be very quick like various of the ajax calls. * i don't quite understand if this ultimately *has* to be a middleware? why not have a service that receive the request and returns whatever is needed? then inject that service into dependent controllers and be done? if performance is an issue if that spreads through multiple dependencies, wrap in a runtime cache, done. which architectural need forces us putting this stuff into an always-on middleware? * we already had one bugfix that had to fix a user logged-in/not-logged-in case. all in all, it feels to me as if we should reconsider. what do you think?