Review main Merged

91461[BUGFIX] Enable TypoScript overrides for domain reference labels

Lina Wolf CR +2 V +2 Normal +169 −35 updated 12/03/25, 05:12

Commit message

When using the language domain syntax (e.g. `label_test.messages:key1`),
labels were previously not affected by TypoScript overrides.

If the language domain includes the "messages" part, the corresponding
extension can be derived reliably, allowing TypoScript label overrides
to apply correctly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1517

  1. Lina Wolf uploaded patch set 1 11/10/25, 07:19

  2. core-ci voted on patch set 1 V +1 11/10/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88799

  3. Lina Wolf commented on patch set 1 11/10/25, 07:33

    If https://review.typo3.org/c/Packages/TYPO3.CMS/+/90457 gets merged, the tests can still be used to ensure that the behaviour is preserved.
  4. Garvin Hicking uploaded patch set 2 V +1 11/10/25, 15:24

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 11/10/25, 15:28

    I adapted the indentation, and moved the dataProvider in front of the test. I love that you expanded the tests for that, this is very helpful, thank you!
  6. core-ci voted on patch set 2 V +1 11/10/25, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88867

  7. Benni Mack commented on patch set 2 11/13/25, 08:44

    we expliitly did not do this, so people can really migrate to a) either domain-syntax b) or stick with LLL in the end, we should avoid using LLL in v16/v17 completely.
  8. Garvin Hicking voted on patch set 2 CR 0 V 0 11/13/25, 10:20

  9. Lina Wolf commented on patch set 2 11/13/25, 10:30

    Reply

    I do not really understand this comment. Does that mean we are phasing out the TypoScript overrides? Shouldnt we then mention in some kind of deprecation warning that it DOES NOT work for the new domain syntax?
  10. Benni Mack commented on patch set 2 11/20/25, 12:50

    Reply

    OK. As discussed directly, I need to evaluate this piece of code closer, but my assumption was not true.
  11. Benni Mack voted on patch set 2 CR +1 V +1 12/02/25, 13:43

  12. Garvin Hicking voted on patch set 2 CR +1 V +1 12/02/25, 13:55

  13. Benni Mack voted on patch set 2 CR +2 V +2 12/02/25, 17:17

  14. Benni Mack merged patch set 3 12/02/25, 17:17

  15. Oliver Hader commented on patch set 3 12/02/25, 20:05

    LocalizationUtilityTest.php:58

    `label_test` seems to be missing here

    LocalizationUtilityTest.php:61

    `label_test` seems to be missing here
  16. Oliver Hader commented on patch set 3 12/02/25, 20:08

  17. Lina Wolf commented on patch set 3 12/03/25, 05:12

    LocalizationUtilityTest.php:58 Reply

    Done

    LocalizationUtilityTest.php:61 Reply

    Done